Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp974099ybm; Fri, 29 May 2020 17:21:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxn+/sbNfbtHIrAjgK1DGP/2/YuLBGtJ5OhbjNz0xnSbsMr0X9ZXjWu8BcSF6HfIpJ48Jxz X-Received: by 2002:a05:6402:b0b:: with SMTP id bm11mr11213685edb.92.1590798094907; Fri, 29 May 2020 17:21:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590798094; cv=none; d=google.com; s=arc-20160816; b=WDTRLMX7c0yN66T+VjknSyg3/Mzy2qnvu1y66pXdeFwp9s8dkcvM/CzcudbX6cGZzi QOoyX55xD8j/NLcuoWml1MXhi/tDJ09A27QUfs/KDvY6aHucbHLBjVHwRY8OJZkag433 dljX6lrOfM3MZw7LdUGDbUDg8nvyrDNxbHd9DToD6tvODQ/HKP/da7ATrHuUwvU1h3Nf 2VUiVxssZ2EsTPQuVzQZCABO5dED6GYLJPrHbRLYpFSDE3W3poo7FeqkwuqUyELYmTTh iRmnTGlW0MabPplpE1TELvskBvu/LHw5cUO1+TeklT+sS+WWX8Yi9zf0U4ElErmzfSor sEbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=0tBf4qwBvbhjkM8PvuI5tK76f+FHGBbJ1EU/m3OdkXk=; b=ZYrCZoqXBIt7kufwKGiZCT3WuKQLBAYqFE9raMdyloJC2mcvkT3X0KV70koK1yp6FU H3ig4Mo/8PErQPmcU3gXxZEerT4zSAn28Oh2CMT2tWMWeY/t0u1XXba5LhVvfIGsNzHs ffLKIG0uobIIKhYvhBCwygDdhoUxaahr0RFk4OwqOWgrxgjaXrQTo5NbPCGx53PMSxua lt9xjshGXpjeaIVCeCToYwSvm3PzZ4mRAQd3M1YrS3aqXJ40GgnysJQBFV5FCxIDjjKM 91G1oCxa1XF7+I6WLMqaUk42kfHfjERh5HDySqMd74lVDZT7L9lq78yvNhwmGgQfzIt/ 9rcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z2si7321872eja.516.2020.05.29.17.21.11; Fri, 29 May 2020 17:21:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728623AbgE3ASn (ORCPT + 99 others); Fri, 29 May 2020 20:18:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726898AbgE3ASm (ORCPT ); Fri, 29 May 2020 20:18:42 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09191C03E969; Fri, 29 May 2020 17:18:42 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A662212875205; Fri, 29 May 2020 17:18:40 -0700 (PDT) Date: Fri, 29 May 2020 17:18:39 -0700 (PDT) Message-Id: <20200529.171839.213046818110655879.davem@davemloft.net> To: vadym.kochan@plvision.eu Cc: kuba@kernel.org, jiri@mellanox.com, idosch@mellanox.com, andrew@lunn.ch, oleksandr.mazur@plvision.eu, serhiy.boiko@plvision.eu, serhiy.pshyk@plvision.eu, volodymyr.mytnyk@plvision.eu, taras.chornyi@plvision.eu, andrii.savka@plvision.eu, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mickeyr@marvell.com Subject: Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices From: David Miller In-Reply-To: <20200528151245.7592-2-vadym.kochan@plvision.eu> References: <20200528151245.7592-1-vadym.kochan@plvision.eu> <20200528151245.7592-2-vadym.kochan@plvision.eu> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 29 May 2020 17:18:41 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please remove all of the __packed attributes. I looked at your data structures and all of them use fixed sized types and are multiples of 4 so the __packed attribute is completely unnecessary. The alignment attribute is also unnecessary so please remove that too.