Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 30 May 2020 03:46:22 +0300
From:   Vadym Kochan <vadym.kochan@plvision.eu>
To:     David Miller <davem@davemloft.net>
Cc:     kuba@kernel.org, jiri@mellanox.com, idosch@mellanox.com,
        andrew@lunn.ch, oleksandr.mazur@plvision.eu,
        serhiy.boiko@plvision.eu, serhiy.pshyk@plvision.eu,
        volodymyr.mytnyk@plvision.eu, taras.chornyi@plvision.eu,
        andrii.savka@plvision.eu, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, mickeyr@marvell.com
Subject: Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera
 family ASIC devices
Message-ID: <20200530004622.GA19411@plvision.eu>
References: <20200528151245.7592-1-vadym.kochan@plvision.eu>
 <20200528151245.7592-2-vadym.kochan@plvision.eu>
 <20200529.171839.213046818110655879.davem@davemloft.net>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200529.171839.213046818110655879.davem@davemloft.net>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from plvision.eu (217.20.186.93) by AM6PR0502CA0042.eurprd05.prod.outlook.com (2603:10a6:20b:56::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17 via Frontend Transport; Sat, 30 May 2020 00:46:29 +0000
X-Originating-IP: [217.20.186.93]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 459fdea9-292d-4307-d577-08d80432e4ca
X-MS-TrafficTypeDiagnostic: VI1P190MB0304:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1P190MB0304F90262230D28118CF5D1958C0@VI1P190MB0304.EURP190.PROD.OUTLOOK.COM>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-Forefront-PRVS: 041963B986
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: WkpZhtK+Gzhveyvw6MoIJHTbz477moxSWQZ+ma6lGyBQSRPhhimUrRGIrGy+0YokCG4xcvAzZ3OKSjlC1xWePHwv1pVfSv59HHmYEXYkfcregtVBS21YCmie/yUxi2rkbVsrE7uy9lOgIo4WoYeUL6zDGWAkiiIBAJQMUYC/Vu9Km6Jm8vwKHHKc7U2Z+rlZcuiq7mnEd2llJIbmBxCdIMjLIIP8SNkZJrjX7CGIq8GY+r6pk551IW30xyed6dhSZNVLYSJGZkrGeieDsHR7C7T2pcFHCq48oEgdKcVHI/5wjpJ9M4yb2W0Iy3tVbwbyR/AY6upi8VVtrC609rui0Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1P190MB0399.EURP190.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFTY:;SFS:(136003)(376002)(39830400003)(346002)(366004)(396003)(26005)(508600001)(8936002)(5660300002)(6666004)(6916009)(8886007)(83380400001)(7696005)(4326008)(52116002)(86362001)(956004)(316002)(2906002)(44832011)(1076003)(4744005)(36756003)(2616005)(33656002)(55016002)(186003)(16526019)(66556008)(66946007)(66476007)(8676002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: hNhy3bEmv4C3+uC4pg9pocuVhSozMTufRkFFWiFB3EJ882YUa6iZWd98xOHS2bDm7CZ4whUqSogat1QUAEvLgqXQ8Faj+ugmA+vqYvUqg4hbFgcavKeNSbQWK2S6R7C6ZsJDTMQgyOY47lHGUH2Osc//gClmzhcaTih7q1svCqLGLYTI3pjugIFmeDu9xpTr/ynD6XSQBTEmuyLslKxk8UdvD6JyCgmdkXGNDuDm51pJ0tku1MIIoHIdKzmK8czl64McILQgqBKALijt0kd21YGeOKWkEf/9M2JXLFNKn7IwQ7bzQyu2Y0RbUkVB6Igkz3hPgQDJkdHMXEWZ05CqKGRV5AK5TaM8vRmdcuyig6ErWFZ5n4psgfcjQEyfsQJpRVBpFqs4A4T0f6uKARySeUS/Ssa914a+yYt1njSRPEINQLLSQ6fkoSZD2nRHPQvmVXoPpbo2x3zjYVXi6FonhD8hh2/jyGucWLX9sKgu5lY=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: 459fdea9-292d-4307-d577-08d80432e4ca
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2020 00:46:30.8318
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: saSiBd1BSvW2nUdh13TFXVJTRSMJuA1gWCaY0/k+UNaWprNayw/k6CS7y24h+3wY1ZQJ7sJ+PR8awM3ZGEije5zwsX/DHlDgmERpuUGVPFM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1P190MB0304
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi David,

On Fri, May 29, 2020 at 05:18:39PM -0700, David Miller wrote:
> 
> Please remove all of the __packed attributes.
> 
> I looked at your data structures and all of them use fixed sized types
> and are multiples of 4 so the __packed attribute is completely
> unnecessary.
> 
> The alignment attribute is also unnecessary so please remove that too.

Some of the fields are u8, so I assume there might be holes added by
the compiler ? Also these attributes guarantee some ABI compatibility
with FW side, I will try to remove them and check but it sounds for me a bit
risky.