Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp995867ybm; Fri, 29 May 2020 18:02:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFRmRW4uIpqEGVv368uDD/iZicVP3Nc5g5InVw1Bs9JzrHswdDyiH6kUbpVzaGv3cF1v4j X-Received: by 2002:a05:6402:17e6:: with SMTP id t6mr10453828edy.243.1590800535174; Fri, 29 May 2020 18:02:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590800535; cv=none; d=google.com; s=arc-20160816; b=XIiorNSLHlnYA1NoVHCS3A20Ta1PG/jR4ywYe/tOzh+D+AmJTIRT/5o3Tjto6EjBbi SPnAS0q7ARpGgbSojVg4IdsyJbiU0E5nxHqcUlXY83MfdrOfJ1gtZohldai4Ia5c/plq 1xNaR50PZQ2ZQT7VEtxgMp4GQsdQEi74txzi44dlVYS4H9wrSSWJWFz3F9qfXyGpbpKp BghGS+W4YKq0g4SBCk5NRk4F/9Ka3OyHkH2j1TN5Psqz99oP5KQHUzRHPC3cyDTk0Nja jMJ0VuMF5peXG5+XFe37K9y5IW3pbFsd5Q9ZsJolNp/6x9ZeE83mEgYxiudgxVqSLdgB ETow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=nsXprg+H+35Iohp+gqAlpriRYTbCrW8s8/pjxvdNm/E=; b=ary5wtzmIwu2P/bExtfDi5LoqGkfi9QvNqtn12UfC/o+/KgaLgalrOysTIjAwGS3RR Kp6DSla65IPYiQXu9CZAn+Gllu6KkS5vH5iJ3aG0x3bi7HL4FOIlflLLjq43Wg0mgZYU RcIbsndw9JofbgyWDNDaIqrb+03LPhwZhUWfW+hqMtpVCOfh9h3HgYoCdQiXW0/OTKRP caNiHi9oCUZ9V89E3xhUmP9+MP6XXhEaGvtUHf7++0zoTV1dDqWihImgvg+t94kKGLvZ nlie3ovnClP2IHR/egKTbyCVwU+Vp+cyPfgiQWKMre8MaFKH+l8WXLTk+mj7Q8Mw9Boq udfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gt26si2277495ejb.750.2020.05.29.18.01.52; Fri, 29 May 2020 18:02:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728293AbgE3BAA (ORCPT + 99 others); Fri, 29 May 2020 21:00:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:41670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727876AbgE3BAA (ORCPT ); Fri, 29 May 2020 21:00:00 -0400 Received: from [10.44.0.192] (unknown [103.48.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A80A620810; Sat, 30 May 2020 00:59:58 +0000 (UTC) Subject: Re: [PATCH v2 0/2] fix missing handling of __user in nommu's uaccess() To: Luc Van Oostenryck , Geert Uytterhoeven Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org References: <20200529190218.36560-1-luc.vanoostenryck@gmail.com> From: Greg Ungerer Message-ID: Date: Sat, 30 May 2020 10:59:55 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200529190218.36560-1-luc.vanoostenryck@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Luc, On 30/5/20 5:02 am, Luc Van Oostenryck wrote: > I received a bug report for an unrelated patch when used with m68k-nommu. > It appears that the origin of the problem is that __get_user() and > __put_user() doesn't handle correctly __user. These 2 patches fix this. > > Note: this is only minimaly tested but is quite straightforward and > since this only change __user annotation it will not change the > generated code. > > > Changes since v1: > * fix typo: s/plan/plain/ > * appease checkpatch with better style: s/__force*/__force */ > * avoid excessive line length caused by the added cast. > > Luc Van Oostenryck (2): > m68k,nommu: add missing __user in uaccess' __ptr() macro > m68k,nommu: fix implicit cast from __user in __{get,put}_user_asm() > > arch/m68k/include/asm/uaccess_no.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Looks good, thanks for the fixup. Applied to the m68knommu git tree, for-next branch. Regards Greg