Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp1002084ybm; Fri, 29 May 2020 18:13:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdnWZ/OxqpH5ds7At6/mGrcU+EDYlq3Phrobz/KHLdqNmYEhODslWyCUy5wfdpaeP3OpTN X-Received: by 2002:a17:906:57d3:: with SMTP id u19mr10352149ejr.401.1590801195907; Fri, 29 May 2020 18:13:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590801195; cv=none; d=google.com; s=arc-20160816; b=sLdzc/J2E5qf4u4DguPB3Pcp1a6JGyRxdR/3Ek/AuJLJddqja6MZA1VGlLTVg0Kk9h VQ1bNesPZ+et0aFPeXDp9tZwV8WJ8dWECNYBedaGAS4uRPnfETQNwA0y5jkvbYknUAVS TIhmAqWUp6JIRnpWpJPR2r7CL4qSJBOcYZxLTLrYfgIBTiTNxn8zLFp2rRZ+D2yhql1w RBnOQORwMkzsGriWBLbeZYEnXpiCEUx3Ap+LBzBNP/lzXt7YVZgthCFJM5YwgDztTKy4 zyZPE+qYdJ0hE9bagG9RV0qGYFrceAglZJTO47/spGcE+ev2GslfK+XNvLNCsKCw7Bs8 FTEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=uDyypAaPcQDNcm8eTstKKhOEZbyO8T+IRrN/R9ZPC+M=; b=BFEibOfmL3kuM0eDOI44OJUjkZ+seV+4vxxTQNtit2mNpxXwlUFq3bZ3120+Gkzv0z hln0B7ei8QO8q8Ix031pFg09oOj4lf2FFZYyUjeE92o7sAa6edYqNofBWOxI3FzgC06q urQIYM7vtVpsDWCJ+Lh3eKHhhNqNGumdHyiwxGH6a8dF0ZXNtCcBBtIBCLqBcaDDVJcR oBvr9FqufZXvv6a3ted46fb5la0XIEiuIjeIlkENxcxH4GarQbGEpWrbddrRBJNSYCbE zwP8MSYZJz5YC6M0w8QcayZkh9fn8SdjeXdm+jVWwqStjE/N6hdV761RdVeda9x4z84u GryA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t11si6326142edt.523.2020.05.29.18.12.53; Fri, 29 May 2020 18:13:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728743AbgE3BKf (ORCPT + 99 others); Fri, 29 May 2020 21:10:35 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:49928 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728623AbgE3BKJ (ORCPT ); Fri, 29 May 2020 21:10:09 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 5B567D68AFEBCFC7D1BF; Sat, 30 May 2020 09:10:06 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Sat, 30 May 2020 09:09:59 +0800 From: Huazhong Tan To: CC: , , , , , , Huazhong Tan Subject: [PATCH net-next 5/6] net: hns3: fix two coding style issues in hclgevf_main.c Date: Sat, 30 May 2020 09:08:31 +0800 Message-ID: <1590800912-52467-6-git-send-email-tanhuazhong@huawei.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1590800912-52467-1-git-send-email-tanhuazhong@huawei.com> References: <1590800912-52467-1-git-send-email-tanhuazhong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove a redundant blank line in hclgevf_cmd_set_promisc_mode(), and fix a reverse xmas tree coding style issue in hclgevf_set_rss_tc_mode(). Reported-by: Jian Shen Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c index a8c0e79..1b9578d 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c @@ -669,8 +669,8 @@ static int hclgevf_set_rss_tc_mode(struct hclgevf_dev *hdev, u16 rss_size) u16 tc_size[HCLGEVF_MAX_TC_NUM]; struct hclgevf_desc desc; u16 roundup_size; - int status; unsigned int i; + int status; req = (struct hclgevf_rss_tc_mode_cmd *)desc.data; @@ -1143,7 +1143,6 @@ static int hclgevf_cmd_set_promisc_mode(struct hclgevf_dev *hdev, send_msg.en_mc = en_mc_pmc ? 1 : 0; ret = hclgevf_send_mbx_msg(hdev, &send_msg, false, NULL, 0); - if (ret) dev_err(&hdev->pdev->dev, "Set promisc mode fail, status is %d.\n", ret); -- 2.7.4