Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp1026482ybm; Fri, 29 May 2020 19:06:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxc638QEX5SIaAQxAAx7o6eKGFR86uklZhkjNrhSdyRDQ51FYYI9s0SUPJNheB7OQWLdbKR X-Received: by 2002:a05:6402:690:: with SMTP id f16mr11673848edy.9.1590804373175; Fri, 29 May 2020 19:06:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590804373; cv=none; d=google.com; s=arc-20160816; b=NQT/1wSc6b9+EQdcHicJq3yLP6MZMwaBDI17XmoVZsgfczdJrbbDHt2h4fzepJPkSC CHc+BS+hXsXs3aIL5XGDs7gnnAaizdCmE9r7GHRZxGQnuZlAsh06UqT9Iy4Vm/86d0np 2PDZ5kkR4GVV4ic6/CLXY2mTJGwQ2aBVORxGBuvMBUQK+G0lSrzXPmQEnuSngyQAgk93 8jiyMHrS1ZckOi3MIJwBdozEsPu9UKYZywZOrRbWazLfHSQ91pecS5WzOCiPpvoXRaWz riC2lDGTR1tbe0QdHFOMnxqkTDA/i8ykd7G/3aWEsvlyt9hUtQJxmWpAamadW+7XFPZa HYEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=cptAMfJ5jMwe4516LY12Uka1II+XMKvV22eHo1ERzcc=; b=KJTi9T+w0J6bApsbVV2Lzj6P9qeobIbcmbddflJr33PzY/0HvF5u23QibLcjbwlzZQ cU956ewjZgX2ybe5cn28MTUoBXuCXN07OpXqthakxOWQhKT+yGPGtIbV4fC9WWuySsRx 6TRLDi8fnfBGahfG77/1tK06t3EKKSqpZgi/TDt/GcBLHMke0rux7sybNAkAJhPrXsE9 eUngSFrL8hdOVd5rdVYGy3yfV+UPoXv0HvQ8IgoWGuV5OYEtwNIbfenHS7GRpLVT04uZ Nt4MuFa9s9TZ5ObmC3chEhJ1c/W2BUzVavhpj+E0bGAMA0bemYubzKGYTTSwloiq7Hej uSCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i13si7013779ejg.502.2020.05.29.19.05.50; Fri, 29 May 2020 19:06:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728675AbgE3CDQ (ORCPT + 99 others); Fri, 29 May 2020 22:03:16 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:58849 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727876AbgE3CDQ (ORCPT ); Fri, 29 May 2020 22:03:16 -0400 Received: from localhost (lfbn-lyo-1-15-81.w86-202.abo.wanadoo.fr [86.202.110.81]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 996AD200004; Sat, 30 May 2020 02:03:14 +0000 (UTC) Date: Sat, 30 May 2020 04:03:14 +0200 From: Alexandre Belloni To: Chuhong Yuan Cc: Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] rtc: rv3028: Add missed check for devm_regmap_init_i2c() Message-ID: <20200530020314.GJ3972@piout.net> References: <20200528103950.912353-1-hslester96@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200528103950.912353-1-hslester96@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/05/2020 18:39:50+0800, Chuhong Yuan wrote: > rv3028_probe() misses a check for devm_regmap_init_i2c(). > Add the missed check to fix it. > > Fixes: e6e7376cfd7b ("rtc: rv3028: add new driver") > Signed-off-by: Chuhong Yuan > --- > Changes in v2: > - Add fixes tag. > > drivers/rtc/rtc-rv3028.c | 2 ++ > 1 file changed, 2 insertions(+) > Actually, this is the one I applied. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com