Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp1108782ybm; Fri, 29 May 2020 22:19:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxywdUcg/SJLtjcyqZAXEQUO/exUfSa2SqI759suX9O+6rmLCLPGb+zZ0Dy3cfttmvorKLZ X-Received: by 2002:a05:6402:1cb0:: with SMTP id cz16mr5003060edb.365.1590815943725; Fri, 29 May 2020 22:19:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590815943; cv=none; d=google.com; s=arc-20160816; b=W/dqN1sSU/9zl+9Y04/EfMS4s8w4eQLcPKrlT9bcnXiE1TVV5xE3HT/oObVx9YsF72 a1pI/Dkxcx3dwsmpYM3Imu3fs5Fm+BkidAFVSHV3QiTK8Dh9VIYAgLpvXvYNUWC/4ywC 1Iyj+Qm9IinVPdDp2AhMIcU4l3B5jtQg244k5VIivKfFPknFfN4Vr0iSDb8InwzvwJaD NsXtBL8ZyBm7P1P7rePLWQTe8Io0J2ixXtOzWbjya3RVgqBUmeZWBWLwxZE4E36dHImx zT3m4boQnlQn0riPRCdmOW1bcmQaolnGcqSl0oLWFaC7UfadqPS+t78FNf9AEDbUhMlO cDog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=7S20FztB4K8bcmYO9k53Hoe+v+Wmx6EAuufw39WkQKo=; b=mOcCv+WmnLf1rus5VRbna1O5DYmlL5yn67I2LpFg/PNhif9r9r00qzrRRjWD1GiIi/ xATapeYb/0IeQB0J0oMOV1SRdn3BLObKuXwVa9yE18lxGqdfqe5DNGRIlLd9Jvo1F7LX lHpXtzWygznZEZLMAuGrQ4IiIBQ45nx4oE9hMUGSreh5+Grj9AXaHpm1G3hlK0V12+Q2 vn0DMMPWEsLAeKl873X/OmwkWRaSY9gZ1l+s+2RoQI16boYGZPzJJT3CMMbJ3FFHU/7x aUAdu7H1wzMo/on10T52vzVRxMGdMQEGER7G3LbbFhwch+dZj2QMODxgvo2KUyZHkMyM R3kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=foUL+loV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o11si1860918ejc.714.2020.05.29.22.18.40; Fri, 29 May 2020 22:19:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=foUL+loV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725814AbgE3FO5 (ORCPT + 99 others); Sat, 30 May 2020 01:14:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725813AbgE3FO4 (ORCPT ); Sat, 30 May 2020 01:14:56 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 859CAC08C5C9 for ; Fri, 29 May 2020 22:14:56 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id f21so858575pgg.12 for ; Fri, 29 May 2020 22:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7S20FztB4K8bcmYO9k53Hoe+v+Wmx6EAuufw39WkQKo=; b=foUL+loVA7P01QUxP2qwibaPTEQxpnA3eZ91PRZJqkVbM88euK96+Xf0EgTCxrXOci nKNPsdxXbKexE0qIFzfdKF9DxnAk99PU7DzCH87U+Fg7ZO/1jAtxK/hEek9V6+b5aDdi rkqM5E8kfurGboZYnL9362P5gipTWx+8LR+Ec= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7S20FztB4K8bcmYO9k53Hoe+v+Wmx6EAuufw39WkQKo=; b=A8hrdtMWAb/SoURZZsPPrnYwX1dW2qC1Li3SbOXtU/GLK0aJe/rG0nrt1ESGrQpN3z bI2tMCiNaASlbAjrMSIcqR5W8hdy8VqTqaG5ufBVvGtBthfyJTYfFe7Tc/otSsLbvLFv VwVMLaSVcBItHiKFlsQ3EBNb6HI2XVI5Th7xD7gpn7uSur9oukWfJ5SqzGhDOWgpuJ3Z Ld6hfNOVQrGo7r48B9YPwxPmwIQ9CmptTYS0ZCSj3PoHi17u2iWzx9n8o++weTWYt6FP 5DSJiiuPuCV5QA1I+676/IIKJcxsW/+cnuDihx7Ef+oaDNT0lJyrJMOZnpevzytOS9eI TuBw== X-Gm-Message-State: AOAM530bhSvuzs1gGiW88zAInh5RmoIGtGbdFMKsojv0K3TpmBVKzM0q wEF8R2Wnx8kmZkNHwUuqo2AxAQ== X-Received: by 2002:a63:c34a:: with SMTP id e10mr11321164pgd.412.1590815695910; Fri, 29 May 2020 22:14:55 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id iq13sm939612pjb.48.2020.05.29.22.14.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 22:14:54 -0700 (PDT) Date: Fri, 29 May 2020 22:14:53 -0700 From: Kees Cook To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Oleg Nesterov , Jann Horn , Greg Ungerer , Rob Landley , Bernd Edlinger , linux-fsdevel@vger.kernel.org, Al Viro , Alexey Dobriyan , Andrew Morton , Casey Schaufler , linux-security-module@vger.kernel.org, James Morris , "Serge E. Hallyn" , Andy Lutomirski Subject: Re: [PATCH 1/2] exec: Add a per bprm->file version of per_clear Message-ID: <202005292212.021D7D1FF5@keescook> References: <87h7wujhmz.fsf@x220.int.ebiederm.org> <87sgga6ze4.fsf@x220.int.ebiederm.org> <87v9l4zyla.fsf_-_@x220.int.ebiederm.org> <877dx822er.fsf_-_@x220.int.ebiederm.org> <87k10wysqz.fsf_-_@x220.int.ebiederm.org> <87d06mr8ps.fsf_-_@x220.int.ebiederm.org> <877dwur8nj.fsf_-_@x220.int.ebiederm.org> <202005291403.BCDBFA7D1@keescook> <87k10unm0h.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k10unm0h.fsf@x220.int.ebiederm.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 29, 2020 at 10:23:58PM -0500, Eric W. Biederman wrote: > Kees Cook writes: > > I wish we had more robust execve tests. :( > > I think you have more skill at writing automated tests than I do. So > feel free to write some. Yeah, my limiting factor is available time. No worries; I didn't mean it as a request to you -- it was more a commiseration. :) -- Kees Cook