Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: qce4qSZpAjJVPYDLVVl9NZ6Wlcg8OV/UpLxdJJ9IGu08OlDYnx7SSL3T6jjqUFz5Ju1U94FQbi
 W4EZDOeGCc39WRl9BED1a88hOLtsmS1QwlubrNHLwmwSuX6fq3XPZu8GUBD7nKK2I8pz5U3Zs7
 bKd98qtmaI2xaIw3EmavfZtfB6T8vIOoHgHKselMAOhtSERuLeHZoCUprXsW3e7afqtpcNYNXs
 3gZuv1S74A8xaEogxRkqYhDr8geJ7JVFhx7enRk6KoZE+hUzbIvahRNX0cbzIf5HoVVI4NdxVa
 q7k=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bean Huo <huobean@gmail.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 4/4] scsi: ufs: add compatibility with 3.1 UFS unit
 descriptor length
Thread-Topic: [PATCH v4 4/4] scsi: ufs: add compatibility with 3.1 UFS unit
 descriptor length
Thread-Index: AQHWNdgFtKmSldcTVEG4bGVs4/ouSqjALopA
Date:   Sat, 30 May 2020 06:56:37 +0000
Message-ID: <SN6PR04MB46404D5B77121B367C17AEA2FC8C0@SN6PR04MB4640.namprd04.prod.outlook.com>
References: <20200529164054.27552-1-huobean@gmail.com>
 <20200529164054.27552-5-huobean@gmail.com>
In-Reply-To: <20200529164054.27552-5-huobean@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a925188-7166-43e3-cd57-08d80466990c
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2020 06:56:37.2274
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: a9Vo2zCKCdNe2PAJ3TZZynZ5Ct4kQ/nL/+nELrrVCOsXMCint+p9Elk2ohn46EW5KiAZS0I02YvOO8ZRBfQtoQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB5470
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=20
>=20
> From: Bean Huo <beanhuo@micron.com>
>=20
> For UFS 3.1, the normal unit descriptor is 10 bytes larger
> than the RPMB unit, however, both descriptors share the same
> desc_idn, to cover both unit descriptors with one length, we
> choose the normal unit descriptor length by desc_index.
This is not what your code is doing.
For RPMB - desc size will not be 0x2d but remain 256.

Your strategy is still correct IMO - if you assign the larger size,
The device will not reply with error, but with the proper buffer.

You can also rely that reading the rpmb unit descriptor will not happen bef=
ore
Reading regular luns, because this is happening in the first slave_alloc.
=20
Hence, I think you can drop the extra if, and just add the comment.

Thanks,
Avri=20

>=20
> Signed-off-by: Bean Huo <beanhuo@micron.com>
> ---
>  drivers/scsi/ufs/ufs.h    |  1 +
>  drivers/scsi/ufs/ufshcd.c | 11 ++++++++---
>  2 files changed, 9 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
> index 6548ef102eb9..332ae09e6238 100644
> --- a/drivers/scsi/ufs/ufs.h
> +++ b/drivers/scsi/ufs/ufs.h
> @@ -63,6 +63,7 @@
>  #define UFS_UPIU_MAX_UNIT_NUM_ID       0x7F
>  #define UFS_MAX_LUNS           (SCSI_W_LUN_BASE +
> UFS_UPIU_MAX_UNIT_NUM_ID)
>  #define UFS_UPIU_WLUN_ID       (1 << 7)
> +#define UFS_RPMB_UNIT          0xC4
>=20
>  /* WriteBooster buffer is available only for the logical unit from 0 to =
7 */
>  #define UFS_UPIU_MAX_WB_LUN_ID 8
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 951e52babf65..3cdc585d0095 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -3070,11 +3070,16 @@ void ufshcd_map_desc_id_to_length(struct
> ufs_hba *hba, enum desc_idn desc_id,
>  EXPORT_SYMBOL(ufshcd_map_desc_id_to_length);
>=20
>  static void ufshcd_update_desc_length(struct ufs_hba *hba,
> -                                     enum desc_idn desc_id,
> +                                     enum desc_idn desc_id, int desc_ind=
ex,
>                                       unsigned char desc_len)
>  {
>         if (hba->desc_size[desc_id] =3D=3D QUERY_DESC_MAX_SIZE &&
> -           desc_id !=3D QUERY_DESC_IDN_STRING)
> +           desc_id !=3D QUERY_DESC_IDN_STRING && desc_index !=3D
> UFS_RPMB_UNIT)
> +               /* For UFS 3.1, the normal unit descriptor is 10 bytes la=
rger
> +                * than the RPMB unit, however, both descriptors share th=
e same
> +                * desc_idn, to cover both unit descriptors with one leng=
th, we
> +                * choose the normal unit descriptor length by desc_index=
.
> +                */
>                 hba->desc_size[desc_id] =3D desc_len;
>  }
>=20
> @@ -3141,7 +3146,7 @@ int ufshcd_read_desc_param(struct ufs_hba *hba,
>                 goto out;
>         }
>=20
> -       ufshcd_update_desc_length(hba, desc_id,
> +       ufshcd_update_desc_length(hba, desc_id, desc_index,
>                                   desc_buf[QUERY_DESC_LENGTH_OFFSET]);
>=20
>         /* Check wherher we will not copy more data, than available */
> --
> 2.17.1