Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 30 May 2020 04:33:44 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Matthew Garrett <mjg59@srcf.ucam.org>
Cc:     Heiner Kallweit <hkallweit1@gmail.com>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select
 CONFIG_PCIEASPM by default")
Message-ID: <20200530113344.GA2834@infradead.org>
References: <bdc33be8-1db6-b147-cbc4-90fa0dc3d999@gmail.com>
 <20200529202135.GA461617@bjorn-Precision-5520>
 <20200529205900.whx3mxuvt6ijlqwg@srcf.ucam.org>
 <824d63d8-668c-22c8-a303-b44e30e805e1@gmail.com>
 <20200529225801.szl4obsas6ndilz4@srcf.ucam.org>
 <7c8cab08-e2d4-1952-1923-aa023ea67657@gmail.com>
 <20200530071434.vjkqxfmgo7xpls6j@srcf.ucam.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200530071434.vjkqxfmgo7xpls6j@srcf.ucam.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, May 30, 2020 at 08:14:34AM +0100, Matthew Garrett wrote:
> On Sat, May 30, 2020 at 08:33:50AM +0200, Heiner Kallweit wrote:
> 
> > It *was* default y. This changed with a914ff2d78ce ("PCI/ASPM: Don't
> > select CONFIG_PCIEASPM by default") and that's what triggered the
> > problem. If there's no easy solution, then maybe it's best to revert
> > the change for now.
> 
> Oh, sorry, I was looking at mainline. CONFIG_PCIEASPM should 
> *definitely* be enabled by default - platforms expect the OS to support 
> it. If we want to get rid of default y then I think it'd make more sense 
> to have a CONFIG_DISABLE_PCIEASPM that's under EXPERT, and people who 
> really want to disable the code can do so.

I think the fact that the EXPERT didn't get removed in the above bug
is a defintive bug.  But I'd go further and think the CONFIG_PCIEASPM
option should be removed entirely.  There is absolutely no good reason
to not build this small amount of code if PCIe support is enabled.