Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200528132605.18339-1-bparrot@ti.com> <20200528132605.18339-2-bparrot@ti.com>
In-Reply-To: <20200528132605.18339-2-bparrot@ti.com>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Sat, 30 May 2020 12:51:01 +0100
Message-ID: <CA+V-a8saE25M48f1tQDSYBkPvZtg4XoCJjuJ2PV5CAkB3ak1Tw@mail.gmail.com>
Subject: Re: [Patch 1/2] media: v4l2-rect.h: add enclosed rectangle helper
To:     Benoit Parrot <bparrot@ti.com>
Cc:     Hans Verkuil <hverkuil@xs4all.nl>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Kukjin Kim <kgene@kernel.org>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        linux-media <linux-media@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Benoit,

Thank you for the patch.

On Thu, May 28, 2020 at 2:26 PM Benoit Parrot <bparrot@ti.com> wrote:
>
> Add a helper function to check if one rectangle is enclosed inside
> another.
>
> Signed-off-by: Benoit Parrot <bparrot@ti.com>
> ---
>  include/media/v4l2-rect.h | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
--Prabhakar

> diff --git a/include/media/v4l2-rect.h b/include/media/v4l2-rect.h
> index 8800a640c224..bd587d0c0dc3 100644
> --- a/include/media/v4l2-rect.h
> +++ b/include/media/v4l2-rect.h
> @@ -184,4 +184,24 @@ static inline bool v4l2_rect_overlap(const struct v4l2_rect *r1,
>         return true;
>  }
>
> +/**
> + * v4l2_rect_enclosed() - is r1 enclosed in r2?
> + * @r1: rectangle.
> + * @r2: rectangle.
> + *
> + * Returns true if @r1 is enclosed in @r2.
> + */
> +static inline bool v4l2_rect_enclosed(struct v4l2_rect *r1,
> +                                     struct v4l2_rect *r2)
> +{
> +       if (r1->left < r2->left || r1->top < r2->top)
> +               return false;
> +       if (r1->left + r1->width > r2->left + r2->width)
> +               return false;
> +       if (r1->top + r1->height > r2->top + r2->height)
> +               return false;
> +
> +       return true;
> +}
> +
>  #endif
> --
> 2.17.1
>