Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200511055052.23868-1-joe_zhuchg@126.com>
In-Reply-To: <20200511055052.23868-1-joe_zhuchg@126.com>
From:   Jassi Brar <jassisinghbrar@gmail.com>
Date:   Sat, 30 May 2020 15:25:03 -0500
Message-ID: <CABb+yY0qBk_BgexswYOaBf4qac605KBwYxah2yD4nYeADi8Phg@mail.gmail.com>
Subject: Re: [PATCH] mailbox: no error log in mbox_client_txdone() for tx done
 by irq
To:     joe_zhuchg@126.com
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Joe Zhu <Chunguang.Zhu@verisilicon.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, May 11, 2020 at 12:52 AM <joe_zhuchg@126.com> wrote:
>
> From: Joe Zhu <Chunguang.Zhu@verisilicon.com>
>
> client does not know and not care about how controller implement tx done.
> mbox_client_txdone() may be called when controller uses irq method.
>
> Signed-off-by: Joe Zhu <Chunguang.Zhu@verisilicon.com>
> ---
>  drivers/mailbox/mailbox.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c
> index 0b821a5b2db8..116124adf188 100644
> --- a/drivers/mailbox/mailbox.c
> +++ b/drivers/mailbox/mailbox.c
> @@ -189,7 +189,9 @@ EXPORT_SYMBOL_GPL(mbox_chan_txdone);
>  void mbox_client_txdone(struct mbox_chan *chan, int r)
>  {
>         if (unlikely(!(chan->txdone_method & TXDONE_BY_ACK))) {
> -               dev_err(chan->mbox->dev, "Client can't run the TX ticker\n");
> +               if (unlikely(!(chan->txdone_method & TXDONE_BY_IRQ)))
> +                       dev_err(chan->mbox->dev,
> +                              "Client can't run the TX ticker\n");
>                 return;
>         }
If it is not by ACK, client should not call txdone() so we shout
immediately. Otherwise something is wrong.

thanks.