Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932302AbWCTNX5 (ORCPT ); Mon, 20 Mar 2006 08:23:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932301AbWCTNX5 (ORCPT ); Mon, 20 Mar 2006 08:23:57 -0500 Received: from courier.cs.helsinki.fi ([128.214.9.1]:41652 "EHLO mail.cs.helsinki.fi") by vger.kernel.org with ESMTP id S932297AbWCTNX4 (ORCPT ); Mon, 20 Mar 2006 08:23:56 -0500 Date: Mon, 20 Mar 2006 15:23:54 +0200 (EET) From: Pekka J Enberg To: Oliver Neukum cc: Denis Vlasenko , Arjan van de Ven , Matthew Wilcox , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH]use kzalloc in vfs where appropriate In-Reply-To: <200603201414.19998.oliver@neukum.org> Message-ID: References: <84144f020603192325h54fd3212l1f4846fd40b9f074@mail.gmail.com> <200603201508.47960.vda@ilport.com.ua> <200603201414.19998.oliver@neukum.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 556 Lines: 13 On Mon, 20 Mar 2006, Oliver Neukum wrote: > Why? size == 0 is a bug. We want to oops here. Why do you want to oops? The standard calloc() deals with zero so kcalloc() should probably do that as well. In any case, if you want to change the behavior, please audit kcalloc() callers before optimizing. Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/