Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] staging:r8723bs: remove wrappers around skb_clone()
To:     Joe Perches <joe@perches.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Hans de Goede <hdegoede@redhat.com>,
        Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
        Nishka Dasgupta <nishkadg.linux@gmail.com>,
        Lukasz Szczesny <luk@wybcz.pl>, R Veera Kumar <vkor@vkten.in>,
        Hariprasad Kelam <hariprasad.kelam@gmail.com>,
        YueHaibing <yuehaibing@huawei.com>,
        Shobhit Kukreti <shobhitkukreti@gmail.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Pascal Terjan <pterjan@google.com>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
References: <20200531160843.39120-1-insafonov@gmail.com>
 <7bf8612d3708b811e026daec5c7a1486c5954905.camel@perches.com>
 <8e4df253-e021-6c29-96ab-24eed9b61eb2@gmail.com>
 <24e0f572511724ea338f8802fde2ad3a359ea8d5.camel@perches.com>
From:   Ivan Safonov <insafonov@gmail.com>
Message-ID: <1803e5d8-2629-adf3-6638-0ad843273a02@gmail.com>
Date:   Sun, 31 May 2020 20:49:22 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.1
MIME-Version: 1.0
In-Reply-To: <24e0f572511724ea338f8802fde2ad3a359ea8d5.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 5/31/20 8:36 PM, Joe Perches wrote:
> On Sun, 2020-05-31 at 20:28 +0300, Ivan Safonov wrote:
>> On 5/31/20 7:15 PM, Joe Perches wrote:
>>> On Sun, 2020-05-31 at 19:08 +0300, Ivan Safonov wrote:
>>>> Wrappers around skb_clone() do not simplify the driver code.
>>> []
>>>> -inline struct sk_buff *_rtw_skb_clone(struct sk_buff *skb)
>>>> -{
>>>> -	return skb_clone(skb, in_interrupt() ? GFP_ATOMIC : GFP_KERNEL);
>>>> -}
>>>> -
>>> []
>>>> diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
>>> []
>>>> @@ -110,7 +110,7 @@ void rtw_os_recv_indicate_pkt(struct adapter *padapter, _pkt *pkt, struct rx_pkt
>>>>    			if (memcmp(pattrib->dst, myid(&padapter->eeprompriv), ETH_ALEN)) {
>>>>    				if (bmcast) {
>>>>    					psta = rtw_get_bcmc_stainfo(padapter);
>>>> -					pskb2 = rtw_skb_clone(pkt);
>>>> +					pskb2 = skb_clone(pkt, GFP_ATOMIC);
>>>
>>> Why make every clone allocation GFP_ATOMIC ?
>>
>> The rtw_os_recv_indicate_pkt() is always called from an interrupt handler.
> 
> It'd be better to indicate you know that in the changelog
> as the subject and changelog just shows removing wrappers
> and the patch code does not agree with that.

Yes, it's right.