Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 31 May 2020 20:25:20 -0400
From:   Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
To:     Emil Velikov <emil.l.velikov@gmail.com>
Cc:     Sidong Yang <realwakka@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
        Haneen Mohammed <hamohammed.sa@gmail.com>,
        David Airlie <airlied@linux.ie>,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
        ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/vkms: Optimize compute_crc(), blend()
Message-ID: <20200601002520.hajvtpefi7yzvmuq@smtp.gmail.com>
References: <20200531131237.24781-1-realwakka@gmail.com>
 <CACvgo50SzjUe6usELF33qXW3BWZmH5U4ynPTBorZLDrG-Nx2Pw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="uqybjdb5ptkemz4z"
Content-Disposition: inline
In-Reply-To: <CACvgo50SzjUe6usELF33qXW3BWZmH5U4ynPTBorZLDrG-Nx2Pw@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--uqybjdb5ptkemz4z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

First of all, thanks a lot for all your patch. And thanks Emil for your
feedback.

I have a suggestion here:

Emil:
Could you give me your Acked-by or maybe Reviewed-by for the writeback
series? With that, I can finally apply the series.

Sidong:
Secondly, after applying the writeback series, I would suggest you to
understand Emil's comments (he already provides the link) and prepare a
new patch based on that. Before you submit your patch, I recommend you
to test it with https://patchwork.freedesktop.org/series/68352/ and
kms_flip.

How about that?

Best Regards

On 05/31, Emil Velikov wrote:
> On Sun, 31 May 2020 at 14:12, Sidong Yang <realwakka@gmail.com> wrote:
> >
> > Optimize looping pixels in compute_crc() and blend(). Calculate
> > src_offset in start of looping horizontally and increase it.
> > It's better than calculating in every pixels.
> >
> When you say "optimize" have you observed any actual benefits of the
> patch - be that smaller binary, faster execution time, etc?
> If there are - mentioned them in the commit message. Otherwise, it
> doesn't optimise anything.
>=20
> A while back, I've suggested something similar [1] mostly for cosmetic
> purposes - doubt there's much benefits beyond that.
>=20
> HTH
> -Emil
> [1] https://patchwork.freedesktop.org/patch/365177/#comment_674314

--=20
Rodrigo Siqueira
https://siqueira.tech

--uqybjdb5ptkemz4z
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE4tZ+ii1mjMCMQbfkWJzP/comvP8FAl7USuoACgkQWJzP/com
vP9qrRAAnB7QXjC0la92oJUZ8yyl0o/C442cO+1HhwiRqrbRGs5Vs87vtzgZ0mDG
He5++yIGDNbnPp7eGQSa+9MVb3+/jmfzg7p+WVGLbxSZpQcO4ubR1cbaNVUctt8v
HboNRzPGulJgkky3srDRnGuVAc+2Vtq6SvlwqlK/SyB9eQIBT7EpL7Vw8RFL89zW
g9IwhXur7wQGkaqvPLgIqJgguGhVvHE++m9LcgMF8+oYWX9VlTkpfieO2YT9t+TO
YUqO2Qu/N6xPmcUXYEePXPrkktj+Sv/BREO8PyFIH4WY4o21ztWQ2LAuVb6elpbC
dL0F9JZILPZ96ScsjFErf/NqLXSThKw+S5JkKGYRVnelmf8f5QoC060CHQyDF55x
Uh5ULTbGSE4HmAotJUfOhKsxvBzalQnMrUdaxmNPwIaXd0eLQ1pqpwHPxcy+ndHz
/6LXNTAZiCSDSMBvZ9k8+zJ2blqmpbjo3cqXozC/4pqaZ3zCnDcUtqlpDZlzs34w
U8Nlv1/cdYg5ucWXHATqMoafj1J2PhYe4Z9lLXtdmAH2eDbiapn1ahdr58ATs7A1
BAuzzPMUQdqM2azwjzEh/qD06mVKEk8POtySyRjmKrOdBj8cX11AMpL+3obEQWJA
TDR1PX1KRXexuLe8dgwx4iwV6e0yL+J+NMxFn22d4xxvA28cpm4=
=cya/
-----END PGP SIGNATURE-----

--uqybjdb5ptkemz4z--