Date: Mon, 20 Mar 2006 08:25:45 -0600
From: Dimitri Sivanich <sivanich@sgi.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Andrew Morton <akpm@osdl.org>, torvalds@osdl.org,
       linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
       hch@infradead.org, clameter@sgi.com, jes@sgi.com
Subject: Re: [PATCH] Add SA_PERCPU_IRQ flag support
Message-ID: <20060320142545.GB27114@sgi.com>
References: <20060317003114.GA1735@sgi.com> <20060317152645.52112021.akpm@osdl.org> <20060318014900.65889f69.akpm@osdl.org> <20060320141747.GA27114@sgi.com> <20060320142207.GG8980@parisc-linux.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060320142207.GG8980@parisc-linux.org>
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1170
Lines: 33

On Mon, Mar 20, 2006 at 07:22:07AM -0700, Matthew Wilcox wrote:
> On Mon, Mar 20, 2006 at 08:17:47AM -0600, Dimitri Sivanich wrote:
> > On Sat, Mar 18, 2006 at 01:49:00AM -0800, Andrew Morton wrote:
> > > Andrew Morton <akpm@osdl.org> wrote:
> > > >
> > > > +#ifdef ARCH_HAS_IRQ_PER_CPU
> > > >  +	if (new->flags & SA_PERCPU_IRQ)
> > > >  +		desc->status |= IRQ_PER_CPU;
> > > >  +#endif
> > > 
> > > OK, five architectures define ARCH_HAS_IRQ_PER_CPU but only one of them
> > > defines SA_PERCPU_IRQ.    Giving up.
> > 
> > Could we do the following (at least for now)?:
> > 
> > +#if defined(ARCH_HAS_IRQ_PER_CPU) && defined(SA_PERCPU_IRQ)
> > +	if (new->flags & SA_PERCPU_IRQ)
> > +		desc->status |= IRQ_PER_CPU;
> > +#endif
> 
> Why not just
> 
> #ifdef SA_PERCPU_IRQ
> 	if (new->flags & SA_PERCPU_IRQ)
> 		desc->status |= IRQ_PER_CPU;
> #endif

Fine with me. I was simply maintaining the ARCH_HAS_IRQ_PER_CPU convention.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/