Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp237749ybg;
        Sun, 31 May 2020 23:21:44 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwwARsxkF17fpDmQf0Wqie594Lf0UXCIw4h1DY7B1FGDqos8umlAuIbJ/AHdhTUEoKSntJK
X-Received: by 2002:a50:e60b:: with SMTP id y11mr4964057edm.323.1590992503965;
        Sun, 31 May 2020 23:21:43 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1590992503; cv=none;
        d=google.com; s=arc-20160816;
        b=UfVzDuDpB0qqXfuR5VZi8LewxiGbd6dbiD8rurQaeic14nbAHijudQRF3p95dN3N7e
         yImfLg1yfdXL+UAXiFhKPVkZVZjWagBhw3kxH6vNEsVOgzTtqubnvS8DOnIThS8VZzHa
         Jt9tXu7lTEd8w2f5urR9swX2X8AOLG4/DdaIjL+tzh2aqAN/9RxfuDfHzF6nDo+ZXj5H
         dQMbwrcyap7wG21Fgr2hePcDMNATgmCHcQEC6o3rX4dhene/Z/0+XQmF4kjjcppRI6fL
         /jvIL2gFQhP5MiQjTS9LHCmAnx6CfM6RZraS2dwMOpdLR6+NQVbTIOOUoQ/SshUMf8ol
         1gVQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:mime-version:message-id
         :date:subject:cc:to:from;
        bh=sYoUNsGo245JmVJN7wCzaJp9QmYtBmfTy0LfKikZk5I=;
        b=oOFXcD9GaHxIttLuBbz44wLEzjsk309HtCzr/VRVW7WVfC4IDFI7xSs97PwC4nrgW1
         2iUXyahTU7ebr5vVYpfU8P26ghiS2WfB9Vb1hFSn9HFrGKf7lKJu4TvYZzNVtuPGh/6A
         C1YmEGEqqbD4hf3TPJx/dYC495xZEYJ6TPE9WbMnafT8KI2iaCPno5h62Va+1ubvxnzw
         Ipk4U/N9eJrfjEowaZIcgQwaKq2JMw06dPDbmXCwurwaScVNyJnaujiGz5FNCfg2uOlA
         XOupLmbDdX6onFO5V0swHX8ouvy2pyKdZwHyVzYt+V37bKGHo3tIUAFiOpDQ37bhTSYx
         D6aA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=o9bomi6d;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id p22si6853655edy.126.2020.05.31.23.21.21;
        Sun, 31 May 2020 23:21:43 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=o9bomi6d;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726156AbgFAGT1 (ORCPT <rfc822;chenhe.dev@gmail.com>
        + 99 others); Mon, 1 Jun 2020 02:19:27 -0400
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:3280 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725778AbgFAGT0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 1 Jun 2020 02:19:26 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5ed49de20000>; Sun, 31 May 2020 23:19:14 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Sun, 31 May 2020 23:19:26 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Sun, 31 May 2020 23:19:26 -0700
Received: from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL109.nvidia.com
 (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 1 Jun
 2020 06:19:25 +0000
Received: from rnnvemgw01.nvidia.com (10.128.109.123) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend
 Transport; Mon, 1 Jun 2020 06:19:25 +0000
Received: from sandipan-pc.nvidia.com (Not Verified[10.24.42.163]) by rnnvemgw01.nvidia.com with Trustwave SEG (v7,5,8,10121)
        id <B5ed49de90003>; Sun, 31 May 2020 23:19:24 -0700
From:   Sandipan Patra <spatra@nvidia.com>
To:     <treding@nvidia.com>, <jonathanh@nvidia.com>, <linux@roeck-us.net>,
        <kamil@wypas.org>, <jdelvare@suse.com>, <robh+dt@kernel.org>,
        <u.kleine-koenig@pengutronix.de>
CC:     <bbasu@nvidia.com>, <bbiswas@nvidia.com>, <kyarlagadda@nvidia.com>,
        <linux-pwm@vger.kernel.org>, <linux-hwmon@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Sandipan Patra <spatra@nvidia.com>
Subject: [PATCH V2 1/2] hwmon: pwm-fan: Add profile support and add remove module support
Date:   Mon, 1 Jun 2020 11:49:13 +0530
Message-ID: <1590992354-12623-1-git-send-email-spatra@nvidia.com>
X-Mailer: git-send-email 2.7.4
X-NVConfidentiality: public
MIME-Version: 1.0
Content-Type: text/plain
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1590992354; bh=sYoUNsGo245JmVJN7wCzaJp9QmYtBmfTy0LfKikZk5I=;
        h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer:
         X-NVConfidentiality:MIME-Version:Content-Type;
        b=o9bomi6d7dTTihpcjgpx+2XNZBXEpqVSaysojW9uV9MLLzJX7b9TSG+hEQnhbvqlI
         i6a+9WOj73uOLoazIAI7JW/ZgrZesvaCR6nfjzIP3/UpC3CpITGtFJDhc7OhN0Kg7U
         kwViLSTOoI1GUGGOqtASoe27B6w7CRZPCV9sTTaIryQB9zKAd8bLqnKR8RJIQxrdO3
         y4JOcko427vfeGAWXTK0VZeHHCN17WZ9vdd67iNcWuNMTyCjplsPwyY+ZVEklpBVjU
         WYdJY0Liv/wNSTSG+UyBM/BQT/155HFJRFRtyJpbbxAHIEDdqowcaPbZujDpB9J4Jb
         /EhUC0rRyIgAw==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Add support for profiles mode settings.
This allows different fan settings for trip point temp/hyst/pwm.
Tegra194 has multiple fan-profiles support.

Signed-off-by: Sandipan Patra <spatra@nvidia.com>
---

PATCH V2:
	Cleaned pwm_fan_remove support as it is not required.

 drivers/hwmon/pwm-fan.c | 92 ++++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 80 insertions(+), 12 deletions(-)

diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c
index 30b7b3e..1d2a416 100644
--- a/drivers/hwmon/pwm-fan.c
+++ b/drivers/hwmon/pwm-fan.c
@@ -3,8 +3,10 @@
  * pwm-fan.c - Hwmon driver for fans connected to PWM lines.
  *
  * Copyright (c) 2014 Samsung Electronics Co., Ltd.
+ * Copyright (c) 2020, NVIDIA Corporation.
  *
  * Author: Kamil Debski <k.debski@samsung.com>
+ * Author: Sandipan Patra <spatra@nvidia.com>
  */
 
 #include <linux/hwmon.h>
@@ -21,6 +23,8 @@
 #include <linux/timer.h>
 
 #define MAX_PWM 255
+/* Based on OF max device tree node name length */
+#define MAX_PROFILE_NAME_LENGTH	31
 
 struct pwm_fan_ctx {
 	struct mutex lock;
@@ -38,6 +42,12 @@ struct pwm_fan_ctx {
 	unsigned int pwm_fan_state;
 	unsigned int pwm_fan_max_state;
 	unsigned int *pwm_fan_cooling_levels;
+
+	unsigned int pwm_fan_profiles;
+	const char **fan_profile_names;
+	unsigned int **fan_profile_cooling_levels;
+	unsigned int fan_current_profile;
+
 	struct thermal_cooling_device *cdev;
 };
 
@@ -227,28 +237,86 @@ static int pwm_fan_of_get_cooling_data(struct device *dev,
 				       struct pwm_fan_ctx *ctx)
 {
 	struct device_node *np = dev->of_node;
+	struct device_node *base_profile = NULL;
+	struct device_node *profile_np = NULL;
+	const char *default_profile = NULL;
 	int num, i, ret;
 
-	if (!of_find_property(np, "cooling-levels", NULL))
-		return 0;
+	num = of_property_count_u32_elems(np, "cooling-levels");
+	if (num <= 0) {
+		base_profile = of_get_child_by_name(np, "profiles");
+		if (!base_profile) {
+			dev_err(dev, "Wrong Data\n");
+			return -EINVAL;
+		}
+	}
+
+	if (base_profile) {
+		ctx->pwm_fan_profiles =
+			of_get_available_child_count(base_profile);
 
-	ret = of_property_count_u32_elems(np, "cooling-levels");
-	if (ret <= 0) {
-		dev_err(dev, "Wrong data!\n");
-		return ret ? : -EINVAL;
+		if (ctx->pwm_fan_profiles <= 0) {
+			dev_err(dev, "Profiles used but not defined\n");
+			return -EINVAL;
+		}
+
+		ctx->fan_profile_names = devm_kzalloc(dev,
+			sizeof(const char *) * ctx->pwm_fan_profiles,
+							GFP_KERNEL);
+		ctx->fan_profile_cooling_levels = devm_kzalloc(dev,
+			sizeof(int *) * ctx->pwm_fan_profiles,
+							GFP_KERNEL);
+
+		if (!ctx->fan_profile_names
+				|| !ctx->fan_profile_cooling_levels)
+			return -ENOMEM;
+
+		ctx->fan_current_profile = 0;
+		i = 0;
+		for_each_available_child_of_node(base_profile, profile_np) {
+			num = of_property_count_u32_elems(profile_np,
+							"cooling-levels");
+			if (num <= 0) {
+				dev_err(dev, "No data in cooling-levels inside profile node!\n");
+				return -EINVAL;
+			}
+
+			of_property_read_string(profile_np, "name",
+						&ctx->fan_profile_names[i]);
+			if (default_profile &&
+				!strncmp(default_profile,
+				ctx->fan_profile_names[i],
+				MAX_PROFILE_NAME_LENGTH))
+				ctx->fan_current_profile = i;
+
+			ctx->fan_profile_cooling_levels[i] =
+				devm_kzalloc(dev, sizeof(int) * num,
+							GFP_KERNEL);
+			if (!ctx->fan_profile_cooling_levels[i])
+				return -ENOMEM;
+
+			of_property_read_u32_array(profile_np, "cooling-levels",
+				ctx->fan_profile_cooling_levels[i], num);
+			i++;
+		}
 	}
 
-	num = ret;
 	ctx->pwm_fan_cooling_levels = devm_kcalloc(dev, num, sizeof(u32),
 						   GFP_KERNEL);
 	if (!ctx->pwm_fan_cooling_levels)
 		return -ENOMEM;
 
-	ret = of_property_read_u32_array(np, "cooling-levels",
-					 ctx->pwm_fan_cooling_levels, num);
-	if (ret) {
-		dev_err(dev, "Property 'cooling-levels' cannot be read!\n");
-		return ret;
+	if (base_profile) {
+		memcpy(ctx->pwm_fan_cooling_levels,
+		  ctx->fan_profile_cooling_levels[ctx->fan_current_profile],
+						num);
+	} else {
+		ret = of_property_read_u32_array(np, "cooling-levels",
+				ctx->pwm_fan_cooling_levels, num);
+		if (ret) {
+			dev_err(dev, "Property 'cooling-levels' cannot be read!\n");
+			return -EINVAL;
+		}
 	}
 
 	for (i = 0; i < num; i++) {
-- 
2.7.4