Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp260250ybg; Mon, 1 Jun 2020 00:08:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhXFdzDJ6ep/YXX0BIQBJzIBgeYiNRZm8fzjLt08hhaqRDDL7zQVjgspY+HEQ364miHrbk X-Received: by 2002:a50:fe0d:: with SMTP id f13mr8681676edt.204.1590995317527; Mon, 01 Jun 2020 00:08:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590995317; cv=none; d=google.com; s=arc-20160816; b=Mf6ocGoRjDT21sOaC++qppHDj1nhX1BITlQTEYSHvQTnNRA0vHu06NQE9ZaJK7RcvP o1yKpFFRfMvGxfDe262XY3dHcW2Z0lvRSKhJJMJhSfNHq5gc9nN2PWN4m6Xb8UNdCmNM Ru4hFO6tTMTokTOnnriMB/Hexpojgnj5677F4lBC4Gjnjp12mwOIDhdebUrH6t8Pheiq k4dU2b5pbKMzcukM4pIQbNAZD2LDwJDt9aIbRaGVyqg1NM8Cq99qwx3pb68ZTTldeQa/ eyGHhFCLxj4fBo9fIuVC2Yid7xHEnNVB7IR6PRj5OIgvfmhwlq38Os2Vk2Rwid8NQJGJ SMWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=jY9DCJOAaosq5gwJu8ALTUFkZtJ1Ywe+yMWjig0XeuI=; b=qqs8Bu9iU1cexbPtPu7B2lYSB7ORABnCITvBuv+AtqM/x1qIjPBHaOBqaUlq7bmpQy WMEOetc5I7gZ7uvsrmlH2roZ/PA/pZk/VrgeABzfZPFhsVmSB36qWbrKEjtXG4rmh/ph XookfwLOZu4P3EPCi9BLEnH/tcNtpp0/9xQFsMCOen+PNqbdGzi7Ypih/+mgKfqRqOzE 7F8wOhoUDYaoev2qLsiaUTk3gGBhrKh2UiVEIuhxwysUPDIG7Vntlw4FMWa1zxGCw3jF /T4TlE6902ZX0hFLWXHXRLYTb/MvpZWzKUnCnvx9RfFRfzjJzaO07cqlhRxMnF+Cbh8z 8VIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=LWvw8Akz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qq18si7296095ejb.195.2020.06.01.00.08.14; Mon, 01 Jun 2020 00:08:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=LWvw8Akz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728158AbgFAHF6 (ORCPT + 99 others); Mon, 1 Jun 2020 03:05:58 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:39798 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727118AbgFAHF5 (ORCPT ); Mon, 1 Jun 2020 03:05:57 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 05175muG014787; Mon, 1 Jun 2020 02:05:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1590995148; bh=jY9DCJOAaosq5gwJu8ALTUFkZtJ1Ywe+yMWjig0XeuI=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=LWvw8AkzMeZD4hVP/yCc3jU58d4oYDZt9f/6tOwwVBqgQ+DEe+ycrne1upBinyhDe eJkN18D4GYRenJ7wmeW9o59ick5/yCedqQ5UBUqiWdmrC9XnU2psRZp4/wonQqybBY i+N+mlJObo8GiYS7eSYq+OXGTc9yX2J5L6N4QY5I= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 05175mfj052757; Mon, 1 Jun 2020 02:05:48 -0500 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 1 Jun 2020 02:05:48 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 1 Jun 2020 02:05:48 -0500 Received: from ula0132425.ent.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 051758s8016257; Mon, 1 Jun 2020 02:05:41 -0500 From: Vignesh Raghavendra To: Tudor Ambarus , Mark Brown CC: Vignesh Raghavendra , Boris Brezillon , Ramuthevar Vadivel Murugan , , , , , , Subject: [RESEND PATCH v3 6/8] mtd: spi-nor: cadence-quadspi: Drop redundant WREN in erase path Date: Mon, 1 Jun 2020 12:34:42 +0530 Message-ID: <20200601070444.16923-7-vigneshr@ti.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200601070444.16923-1-vigneshr@ti.com> References: <20200601070444.16923-1-vigneshr@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Drop redundant WREN command in cqspi_erase() as SPI NOR core takes care of sending WREN command before sending erase command. Signed-off-by: Vignesh Raghavendra Reviewed-by: Tudor Ambarus --- drivers/mtd/spi-nor/controllers/cadence-quadspi.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/mtd/spi-nor/controllers/cadence-quadspi.c b/drivers/mtd/spi-nor/controllers/cadence-quadspi.c index 0570ebca135a9..6b1cbad25e3f6 100644 --- a/drivers/mtd/spi-nor/controllers/cadence-quadspi.c +++ b/drivers/mtd/spi-nor/controllers/cadence-quadspi.c @@ -1016,11 +1016,6 @@ static int cqspi_erase(struct spi_nor *nor, loff_t offs) if (ret) return ret; - /* Send write enable, then erase commands. */ - ret = nor->controller_ops->write_reg(nor, SPINOR_OP_WREN, NULL, 0); - if (ret) - return ret; - /* Set up command buffer. */ ret = cqspi_command_write_addr(nor, nor->erase_opcode, offs); if (ret) -- 2.26.2