Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp273009ybg; Mon, 1 Jun 2020 00:33:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQyynRwbkqRjdnzSb0KGl2aYnNXOHDO3/bAkw87EPAF30/lPaOO1rTLIFWGjU3x0abXrV0 X-Received: by 2002:a17:906:b41:: with SMTP id v1mr10110435ejg.147.1590996813129; Mon, 01 Jun 2020 00:33:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590996813; cv=none; d=google.com; s=arc-20160816; b=m+S/hc+M7AD3sRsbc64TDA6sGHk+qCHFmRtje9e8L84KpGHk8XhkrvwAghiQ7foIBQ cyaV3xPr5Y1QjDi/UxwZI5uRh7BK6So8z/5OXYJSfBRhcNTJwd1hsXii6OsA885iacjz eYV8x+YMZ0Fwgm/OrRDZxIJH6R67USnd7g/+PbnRcOY7sIVpEqXvT8u5jlj/pScpr7W1 EG4CwbMP0cQcvnZgnyXOFCNU3O9aPrjiGwM/Y6+qRfz06l1QSPglVNhpgXj4PRVnm4m7 c8bHqxi6i0jIsDAyk/CUa9wKgBvvOU8YkxyV81nO/cGV0lWYa137yd9bHdqCNev0SocE 1YHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=6G1DaJ08L5P/lyjnG8cNJ/5oUXkDX01HRarXVwG8K34=; b=UNZQT3bKuksJpdDKlS40ib6zsA12x/h8DzVMh0zfehEKEm6zD6Yj68bgjnLwzcVMx0 bWs3N/EnCyHumoQKGS3L60lLIKFTcZGrfHh6feQzGS7yby93NxBn72fiZIkkFWvcElsh BqZ2+MrGvdkRyy3s6d7qqKf4tAXDVC7VQ2kuXS0bjowNh73HPtgSRs7Pw2YaQcBT6lG2 SKX6xaJnmAgi3oKJSNtlyQmJN8B8Igqx78VV/i3sXTNPzWSz+/kqojP9NHfFxLbHxJeo VnFWDBSpXXKDrJPXx0P0I8S+CQs8I9RQe/fVAD+aYPT41D5ifSrNpEM+Tvfv+31znywh /x0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ka9tP6NK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d18si10111656edz.309.2020.06.01.00.33.10; Mon, 01 Jun 2020 00:33:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ka9tP6NK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726265AbgFAHbI (ORCPT + 99 others); Mon, 1 Jun 2020 03:31:08 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:25455 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725283AbgFAHbI (ORCPT ); Mon, 1 Jun 2020 03:31:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590996667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6G1DaJ08L5P/lyjnG8cNJ/5oUXkDX01HRarXVwG8K34=; b=Ka9tP6NKbNlEanIS5BlEPIwxhcfK4fPjlvdjyu8VjKqPNcuq6/Jk4xPLvVxNVTk+H/xifS dAE9OtSsQZvieh7OrctpjErFaIw0xw9wr7N/BreJzztnhNFlhZj8eTvOueTG0gPlG1r2Xt Tv82OqQJTes7EW1YpeNeUPDOSDjapSI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-491-_qkO3InCOruLvNHvfwUAKQ-1; Mon, 01 Jun 2020 03:31:05 -0400 X-MC-Unique: _qkO3InCOruLvNHvfwUAKQ-1 Received: by mail-wm1-f71.google.com with SMTP id v23so2349200wmj.0 for ; Mon, 01 Jun 2020 00:31:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6G1DaJ08L5P/lyjnG8cNJ/5oUXkDX01HRarXVwG8K34=; b=ZjBXk3odDoWf4QibyJldhGrvpmvzmm4HHnTBxb8FLbgRcNTcIcI+rFc6sOyBb/datW DKUpTLqvQwv0WHP7jVRNipnPeTiLBEzwZ+fpW6Bgy4OT1IVx1VZcOyJza6pszZxAVv6L BCNy6xb0djRjhdbkil2bQaKW2vHgzS6f6kqBF8k/oyMqcIbeKvbKV9mh5vbaoZEH7Uv8 Mit3NzAs8U+gKrSKvkGAFklQZlpWEDOhv5/TolhEL8RqkM78G19TXtKWsdutyi4lqM9M SoKj1fX6/YUTfwRMc035R27H29wsBsl7bgAf3Ivl8P66eWqV+/TmXbW0l2rKKyfpc7At vLsQ== X-Gm-Message-State: AOAM530ILjqVvva/8SuUlJz+QyrQDJLw/SA7vi3SgfVnKCWDZHgMhQKD 6vMeKP7NWy8aNFBdEVqS8gFxpL5+puTwVxKpOS7YgUiUeq4cgP8xs9W/Tt+44kQjVH0yENDQm6j gi8Z8fOvTwY8tGiaY6Dqqb6t2 X-Received: by 2002:adf:e588:: with SMTP id l8mr22077538wrm.255.1590996664494; Mon, 01 Jun 2020 00:31:04 -0700 (PDT) X-Received: by 2002:adf:e588:: with SMTP id l8mr22075970wrm.255.1590996642714; Mon, 01 Jun 2020 00:30:42 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:e044:3d2:1991:920c? ([2001:b07:6468:f312:e044:3d2:1991:920c]) by smtp.gmail.com with ESMTPSA id m129sm10521268wmf.2.2020.06.01.00.30.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jun 2020 00:30:42 -0700 (PDT) Subject: Re: [PATCH 20/30] KVM: SVM: preserve VGIF across VMCB switch To: Krish Sadhukhan , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20200529153934.11694-1-pbonzini@redhat.com> <20200529153934.11694-21-pbonzini@redhat.com> From: Paolo Bonzini Message-ID: <18f371ca-462b-79c7-edbe-7f8576892ded@redhat.com> Date: Mon, 1 Jun 2020 09:30:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/20 01:11, Krish Sadhukhan wrote: >> >> +    svm->vmcb->control.int_ctl             = >> +        (svm->nested.ctl.int_ctl & ~mask) | >> +        (svm->nested.hsave->control.int_ctl & mask); > > > If this is the very first VMRUN, do we have any int_ctl saved in hsave ? Yes, copy_vmcb_control_area(hsave, vmcb) is called before enter_svm_guest_mode (which calls nested_prepare_vmcb_control). Paolo