Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3] drm/exynos: Remove dev_err() on platform_get_irq()
 failure
To:     Tamseel Shams <m.shams@samsung.com>, jy0922.shim@samsung.com,
        sw0312.kim@samsung.com, kyungmin.park@samsung.com,
        airlied@linux.ie, daniel@ffwll.ch
Cc:     dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        shaik.ameer@samsung.com, krzk@kernel.org, alim.akhtar@samsung.com
From:   Inki Dae <inki.dae@samsung.com>
Message-ID: <9e5608ba-a714-8bde-573d-21bd1a70757e@samsung.com>
Date:   Mon, 1 Jun 2020 17:09:54 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
        Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20200521142210.17400-1-m.shams@samsung.com>
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20200521143647epcas5p279d486b29125419c67ff96e0b5b1454e@epcas5p2.samsung.com>
        <20200521142210.17400-1-m.shams@samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


20. 5. 21. 오후 11:22에 Tamseel Shams 이(가) 쓴 글:
> platform_get_irq() will call dev_err() itself on failure,
> so there is no need for the driver to also do this.
> This is detected by coccinelle.

Picked it up.

Thanks,
Inki Dae

> 
> Signed-off-by: Tamseel Shams <m.shams@samsung.com>
> ---
> - Changes since v2:
> * Addressed Inki Dae comments
> 
>  drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> index fcee33a43aca..03be31427181 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> @@ -1498,7 +1498,6 @@ static int g2d_probe(struct platform_device *pdev)
>  
>  	g2d->irq = platform_get_irq(pdev, 0);
>  	if (g2d->irq < 0) {
> -		dev_err(dev, "failed to get irq\n");
>  		ret = g2d->irq;
>  		goto err_put_clk;
>  	}
>