Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp362153ybg; Mon, 1 Jun 2020 03:25:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHb9Zee0YOLEu/7W15TbCbGTUK6sYQ/4YvwUjJKOh+xFvxf4f4+v+27vTD3cC5bQPIBf4K X-Received: by 2002:a17:906:580e:: with SMTP id m14mr18378226ejq.447.1591007142591; Mon, 01 Jun 2020 03:25:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1591007142; cv=pass; d=google.com; s=arc-20160816; b=XsIXpG0dV1dVSIfzuHIi5lba6nOT3YyX+7bbZh4zMVGb2v9r7eQdWakVlaaw11aMoA qPKWRGRRPZB2m8CWkkHgS31cDj+/QmZPjJmF8BccaCZvoqd5CCF1b7LtxF1AOF494yLW yirm7InjFBisNKt5ho5Qc9fud+KDhsQNGx0uwdDRBbOphehJ2fB5wf9z65LlLRcR2zSl AuBhOk5E9yl4zEw/7BK84QP7MFyV2yVzGii01+heJm/rkqy2L3keqTMz7FUfSGlwweYJ hNq+99/sroQ2zWz/xcyE6SkelsGbW7DCrqNj35NTBQ1KO6Na9cfkH0JXhkvqkkbJj42V YcQw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=2jSt8IX7JyjmOEN3eg5+5LtnC7T7yOuQejgm90Y0fyE=; b=YB69eBXtDZXYr6jBD9VJ2Z9YPVBS+QWBwwEYnPuzLefMLlZ/wBFL4hzm4xhiJIJWCZ /b197zF1lhd0BagRvotbBvH9eDW6xo3/QOCp/moLm/cM3YcXhOW1/h+EdZqr3S0EFTIC +ioBm/LldNBKLX87S7WRrIIGV9toZqTnB7yKnGVpC5hqdXEF/UNCdV1GcSD33n8+N49s FBEutdS+nYPkt/IHxZsLFl/My1GmOyf9v2A+mxA+ptZba23nBeIFdQBZ0pROSGUpky2n i0IqJDT3y2gMe7eMPZux5fbNoRtLDXNT2dALlg9pIuQ3F/1XENpLsenlBdgym+/JDKqN QqKA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@xilinx.onmicrosoft.com header.s=selector2-xilinx-onmicrosoft-com header.b=WlxGuug0; arc=pass (i=1 spf=pass spfdomain=xilinx.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v13si10370484ejo.418.2020.06.01.03.25.18; Mon, 01 Jun 2020 03:25:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@xilinx.onmicrosoft.com header.s=selector2-xilinx-onmicrosoft-com header.b=WlxGuug0; arc=pass (i=1 spf=pass spfdomain=xilinx.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725977AbgFAKXd (ORCPT + 99 others); Mon, 1 Jun 2020 06:23:33 -0400 Received: from mail-bn7nam10on2040.outbound.protection.outlook.com ([40.107.92.40]:37039 "EHLO NAM10-BN7-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725847AbgFAKXc (ORCPT ); Mon, 1 Jun 2020 06:23:32 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QyZ31v6kXJl1aPqmdkCqA8YxicLVt0uDpSIFa6fCmDhJUHeMi0wCWNfKUKS2fBxQqDlV4MSYgnXgL8GGhSxHo7djphMCjHm/bO031r8v2HWZ6KCPCUHRcYh15jiwX9shgb0N06v0wPMZHstkT4hbzj7r+kqN/P+kqlwZQPQRl3uxCOC8fOmQisLm9rtgvfI/xNP1+AhgnpmPOF9Fnc4s1+DbU37MzsbkHJkQwL93HenlrlIi7XkjeY0YtnhZmyCoXcQCaGQ5YcKmPs6BWeQ9iSfb2YsUFylyZpsGLjP+adSD+wBjlwXW5+Il2ubZN8n8ZPpLSqgCmuifWTrNsotagA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2jSt8IX7JyjmOEN3eg5+5LtnC7T7yOuQejgm90Y0fyE=; b=J2J8tzof5uv3gxP/zPxfCvdU/gxqpNHI0dUO/ckf9EfebaSt3nWe+YQtB5nv0COZDatZsK8uTzoB4PtfCTDm6EiNiJD3o6bLsneodLpFtz+rI0i1KCg4pNzxDm5Nfi7OOyRwrL9Fnk6yYpXsNnG5El7IjAZypUAV1SG8PTOs4XN0v7aLu8MaL1wV0zrDVWocCoi6nc1e3aPVEppc1z5Oz4HP550E3bVZgAsUj05A5gjaoAJ3xLTIjYTHm9+EmUx1o0mvX+ZbpfU1OZeWAqogD7X1OiAJyFQGDkgIbi6k3RpWdsxJO1Nn9uDk7pCFNmc8+Oc81Bwix/JNXcx39paCPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.60.83) smtp.rcpttodomain=web.de smtp.mailfrom=xilinx.com; dmarc=bestguesspass action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2jSt8IX7JyjmOEN3eg5+5LtnC7T7yOuQejgm90Y0fyE=; b=WlxGuug0vwlD/XnicsSJPAtwvgketkpf4PihzfSP93y8eSnRoevpRII60g0eVFCJcHor6WL+D03oI0VU09kKS8W8+A8PK8GjhRYMBNZkAk9fvgL3Ex0Kbt2PdyZCPd8vv43mpJ45CSoHd4PcFvkODtCIpSgZ7hUXsC83JsvKlV8= Received: from MN2PR19CA0023.namprd19.prod.outlook.com (2603:10b6:208:178::36) by BN6PR02MB2833.namprd02.prod.outlook.com (2603:10b6:404:103::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.22; Mon, 1 Jun 2020 10:23:29 +0000 Received: from BL2NAM02FT044.eop-nam02.prod.protection.outlook.com (2603:10b6:208:178:cafe::6c) by MN2PR19CA0023.outlook.office365.com (2603:10b6:208:178::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19 via Frontend Transport; Mon, 1 Jun 2020 10:23:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; web.de; dkim=none (message not signed) header.d=none;web.de; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BL2NAM02FT044.mail.protection.outlook.com (10.152.77.35) with Microsoft SMTP Server id 15.20.3045.17 via Frontend Transport; Mon, 1 Jun 2020 10:23:28 +0000 Received: from [149.199.38.66] (port=47237 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.90) (envelope-from ) id 1jfhaf-0003cz-Ky; Mon, 01 Jun 2020 03:22:45 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1jfhbM-0008Jm-Fu; Mon, 01 Jun 2020 03:23:28 -0700 Received: from xsj-pvapsmtp01 (xsj-smtp.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id 051ANNSg023083; Mon, 1 Jun 2020 03:23:23 -0700 Received: from [172.30.17.109] by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1jfhbH-0008IW-7s; Mon, 01 Jun 2020 03:23:23 -0700 Subject: Re: [PATCH v2] tty: xilinx_uartps: Fix missing id assignment to the console To: Jan Kiszka , Michal Simek , linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com, stable@vger.kernel.org Cc: Shubhrajyoti Datta , Greg Kroah-Hartman , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org References: <170a896f-42d3-345b-7b93-c964d33fe71c@web.de> From: Michal Simek Message-ID: Date: Mon, 1 Jun 2020 12:23:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <170a896f-42d3-345b-7b93-c964d33fe71c@web.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapsmtpgw01;PTR:unknown-60-83.xilinx.com;CAT:NONE;SFTY:;SFS:(39860400002)(396003)(136003)(376002)(346002)(46966005)(82310400002)(82740400003)(81166007)(31686004)(110136005)(31696002)(2906002)(83380400001)(356005)(478600001)(26005)(54906003)(5660300002)(4326008)(186003)(53546011)(316002)(70586007)(70206006)(47076004)(2616005)(44832011)(426003)(36756003)(8676002)(336012)(8936002)(9786002)(43740500002);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: db0aa51c-3295-4acb-1261-08d80615d3b3 X-MS-TrafficTypeDiagnostic: BN6PR02MB2833: X-LD-Processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:2043; X-Forefront-PRVS: 0421BF7135 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w/7pryUCVt6O+Snj+9adshrU7VtZnoDE4FWp6KWbphbSPFfLqj7CRq4cOhlafgRt/9dnGrTpIX0xx6HZsQ5x4knboLqjee7s/mtVVb+yzlnHiUsIGDzgY8k4hzOquGU7VZr1WSLNW4Zgi4xx0gSEBLi6LvMndLEpRxHfgRYhvI63OgVdUovV+UDBXSDl5dzCgEYKdNypsSHLn/r76ziCmQFVhvQGpsjCqT4+mxsnxASsfKpA9rhnXT+Amu4YzLHUZ87rZ4V6jJtkysMxGfuO+hOEZ8qBgjPR9q+x0vRIFZt3zHHdkWu1Gd8Uy+OC7HfoYqbCwd2cIU0jpgTId2OVyaAUKn+GHOMGQajseU58cs5kD3mu8sNka04cSR+USjx7W2Rt4qkfj3I0mtWW6CmO0s3cWORRKWWn2oAlqOJnwP7Q8HaNiCfliTjtsP91IIbI X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2020 10:23:28.8613 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: db0aa51c-3295-4acb-1261-08d80615d3b3 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2833 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30. 05. 20 14:06, Jan Kiszka wrote: > On 04.05.20 16:27, Michal Simek wrote: >> From: Shubhrajyoti Datta >> >> When serial console has been assigned to ttyPS1 (which is serial1 alias) >> console index is not updated property and pointing to index -1 (statically >> initialized) which ends up in situation where nothing has been printed on >> the port. >> >> The commit 18cc7ac8a28e ("Revert "serial: uartps: Register own uart console >> and driver structures"") didn't contain this line which was removed by >> accident. >> >> Signed-off-by: Shubhrajyoti Datta >> Cc: stable >> Signed-off-by: Michal Simek >> --- >> >> Changes in v2: >> - Do better commit description >> - Origin subject was "tty: xilinx_uartps: Add the id to the console" >> >> Greg: Would be good if you can take this patch to 5.7 and also to stable >> trees. >> >> --- >> drivers/tty/serial/xilinx_uartps.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c >> index 672cfa075e28..b9d672af8b65 100644 >> --- a/drivers/tty/serial/xilinx_uartps.c >> +++ b/drivers/tty/serial/xilinx_uartps.c >> @@ -1465,6 +1465,7 @@ static int cdns_uart_probe(struct platform_device *pdev) >> cdns_uart_uart_driver.nr = CDNS_UART_NR_PORTS; >> #ifdef CONFIG_SERIAL_XILINX_PS_UART_CONSOLE >> cdns_uart_uart_driver.cons = &cdns_uart_console; >> + cdns_uart_console.index = id; >> #endif >> >> rc = uart_register_driver(&cdns_uart_uart_driver); >> > > This breaks the ultra96-rev1 which uses uart1 as serial0 (and > stdout-path = "serial0:115200n8"). Reverting this commit gives > > [ 0.024344] Serial: AMBA PL011 UART driver > [ 0.028010] ff000000.serial: ttyPS1 at MMIO 0xff000000 (irq = 19, base_baud = 6250000) is a xuartps > [ 0.028172] serial serial0: tty port ttyPS1 registered > [ 0.028579] ff010000.serial: ttyPS0 at MMIO 0xff010000 (irq = 20, base_baud = 6250000) is a xuartps > [ 0.557477] printk: console [ttyPS0] enabled > > again. Affects stable as well (seen first in 5.4). Will take a look at this. Just give me some time. M