Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <2bec05b7-78d3-fa36-134a-efbe977933e3@web.de> <45e2cd69-93ec-a0b9-b2a6-d170eee44055@huawei.com>
 <4fe27809-552e-ea98-ba1f-cbf68e625d22@web.de>
In-Reply-To: <4fe27809-552e-ea98-ba1f-cbf68e625d22@web.de>
From:   Richard Weinberger <richard.weinberger@gmail.com>
Date:   Mon, 1 Jun 2020 16:09:42 +0200
Message-ID: <CAFLxGvzS+o0Q2w1at8aJkhJ6BAcemL_LO9rrOT0O-TKewB0gYw@mail.gmail.com>
Subject: Re: [1/2] ubifs: Fix potential memory leaks while iterating entries
To:     Markus Elfring <Markus.Elfring@web.de>
Cc:     Zhihao Cheng <chengzhihao1@huawei.com>,
        linux-mtd@lists.infradead.org, Richard Weinberger <richard@nod.at>,
        kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Yi Zhang <yi.zhang@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jun 1, 2020 at 4:00 PM Markus Elfring <Markus.Elfring@web.de> wrote=
:
>
> >> I suggest to avoid the specification of duplicate function calls
> >> (also for the desired exception handling).
> >> Will it be helpful to add a few jump targets?
> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tre=
e/Documentation/process/coding-style.rst?id=3D3d77e6a8804abcc0504c904bd6e5c=
df3a5cf8162#n455
> > I've thought about using "goto err_tag_2" in kill_xattrs code block to =
release prev xent,
>
> I propose to choose better labels.
>
>
> > but later it needs to jump to 'out_release tag=E2=80=98 for releasing p=
reviously requested memory,
> > which can clutter the code.
>
> Would you like to reconsider this view?
>
>
> > It seems that two consecutive 'goto tags' will make the code less reada=
ble.
>
> How do you think about to try another software adjustment out in such a d=
esign direction?
>
>
> Can it make sense to combine changes together with the update step
> =E2=80=9Cubifs: dent: Fix some potential memory leaks while iterating ent=
ries=E2=80=9D
> into a single patch?
> https://lore.kernel.org/linux-mtd/20200601091037.3794172-2-chengzhihao1@h=
uawei.com/
> https://lore.kernel.org/patchwork/patch/1250456/

No. Please stop this kind of bikeshedding.
Zhihao, feel free to ignore all "advice" given by Markus Elfring.

--=20
Thanks,
//richard