Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: oL8/XpEFDp9VqApte47Zg5vQ/OF/Q6+EFaY6Xlj7hdRaHhBPxXcfev4YKu99tUjDzLqVJImUIn
 wBiAqiZav7cA==
IronPort-SDR: Ol31ksGljC2T45LbXWx0HqwUAuzGNF73ka9vg2eGVT/+kdJYbhPYisQEfAPM3Z/LC37h/qQQYf
 kHmxGq2PZMJA==
From:   "Brown, Aaron F" <aaron.f.brown@intel.com>
To:     Vaibhav Gupta <vaibhavgupta40@gmail.com>,
        Vaibhav Gupta <vaibhav.varodek@gmail.com>,
        Bjorn Helgaas <helgaas@kernel.org>,
        "Bjorn Helgaas" <bhelgaas@google.com>,
        "bjorn@helgaas.com" <bjorn@helgaas.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "rjw@rjwysocki.net" <rjw@rjwysocki.net>
CC:     "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kernel-mentees@lists.linuxfoundation.org" 
        <linux-kernel-mentees@lists.linuxfoundation.org>,
        "skhan@linuxfoundation.org" <skhan@linuxfoundation.org>
Subject: RE: [PATCH v2] e1000: use generic power management
Thread-Topic: [PATCH v2] e1000: use generic power management
Thread-Index: AQHWMpACfuNJXM4xZEOoI3KQroDhiajEC3yA
Date:   Mon, 1 Jun 2020 17:15:54 +0000
Message-ID: <DM6PR11MB2890EDBB6B1BE7705DF2AB3CBC8A0@DM6PR11MB2890.namprd11.prod.outlook.com>
References: <20200525122710.25064-1-vaibhavgupta40@gmail.com>
In-Reply-To: <20200525122710.25064-1-vaibhavgupta40@gmail.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.2.0.6
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e473eea9-2cd4-44e8-3ba3-08d8064f7170
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2020 17:15:54.7469
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /hsdyx7jfr0DW2g6pN7/DWAp0CGnJK+n45y3jrIsaX8cTaHqbW8gckAFQuSmXy1KlhX0zHv8YuqAnfG10c8/oQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2665
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
> Sent: Monday, May 25, 2020 5:27 AM
> To: Vaibhav Gupta <vaibhav.varodek@gmail.com>; Bjorn Helgaas
> <helgaas@kernel.org>; Bjorn Helgaas <bhelgaas@google.com>;
> bjorn@helgaas.com; Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; Davi=
d S.
> Miller <davem@davemloft.net>; rjw@rjwysocki.net
> Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>; Brandeburg, Jesse
> <jesse.brandeburg@intel.com>; intel-wired-lan@lists.osuosl.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; linux-kernel-
> mentees@lists.linuxfoundation.org; skhan@linuxfoundation.org
> Subject: [PATCH v2] e1000: use generic power management
>=20
> compile-tested only
>=20
> With legacy PM hooks, it was the responsibility of a driver to manage PCI
> states and also the device's power state. The generic approach is to let =
PCI
> core handle the work.
>=20
> e1000_suspend() calls __e1000_shutdown() to perform intermediate tasks.
> __e1000_shutdown() modifies the value of "wake" (device should be wakeup
> enabled or not), responsible for controlling the flow of legacy PM.
>=20
> Since, PCI core has no idea about the value of "wake", new code for gener=
ic
> PM may produce unexpected results. Thus, use "device_set_wakeup_enable()"
> to wakeup-enable the device accordingly.
>=20
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
> ---
>  drivers/net/ethernet/intel/e1000/e1000_main.c | 49 +++++--------------
>  1 file changed, 13 insertions(+), 36 deletions(-)

I don't have many old PCI systems that handle power management properly bef=
ore adding this patch.  However, the few ones that do continue to do so wit=
h the older e1000 parts I still have around.  So a small sample, but at lea=
st confirmed on _some_ real hardware
Tested-by: Aaron Brown <aaron.f.brown@intel.com>