Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp644450ybg; Mon, 1 Jun 2020 10:33:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxd50/OESbD4p8//5jgS4Kgp1Cpiohb+FsSpOdix+TgZI00Lu+6xayIlzJxh9OG5sf8zgww X-Received: by 2002:a50:9a86:: with SMTP id p6mr22847002edb.153.1591032828104; Mon, 01 Jun 2020 10:33:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591032828; cv=none; d=google.com; s=arc-20160816; b=pqp9iUl88p2Ak03A646dB9/kju3SglPVi9ubWFSGRXys09fJQ3my7LJqtpugZiOnA6 yoENaoetO5XR2CoJqBsD9YOSIj1AwswJ5PTereTJBGyoeTSRejMhCvdr6jg/CQ5kNYCq vCqxw1b9grMmxy/BhPY+sDNjRI50ZNnTrqSeonbPNEP2IBKfFSLCFhiidjU8gVhwTBQR tC3+iNY5SwqahCVLwf/nCGko0cSPl7HfyHCzAGm2c2JAq7opkPUECF1tzis+mImr0moh oNZ3TpI/7460mPdv6pkc4ZUHqdRtsDqh35ipSdPDQ6ii/5JvzWWSPfmpYEzaO8NV4dy3 CLTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=F1wS/I1jFDXitIHyfc40ELUiFnz80IPkRSjdY76IYpc=; b=OKr8rvgFPNijhl0BK3sW6uom1agbxN7hw9K5S6lMhDYYy8WEd7AtTMvzZtoUCmv8qv yP+sAv9HacjQMXdsT6+OhsWaz4gbG/gS7dHCyH/klheZ/t80bvYjKRnVZwUVw4rQnrG7 D/z5dTsZMdWpA7Q4Utz4DYYjqaYKT/qQkx1tPmQ9gb6TItEOzcf+r8o0qK9nf26WPdSg 1Zb16BJcNqmlWTKMV9nuuRmcxwjBCN6iC8Q3alslaas3AKJDThHB4eBO4++Om5CTit++ c/sj4PcfIrCn0yfUVydZ1QKy4ChWBA5TpCCciX+Li50ZCBQWv0YqUrp4xICmURedviiV F7hw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rere.qmqm.pl header.s=1 header.b=oO3KEZHm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dc20si33635edb.75.2020.06.01.10.33.24; Mon, 01 Jun 2020 10:33:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@rere.qmqm.pl header.s=1 header.b=oO3KEZHm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726825AbgFARbb (ORCPT + 99 others); Mon, 1 Jun 2020 13:31:31 -0400 Received: from rere.qmqm.pl ([91.227.64.183]:42220 "EHLO rere.qmqm.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbgFARbb (ORCPT ); Mon, 1 Jun 2020 13:31:31 -0400 Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 49bMfS2W0LzLn; Mon, 1 Jun 2020 19:31:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1591032689; bh=OcbJRSI9gSF9z5NgduN2oVxJ6vT/DUHo/GDJNy7Y0Is=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oO3KEZHmFcixsHiF3qnNmW6/EaRrzo5ZWLa8usHOmKZLeqcBlzOwyoIXVFZ5y2Bzy tYH2SgKLRYiMAXaI/xPqQBRZbuetTrK8vnZPUl6MkAwaFocrSHsyqpDoRXVk8L5dU6 +L26ikeDTAIUDCRYAkfRPurU8uZZaA9GQk/26W0lNFaSPugQp9KJ1XW14ZEd+XO82Z +21ysbjhAD3kzwfDgnR3vEkubG4VA76j0epEm3xkR/NRKIgRLDjee+Nv/J0E4BqqBS RuMZNzijow8bL4OoAChoVn+m8AiEoJ9ltbgttpX/lfcIUxMiGZnsAqitqjYTUAzdgK YIJSeGX1Pe/qA== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.2 at mail Date: Mon, 1 Jun 2020 19:31:27 +0200 From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= To: Markus Elfring Cc: linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Belloni , Arnd Bergmann , Greg Kroah-Hartman , Ludovic Desroches , Nicolas Ferre Subject: Re: [PATCH] misc: atmel-ssc: lock with mutex instead of spinlock Message-ID: <20200601173126.GA31822@qmqm.qmqm.pl> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 01, 2020 at 11:18:48AM +0200, Markus Elfring wrote: > > Uninterruptible context is not needed in the driver and causes lockdep > > warning because of mutex taken in of_alias_get_id(). > > Was a spin lock taken? > > Convert the lock to mutex to avoid the issue. > Would you like to add the tag “Fixes” to the commit message? I guess we can add: Fixes: 099343c64e16 ("ARM: at91: atmel-ssc: add device tree support") Best Regards Michał Mirosław