Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp669784ybg; Mon, 1 Jun 2020 11:14:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuu78H+TYslwqDVREC1eI0sazeuQYSTHP5YA6SSDf0ludv+uV2ZIzwqwKkaR+Q1cRTKNcy X-Received: by 2002:a17:906:57d3:: with SMTP id u19mr20921316ejr.401.1591035274938; Mon, 01 Jun 2020 11:14:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591035274; cv=none; d=google.com; s=arc-20160816; b=qCvOhr6yTeOBnj8uyoyRMygryzjR+FdN9eoKQdW6S6gqkoF6RLKyNcHp4s2oodWwiT T6h/jqxSDyoXsVTNiosrqU74qDEcQx7KjQI6qIyhFLFcKbwd8EWSfX0FV4h7PocpcBQ4 k/1ofIiAPxVvQ2bsNIBfkbTb2IUA2jIgaJOQYhfBFJO6JO2QccCCtIiFT4gGNlVFgdMS sPmcjN4W8wupT2L2Xj8KVoVMpsOeU8KMQgrP1dQK4FvJ8kvQflUzJIENBg+prZQEecOe FJw+OXgbvSvODwVD3mVtDx62E0qUJq/l9ITzzfGpmNWviuNgEZEqhforRNGqSJmxpXxC Ecig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rGaauDm8Kk3vv9tVo30wN6Jfc+NIXNud4lhQzcm2yFA=; b=ZRGkdEm6ohqD170Br+XcRl8mcIyOX/g4kJ6VAKjQW70I2rH8KKUNie0nUfn7sN+/Tr Bjdcwm8J0PxMQazou7uH4OAdDiCE01pZebv95Y48XwZv1yUZmSb+d5fXIR1qyKs++ekY RuZez8f0U4/LLceoCnTvk4qZ1Xa8hUyUKWSDO37z9h6vtfGEW0bl8N+SNNyH8echKv4o GZLV+a5TDQwaC1QjSam86C99rsmtrgJoWPSi2lnDpJmsKqxTUCWQm+cUtY+TnmKSB+fW KZ6JU1kHQpenz3LvhCbbKCJ3rM7cG7ofbdBl94DzoVZFH2N7O2XPHnZeWhccrsEX42vM N0BA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=h2qkOodM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x71si73305ede.271.2020.06.01.11.14.11; Mon, 01 Jun 2020 11:14:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=h2qkOodM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730854AbgFASJP (ORCPT + 99 others); Mon, 1 Jun 2020 14:09:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:55590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730344AbgFASJN (ORCPT ); Mon, 1 Jun 2020 14:09:13 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A5A5A21531; Mon, 1 Jun 2020 18:09:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591034953; bh=74mmgenOw4MmKp1UIPKTZunpiAwuag71URypgKevze8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h2qkOodMwz+twJ4CAHA3qN+hGaI7tsFgA539Mk/rqE5HYFcpqvhMCbsvUbowXJBy4 3ZB/t9QBPan+wbmOWUdWvc4xqteuQnoh8Ga0gs19V7GlNgxXgm12KTP3hdOT8UywAT uoujZISDvEEpp0Od3Ji8EPsgu1BJOODi+OXREd9s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Qiushi Wu , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.4 086/142] RDMA/pvrdma: Fix missing pci disable in pvrdma_pci_probe() Date: Mon, 1 Jun 2020 19:54:04 +0200 Message-Id: <20200601174046.833868195@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200601174037.904070960@linuxfoundation.org> References: <20200601174037.904070960@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qiushi Wu [ Upstream commit db857e6ae548f0f4f4a0f63fffeeedf3cca21f9d ] In function pvrdma_pci_probe(), pdev was not disabled in one error path. Thus replace the jump target “err_free_device” by "err_disable_pdev". Fixes: 29c8d9eba550 ("IB: Add vmw_pvrdma driver") Link: https://lore.kernel.org/r/20200523030457.16160-1-wu000273@umn.edu Signed-off-by: Qiushi Wu Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c index e580ae9cc55a..780fd2dfc07e 100644 --- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c @@ -829,7 +829,7 @@ static int pvrdma_pci_probe(struct pci_dev *pdev, !(pci_resource_flags(pdev, 1) & IORESOURCE_MEM)) { dev_err(&pdev->dev, "PCI BAR region not MMIO\n"); ret = -ENOMEM; - goto err_free_device; + goto err_disable_pdev; } ret = pci_request_regions(pdev, DRV_NAME); -- 2.25.1