Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp687692ybg; Mon, 1 Jun 2020 11:43:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfQMgazVSI0sK5YWwQ/ggrN3/DUGiJBe6HL3EiAi4z7ULc7eujmJV4igzHkNjBu4dcJsZO X-Received: by 2002:a17:906:9a02:: with SMTP id ai2mr19778387ejc.97.1591036982498; Mon, 01 Jun 2020 11:43:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591036982; cv=none; d=google.com; s=arc-20160816; b=M6ZHYfsn7U0kYeNxm6Sw8Rjkmb5LHaqssAgI63KOFpPJljScn1jSgCqQkZBLQJmn3O mwAx/N8OEQlCxdVH9pFJV+ybnpmgg4nq+YLTJVi7XUPWlnyy1pAPvrggApp87WHCbkR0 x7mBZFBnnYjVlNi2YLfvQA6wGf8W79Kk7xtYgudbgQi2z5YFHbGNY3hutTi6vgYyAwu5 McSZ3K61ZiUUd9+udp7DlTBek8aeY3HBCB88I2pSESFSVHdiS5wmB0P0VgtBvHBQo+Hs BE1zJyJpEt6WcVUScFe0ThQvoXtPnus7s0PwTGym3m82gFekBzWIAelGJFETbZwa2JW6 KQdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=vQsHm/Fb+3S9GG4hi4C54VWzmvQfSDfHYATb203csRU=; b=oXhWNtrkftimd6/+IVt9x/XeiEp6TQ9ilZjbzmCihjm7zbZPxp6LiqQZDqw4Snx5Ms uB7K7KFjHrathBRnSNUF6bgw6W54HhPQKjGu07aGcQtwz1o9YepO6JWUCsZbMrDwfGdS uCkDqbzGTk2sjzS5XwP8j06h0Xlja4Q9ApDyt1oLOesLVRqFu9EPZXRvVMaUIIKhb472 hN+cFgY7XpqeKyaCcEj1dCTqbHW3NoJ3TRmdjHdUxuTMeGQTljbt7iE12hm9HuaWpUgI YE9MKwm8sH1RQCodF3B5zCJDxD4ZvwDjYe8XYe7r9lc1w9s0rWTql+8cOZVz40RImHIL m18w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Vs7Yv/hX"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c26si131128edj.238.2020.06.01.11.42.39; Mon, 01 Jun 2020 11:43:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Vs7Yv/hX"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727875AbgFAShv (ORCPT + 99 others); Mon, 1 Jun 2020 14:37:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730821AbgFAShn (ORCPT ); Mon, 1 Jun 2020 14:37:43 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0D1FC008631 for ; Mon, 1 Jun 2020 11:26:33 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id o6so3887175pgh.2 for ; Mon, 01 Jun 2020 11:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vQsHm/Fb+3S9GG4hi4C54VWzmvQfSDfHYATb203csRU=; b=Vs7Yv/hX/ULE3o4BYT8jfnU2UW8Uy0ez3j2yQ8d6Stdt/38QVd16hvblONaRxgdbUK HfbmgcTRdgDtj0uTkJE/cNinFuhzfppdk2J2grs4bm465GiL6n76ZgakZKzTV8r6dxUM X7r7To/s/otOe8sf2hzW/wE30chaO+juxjXCM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vQsHm/Fb+3S9GG4hi4C54VWzmvQfSDfHYATb203csRU=; b=oMv0ziCdwJbVmis/OPs1izQb2eI+D2Tb4OPM7oFPMxNtUxYXPIEA5sYXDjbGNmOh9O srndwuGcOOlnZGiiSK9nl6s8/qocE1T2rcujhIuHfdGGwHnimAxFrAQdiZNo0MSJSapi 4Q5j+MJN9hbaSphnY4J5B37fgNVQUr1ZZD6quji5dlku/qcCF2Ja9dlxnb4/A4YlV/PK Sl/WWxcAuXBro8Jhy4d3nicVHQf3mhCdjuP2LU33r9qo7pnZrv886u3Vgbrxt/S8jUkg lmS25XVmubyTCYciWMkdmoQaIQ8XJ5GNuqsJmGv0ZnuMSnFomJZIPvT2Ssic/iT0XKl+ uwrQ== X-Gm-Message-State: AOAM5334kD1ZNA7OHt8spEtMcdNXXKDhayJ/a2LZD7me4a+TjuG5T1oU DMzqpwf9UafGB8HyXP3d23XDXw== X-Received: by 2002:a63:7052:: with SMTP id a18mr20225520pgn.39.1591035993241; Mon, 01 Jun 2020 11:26:33 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m3sm151966pjs.17.2020.06.01.11.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 11:26:32 -0700 (PDT) Date: Mon, 1 Jun 2020 11:26:31 -0700 From: Kees Cook To: Sargun Dhillon Cc: containers@lists.linux-foundation.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, christian.brauner@ubuntu.com, cyphar@cyphar.com, jannh@google.com, jeffv@google.com, palmer@google.com, rsesek@google.com, tycho@tycho.ws, Matt Denton Subject: Re: [PATCH v3] seccomp: Add find_notification helper Message-ID: <202006011126.3DB757FBF5@keescook> References: <20200601112532.150158-1-sargun@sargun.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200601112532.150158-1-sargun@sargun.me> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 01, 2020 at 04:25:32AM -0700, Sargun Dhillon wrote: > This adds a helper which can iterate through a seccomp_filter to > find a notification matching an ID. It removes several replicated > chunks of code. > > Signed-off-by: Sargun Dhillon > Acked-by: Christian Brauner > Reviewed-by: Tycho Andersen > Cc: Matt Denton > Cc: Kees Cook , > Cc: Jann Horn , > Cc: Robert Sesek , > Cc: Chris Palmer > Cc: Christian Brauner > Cc: Tycho Andersen Thanks! Applied to for-next/seccomp. -- Kees Cook