Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200527224659.206129-1-eranian@google.com> <20200527224659.206129-2-eranian@google.com>
 <20200601123850.GA213137@latitude>
In-Reply-To: <20200601123850.GA213137@latitude>
From:   Stephane Eranian <eranian@google.com>
Date:   Mon, 1 Jun 2020 12:46:05 -0700
Message-ID: <CABPqkBSKF_4BpXxT=LDb786cW5euuOk7oUbnem5=P6BpMtk0ZA@mail.gmail.com>
Subject: Re: [PATCH v2 1/5] perf/x86/rapl: move RAPL support to common x86 code
To:     Johannes Hirte <johannes.hirte@datenkhaos.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, mingo@elte.hu,
        Ian Rogers <irogers@google.com>,
        "Phillips, Kim" <kim.phillips@amd.com>,
        Jiri Olsa <jolsa@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jun 1, 2020 at 5:39 AM Johannes Hirte
<johannes.hirte@datenkhaos.de> wrote:
>
> On 2020 Mai 27, Stephane Eranian wrote:
>
> ...
> > diff --git a/arch/x86/events/Makefile b/arch/x86/events/Makefile
> > index 6f1d1fde8b2de..12c42eba77ec3 100644
> > --- a/arch/x86/events/Makefile
> > +++ b/arch/x86/events/Makefile
> > @@ -1,5 +1,6 @@
> >  # SPDX-License-Identifier: GPL-2.0-only
> >  obj-y                                        += core.o probe.o
> > +obj-$(PERF_EVENTS_INTEL_RAPL)                += rapl.o
> >  obj-y                                        += amd/
> >  obj-$(CONFIG_X86_LOCAL_APIC)            += msr.o
> >  obj-$(CONFIG_CPU_SUP_INTEL)          += intel/
>
> With this change, rapl won't be build. Must be:
>
> obj-$(CONFIG_PERF_EVENTS_INTEL_RAPL)                += rapl.o
>
Correct. I posted a patch last week to fix that.
Thanks.

> --
> Regards,
>   Johannes Hirte
>