Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200530221127.459704-1-brgerst@gmail.com> <20200530221127.459704-11-brgerst@gmail.com>
In-Reply-To: <20200530221127.459704-11-brgerst@gmail.com>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Mon, 1 Jun 2020 13:26:50 -0700
Message-ID: <CAKwvOd=-qy6whi4UCzmsyY-A_cxCiO+ndydrcHjjAX7=qFKniQ@mail.gmail.com>
Subject: Re: [PATCH v2 10/10] x86/percpu: Remove unused PER_CPU() macro
To:     Brian Gerst <brgerst@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, May 30, 2020 at 3:11 PM Brian Gerst <brgerst@gmail.com> wrote:
>
> Also remove now unused __percpu_mov_op.
>
> Signed-off-by: Brian Gerst <brgerst@gmail.com>

This cleanup looks unrelated to the series, and can be sent separately
if needed.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

> ---
>  arch/x86/include/asm/percpu.h | 18 ------------------
>  1 file changed, 18 deletions(-)
>
> diff --git a/arch/x86/include/asm/percpu.h b/arch/x86/include/asm/percpu.h
> index cf2b9c2a241e..a3c33b79fb86 100644
> --- a/arch/x86/include/asm/percpu.h
> +++ b/arch/x86/include/asm/percpu.h
> @@ -4,33 +4,15 @@
>
>  #ifdef CONFIG_X86_64
>  #define __percpu_seg           gs
> -#define __percpu_mov_op                movq
>  #else
>  #define __percpu_seg           fs
> -#define __percpu_mov_op                movl
>  #endif
>
>  #ifdef __ASSEMBLY__
>
> -/*
> - * PER_CPU finds an address of a per-cpu variable.
> - *
> - * Args:
> - *    var - variable name
> - *    reg - 32bit register
> - *
> - * The resulting address is stored in the "reg" argument.
> - *
> - * Example:
> - *    PER_CPU(cpu_gdt_descr, %ebx)
> - */
>  #ifdef CONFIG_SMP
> -#define PER_CPU(var, reg)                                              \
> -       __percpu_mov_op %__percpu_seg:this_cpu_off, reg;                \
> -       lea var(reg), reg
>  #define PER_CPU_VAR(var)       %__percpu_seg:var
>  #else /* ! SMP */
> -#define PER_CPU(var, reg)      __percpu_mov_op $var, reg
>  #define PER_CPU_VAR(var)       var
>  #endif /* SMP */
>
> --
> 2.25.4
>


-- 
Thanks,
~Nick Desaulniers