Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp830355ybg; Mon, 1 Jun 2020 15:55:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIntUcKS8tzxO4+PGFkB0tNIozc8F3V8aILEXA3UAiP3m3OMTDboovwRkJKRlo++nlE+2C X-Received: by 2002:a50:bb29:: with SMTP id y38mr23668002ede.358.1591052147646; Mon, 01 Jun 2020 15:55:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591052147; cv=none; d=google.com; s=arc-20160816; b=O8oHPf6nGsbP/COb0dvy09pGgeBoVkzUR48T6cKXh36v38+60SSKhDrU3V/IRmhO6B 5p0cu+tTVyh8fuD+G3heFIGNDZHT95nQh02VpQcvynvCWIjfod0IdAwC8zjuzJjMULcn ThZ7lEFVl30vMKn2pfQlddeOE426GzqVFOnZb0TtjFo/M/aJKyHgHabh2tn6rSnd+prH tiQ4JHgU+Q2zREnqHEXpxZ2b4wr6ZyBtomxZlWSTXhwCTJ3knFMDAWRRRFSefCy1tJzd leZsJDKfk259vHDgdxlowGuhkvFuI9RcBtu8aNxfJg55BjOOxGvtFIvpF8M2ujvCGZsE ic6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=JwPoGeUaSp/ywSz/kz/3AdT7sVKxsUpsbVTw5gZ4LOM=; b=dFR6rKbH+ge+WSt1bjRurjt0ClLprCTjc4dXMIuZNyN5Ii02Hc5o2VhDeVijMOZMXn klbotLsNqE0mfFFTxDRXLB/cY2XxTDLJ29dp7VidrewAwTdbTI2Bsq5wQeky9fzz2nG1 vm2OFDusx1pbwuMfC/vJoJxRqmrmvVQObvIBKH1wkVSaj1v+uHMhMHpefx8NtN3HLFRV Cl5MvvX/vLZpr7bvyzNGVxwrEvbBX7YfhrMf+ETdgc5j/klIPdO7JQbve9M/be/V7jUF 4wqx1iWTZ4y0T2jwYvRde98BlIv/YEHX1o8teMC1yQGJczpFcyFcIdGN8779EnOpTNC9 hLSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u20si528003eda.569.2020.06.01.15.55.12; Mon, 01 Jun 2020 15:55:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728937AbgFAWwk (ORCPT + 99 others); Mon, 1 Jun 2020 18:52:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725766AbgFAWwi (ORCPT ); Mon, 1 Jun 2020 18:52:38 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38674C05BD43; Mon, 1 Jun 2020 15:52:38 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6D3AB11F5F667; Mon, 1 Jun 2020 15:52:37 -0700 (PDT) Date: Mon, 01 Jun 2020 15:52:36 -0700 (PDT) Message-Id: <20200601.155236.1578368535921098753.davem@davemloft.net> To: jbi.octave@gmail.com Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, paulmck@kernel.org, mingo@redhat.com, boqun.feng@gmail.com, linux-net-drivers@solarflare.com, ecree@solarflare.com, mhabets@solarflare.com, netdev@vger.kernel.org Subject: Re: [PATCH 5/5] sfc: add missing annotation for efx_ef10_try_update_nic_stats_vf() From: David Miller In-Reply-To: <20200601184552.23128-6-jbi.octave@gmail.com> References: <20200601184552.23128-1-jbi.octave@gmail.com> <20200601184552.23128-6-jbi.octave@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Jun 2020 15:52:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jules Irenge Date: Mon, 1 Jun 2020 19:45:52 +0100 > Sparse reports a warning at efx_ef10_try_update_nic_stats_vf() > warning: context imbalance in efx_ef10_try_update_nic_stats_vf() > - unexpected unlock > The root cause is the missing annotation at > efx_ef10_try_update_nic_stats_vf() > Add the missing _must_hold(&efx->stats_lock) annotation > > Signed-off-by: Jules Irenge Applied.