Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Jun 2020 09:01:57 +0900
From:   Masami Hiramatsu <mhiramat@kernel.org>
To:     "Zanussi, Tom" <tom.zanussi@linux.intel.com>
Cc:     Shuah Khan <skhan@linuxfoundation.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH 4/7] selftests/ftrace: Convert required interface checks
 into requires list
Message-Id: <20200602090157.45cf58947267cec561da67ea@kernel.org>
In-Reply-To: <e23a0d5c-5e7e-13db-e9c1-2a093d3327be@linux.intel.com>
References: <159102252279.31199.12855129586058455119.stgit@devnote2>
        <159102256204.31199.842249429317038334.stgit@devnote2>
        <e23a0d5c-5e7e-13db-e9c1-2a093d3327be@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 1 Jun 2020 14:54:12 -0500
"Zanussi, Tom" <tom.zanussi@linux.intel.com> wrote:

> Hi Masami,
> 
> On 6/1/2020 9:42 AM, Masami Hiramatsu wrote:
> > Convert the required tracefs interface checking code with
> > requires: list.
> > 
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org
> [ SNIP ]
> 
> > diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc
> > index c80007aa9f86..59f876c80d45 100644
> > --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc
> > @@ -1,17 +1,13 @@
> >   #!/bin/sh
> >   # SPDX-License-Identifier: GPL-2.0
> >   # description: event trigger - test inter-event histogram trigger onchange action
> > +# requires: synthetic_events
> 
> I think this should be 'set_event'
> 

Thank you for point it out. I found another missed requirement.
I'll fix it.

Thank you,

> Thanks,
> 
> Tom


-- 
Masami Hiramatsu <mhiramat@kernel.org>