Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp902361ybg; Mon, 1 Jun 2020 18:05:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvtYqi8OqD+cQvfXWMUmHDp+cPuOQKg4kl3RauQbdzqIUAcQ/AxI7K30FlEPgXY6Hm0BXp X-Received: by 2002:aa7:cb94:: with SMTP id r20mr24669762edt.215.1591059908258; Mon, 01 Jun 2020 18:05:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591059908; cv=none; d=google.com; s=arc-20160816; b=0Fzb3icQ5oi9j9p/OzE4NGC+pjobMn7f2sdFjOdJjJm6ysi5KTs1Lr29Z0g6PD4tCn fgAhz2VdXgRd1xvhpt7xpo7iH/w8eneah+8Co6bEIEYGD8SuKSKxWCPmAtx/LfYsWvpk t2JgJ/d/+GPUjbPaVMfiKUHJikrCyjUt5dHV5FMDcxGybx8A1dx3rBbr+kPm1y3TTZjO oYSJeVWdgbD5CGUhStrnDGzJdmkoIW9d9w6+DnlTfybYVUTj9FBJ3cIiwJbGqIdrjk7y xcV5fkxhSXG9u4E4Bq+sOmnoR2Nhgs/chUdvSeQ18x+xVEIAUn5AKE/YeoVzNijrebc5 jQ9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Vvc1X7Y4IRnfyv3TChJNmUPz9lO9aCJG5m0mM87hVaY=; b=rO0PItOWRTOhxRdyBU8n36sjlzEPw9U6+YnOmfUDOwSTvsccOsi4NlDFcR5MQI1xbW rrVWKitE5sg+Ug1M/rb/Yp2BX5To85QUqDKNoSH/TVgeP85aO0f8+UZ/ZfdoBM1O19co WsSazgSy6V8aHMgIlF9R21d/SeYMH76qHuRFQVRoIGJteYBrXsTmFfFeZMtXBpuzyF1N AIgPZjrPlLqz2BvFL+8Tc37Hw2Y1QpD5mBaouiI4CyZhsptAiNvYqSUhydSoxxW82jpo Z8njhxy/Exx6Gc9MsJqQBwj0PTp8LwSoDVmsZQ4Ub2sAsKDcSWYe9kQPGAu07tPT3crF 6bQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2W0NCyuj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l11si664138edi.230.2020.06.01.18.04.44; Mon, 01 Jun 2020 18:05:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2W0NCyuj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725872AbgFBBCw (ORCPT + 99 others); Mon, 1 Jun 2020 21:02:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:38468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725793AbgFBBCw (ORCPT ); Mon, 1 Jun 2020 21:02:52 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19E7320885; Tue, 2 Jun 2020 01:02:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591059772; bh=yT6uPPaIXrr08PDkHZ/zzYHOerexZsr8I2IdZgIUlkg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2W0NCyujKd31R1Y2nzRRE+m4mATws/pY7VyK83RvEzEY4v95k621rIYse7pH0MIBl oHr98DBG4TWgOlsBTl92vSMk2rh6UWIt619ELig8Q1uL52rxAEkb35NyzhUv43fffV ivnvgoHXAFURrhHhzZv8LXn7CAtxweg5H6zTBzn4= Date: Mon, 1 Jun 2020 18:02:51 -0700 From: Andrew Morton To: Wei Yang Cc: Andy Shevchenko , Andy Shevchenko , Christian Brauner , Linux Kernel Mailing List Subject: Re: [PATCH] lib: make a test module with get_count_order/long Message-Id: <20200601180251.3f905a6e6eea1debc8771479@linux-foundation.org> In-Reply-To: <20200531124709.c7o7pw7o2rfv4klc@master> References: <20200530004328.30530-1-richard.weiyang@gmail.com> <20200530102531.GA1634618@smile.fi.intel.com> <20200530211940.yninqlngnzfvsvki@master> <20200531124709.c7o7pw7o2rfv4klc@master> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 31 May 2020 12:47:09 +0000 Wei Yang wrote: > On Sun, May 31, 2020 at 12:56:29AM +0300, Andy Shevchenko wrote: > >On Sun, May 31, 2020 at 12:23 AM Wei Yang wrote: > >> On Sat, May 30, 2020 at 01:25:31PM +0300, Andy Shevchenko wrote: > >> >On Sat, May 30, 2020 at 12:43:28AM +0000, Wei Yang wrote: > >> >> A test module to make sure get_count_order/long returns the correct result. > >> > > >> >> lib/Kconfig.debug | 13 ++++++ > >> >> lib/Makefile | 2 + > >> >> lib/test_getorder.c | 64 ++++++++++++++++++++++++++++++ > >> > > >> >I didn't get why it's not a part of test_bitops? > >> > > >> > >> I see the document of test_bitops says it does exercise on clear_bit and > >> set_bit. So not sure it is proper to put them together. > > > >It's not a problem to amend a documentation as well :-) > > > > Sure. I am fine with this. > > Andrew, do you expect me to merge it into test_bitops.c? > Yes please.