Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without
 split
To:     Daniel Jordan <daniel.m.jordan@oracle.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>
CC:     <linux-mm@kvack.org>, <hughd@google.com>,
        Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
        Zi Yan <ziy@nvidia.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        <linux-kernel@vger.kernel.org>
References: <1590118444-21601-1-git-send-email-anshuman.khandual@arm.com>
 <20200601165736.qw5kwwknxltk7bv6@ca-dmjordan1.us.oracle.com>
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <0a936ec7-f44f-1d72-915f-f5758d25fd72@nvidia.com>
Date:   Mon, 1 Jun 2020 20:20:05 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.1
MIME-Version: 1.0
In-Reply-To: <20200601165736.qw5kwwknxltk7bv6@ca-dmjordan1.us.oracle.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020-06-01 09:57, Daniel Jordan wrote:
> Hi Anshuman,
> 
> On Fri, May 22, 2020 at 09:04:04AM +0530, Anshuman Khandual wrote:
>> This adds the following two new VM events which will help in validating PMD
>> based THP migration without split. Statistics reported through these events
>> will help in performance debugging.
>>
>> 1. THP_PMD_MIGRATION_SUCCESS
>> 2. THP_PMD_MIGRATION_FAILURE
> 
> The names suggest a binary event similar to the existing
> pgmigrate_success/fail, but FAILURE only tracks one kind of migration error,
> and then only when the thp is successfully split, so shouldn't it be called
> SPLIT instead?
> 

So the full description of the situation, which we're trying to compress into
a shorter name, is "THP pmd migration failure, due to successfully splitting
the THP". From that, the beginning part is the real point here, while the last
part is less important. In other words, the users of these events are people
who are trying to quantify THP migrations, and these events are particularly
relevant for that. The "THP migration failed" is more important here than
the reason that it failed. Or so I believe so far.

So I still think that the names are really quite good, but your point is
also important: maybe this patch should also be tracking other causes
of THP PMD migration failure, in order to get a truer accounting of the
situation.

thanks,
-- 
John Hubbard
NVIDIA