Message-ID: <441ED776.2000108@cfl.rr.com>
Date: Mon, 20 Mar 2006 11:25:26 -0500
From: Phillip Susi <psusi@cfl.rr.com>
User-Agent: Thunderbird 1.5 (Windows/20051201)
MIME-Version: 1.0
To: Andrew Morton <akpm@osdl.org>
CC: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] udf: fix uid/gid options and add uid/gid=ignore and forget
 options
References: <441E142F.2030305@cfl.rr.com> <20060319200424.5a3647aa.akpm@osdl.org>
In-Reply-To: <20060319200424.5a3647aa.akpm@osdl.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1081
Lines: 23

Andrew Morton wrote:
> I didn't see that update, and I don't miss much.
> 

See http://lkml.org/lkml/2006/3/5/171

> Please provide a description of this change.  What problem is it fixing? 
> How does it fix it?  What are the consequences of not making this change?

In the initial patch I made a typo.  As Pekka Enberg pointed out, with 
the if still following the else, you can still get a null uid written to 
the disk if you specify a default uid= without uid=forget.  In other 
words, if the desktop user is uid=1000 and the mount option uid=1000 is 
given ( which is done on ubuntu automatically and probably other 
distributions that use hal ), then if any other user besides uid 1000 
owns a file then a 0 will be written to the media as the owning uid 
instead.  This is exactly what the original patch was trying to prevent.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/