Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
To:     Dejin Zheng <zhengdejin5@gmail.com>,
        "kishon@ti.com" <kishon@ti.com>,
        "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
        "robh@kernel.org" <robh@kernel.org>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "shawn.guo@linaro.org" <shawn.guo@linaro.org>,
        "agross@kernel.org" <agross@kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1] PCI: dwc: convert to
 devm_platform_ioremap_resource_byname()
Thread-Topic: [PATCH v1] PCI: dwc: convert to
 devm_platform_ioremap_resource_byname()
Thread-Index: AQHWNQtFPRKU/5PQpUKyvyNa3OTanajE78mg
Date:   Tue, 2 Jun 2020 07:11:00 +0000
Message-ID: <DM5PR12MB1276BA103B8EB0115D3738C0DA8B0@DM5PR12MB1276.namprd12.prod.outlook.com>
References: <20200528161510.31935-1-zhengdejin5@gmail.com>
In-Reply-To: <20200528161510.31935-1-zhengdejin5@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 51d859c7-d03d-4025-7e30-08d806c41aa2
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2020 07:11:00.1379
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4iArtyDeEBRdcpt/0YtMzcDZaQdubEUaqJ+UhRTgZ2NtCFZgjGNCpyLs/lOJMuzY8V6kj8sDhwK5prTfk2CZBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2534
X-OriginatorOrg: synopsys.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 28, 2020 at 17:15:10, Dejin Zheng <zhengdejin5@gmail.com>=20
wrote:

> Use devm_platform_ioremap_resource_byname() to simplify codes.
> it contains platform_get_resource_byname() and devm_ioremap_resource().
>=20
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
> ---
>  drivers/pci/controller/dwc/pci-dra7xx.c         | 11 ++++-------
>  drivers/pci/controller/dwc/pci-keystone.c       |  7 +++----
>  drivers/pci/controller/dwc/pcie-artpec6.c       | 12 ++++--------
>  .../pci/controller/dwc/pcie-designware-plat.c   |  3 +--
>  drivers/pci/controller/dwc/pcie-histb.c         |  7 ++-----
>  drivers/pci/controller/dwc/pcie-intel-gw.c      |  7 ++-----
>  drivers/pci/controller/dwc/pcie-kirin.c         | 17 ++++++-----------
>  drivers/pci/controller/dwc/pcie-qcom.c          |  6 ++----
>  drivers/pci/controller/dwc/pcie-uniphier.c      |  3 +--
>  9 files changed, 25 insertions(+), 48 deletions(-)
>=20
> diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/contro=
ller/dwc/pci-dra7xx.c
> index 6184ebc9392d..e5d0c7ac09b9 100644
> --- a/drivers/pci/controller/dwc/pci-dra7xx.c
> +++ b/drivers/pci/controller/dwc/pci-dra7xx.c
> @@ -593,13 +593,12 @@ static int __init dra7xx_add_pcie_ep(struct dra7xx_=
pcie *dra7xx,
>  	ep =3D &pci->ep;
>  	ep->ops =3D &pcie_ep_ops;
> =20
> -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "ep_dbics");
> -	pci->dbi_base =3D devm_ioremap_resource(dev, res);
> +	pci->dbi_base =3D devm_platform_ioremap_resource_byname(pdev, "ep_dbics=
");
>  	if (IS_ERR(pci->dbi_base))
>  		return PTR_ERR(pci->dbi_base);
> =20
> -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "ep_dbics2")=
;
> -	pci->dbi_base2 =3D devm_ioremap_resource(dev, res);
> +	pci->dbi_base2 =3D
> +		devm_platform_ioremap_resource_byname(pdev, "ep_dbics2");
>  	if (IS_ERR(pci->dbi_base2))
>  		return PTR_ERR(pci->dbi_base2);
> =20
> @@ -626,7 +625,6 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_=
pcie *dra7xx,
>  	struct dw_pcie *pci =3D dra7xx->pci;
>  	struct pcie_port *pp =3D &pci->pp;
>  	struct device *dev =3D pci->dev;
> -	struct resource *res;
> =20
>  	pp->irq =3D platform_get_irq(pdev, 1);
>  	if (pp->irq < 0) {
> @@ -638,8 +636,7 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_=
pcie *dra7xx,
>  	if (ret < 0)
>  		return ret;
> =20
> -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "rc_dbics");
> -	pci->dbi_base =3D devm_ioremap_resource(dev, res);
> +	pci->dbi_base =3D devm_platform_ioremap_resource_byname(pdev, "rc_dbics=
");
>  	if (IS_ERR(pci->dbi_base))
>  		return PTR_ERR(pci->dbi_base);
> =20
> diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/cont=
roller/dwc/pci-keystone.c
> index 790679fdfa48..5ffc3b40c4f6 100644
> --- a/drivers/pci/controller/dwc/pci-keystone.c
> +++ b/drivers/pci/controller/dwc/pci-keystone.c
> @@ -1228,8 +1228,8 @@ static int __init ks_pcie_probe(struct platform_dev=
ice *pdev)
>  	if (!pci)
>  		return -ENOMEM;
> =20
> -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "app");
> -	ks_pcie->va_app_base =3D devm_ioremap_resource(dev, res);
> +	ks_pcie->va_app_base =3D
> +		devm_platform_ioremap_resource_byname(pdev, "app");
>  	if (IS_ERR(ks_pcie->va_app_base))
>  		return PTR_ERR(ks_pcie->va_app_base);
> =20
> @@ -1323,8 +1323,7 @@ static int __init ks_pcie_probe(struct platform_dev=
ice *pdev)
>  	}
> =20
>  	if (pci->version >=3D 0x480A) {
> -		res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "atu");
> -		atu_base =3D devm_ioremap_resource(dev, res);
> +		atu_base =3D devm_platform_ioremap_resource_byname(pdev, "atu");
>  		if (IS_ERR(atu_base)) {
>  			ret =3D PTR_ERR(atu_base);
>  			goto err_get_sync;
> diff --git a/drivers/pci/controller/dwc/pcie-artpec6.c b/drivers/pci/cont=
roller/dwc/pcie-artpec6.c
> index 28d5a1095200..7d2cfa288b01 100644
> --- a/drivers/pci/controller/dwc/pcie-artpec6.c
> +++ b/drivers/pci/controller/dwc/pcie-artpec6.c
> @@ -455,8 +455,7 @@ static int artpec6_add_pcie_ep(struct artpec6_pcie *a=
rtpec6_pcie,
>  	ep =3D &pci->ep;
>  	ep->ops =3D &pcie_ep_ops;
> =20
> -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "dbi2");
> -	pci->dbi_base2 =3D devm_ioremap_resource(dev, res);
> +	pci->dbi_base2 =3D devm_platform_ioremap_resource_byname(pdev, "dbi2");
>  	if (IS_ERR(pci->dbi_base2))
>  		return PTR_ERR(pci->dbi_base2);
> =20
> @@ -481,8 +480,6 @@ static int artpec6_pcie_probe(struct platform_device =
*pdev)
>  	struct device *dev =3D &pdev->dev;
>  	struct dw_pcie *pci;
>  	struct artpec6_pcie *artpec6_pcie;
> -	struct resource *dbi_base;
> -	struct resource *phy_base;
>  	int ret;
>  	const struct of_device_id *match;
>  	const struct artpec_pcie_of_data *data;
> @@ -512,13 +509,12 @@ static int artpec6_pcie_probe(struct platform_devic=
e *pdev)
>  	artpec6_pcie->variant =3D variant;
>  	artpec6_pcie->mode =3D mode;
> =20
> -	dbi_base =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "dbi");
> -	pci->dbi_base =3D devm_ioremap_resource(dev, dbi_base);
> +	pci->dbi_base =3D devm_platform_ioremap_resource_byname(pdev, "dbi");
>  	if (IS_ERR(pci->dbi_base))
>  		return PTR_ERR(pci->dbi_base);
> =20
> -	phy_base =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy");
> -	artpec6_pcie->phy_base =3D devm_ioremap_resource(dev, phy_base);
> +	artpec6_pcie->phy_base =3D
> +		devm_platform_ioremap_resource_byname(pdev, "phy");
>  	if (IS_ERR(artpec6_pcie->phy_base))
>  		return PTR_ERR(artpec6_pcie->phy_base);
> =20
> diff --git a/drivers/pci/controller/dwc/pcie-designware-plat.c b/drivers/=
pci/controller/dwc/pcie-designware-plat.c
> index 73646b677aff..712456f6ce36 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-plat.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-plat.c
> @@ -153,8 +153,7 @@ static int dw_plat_add_pcie_ep(struct dw_plat_pcie *d=
w_plat_pcie,
>  	ep =3D &pci->ep;
>  	ep->ops =3D &pcie_ep_ops;
> =20
> -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "dbi2");
> -	pci->dbi_base2 =3D devm_ioremap_resource(dev, res);
> +	pci->dbi_base2 =3D devm_platform_ioremap_resource_byname(pdev, "dbi2");
>  	if (IS_ERR(pci->dbi_base2))
>  		return PTR_ERR(pci->dbi_base2);
> =20
> diff --git a/drivers/pci/controller/dwc/pcie-histb.c b/drivers/pci/contro=
ller/dwc/pcie-histb.c
> index 811b5c6d62ea..6d3524c39a9b 100644
> --- a/drivers/pci/controller/dwc/pcie-histb.c
> +++ b/drivers/pci/controller/dwc/pcie-histb.c
> @@ -304,7 +304,6 @@ static int histb_pcie_probe(struct platform_device *p=
dev)
>  	struct histb_pcie *hipcie;
>  	struct dw_pcie *pci;
>  	struct pcie_port *pp;
> -	struct resource *res;
>  	struct device_node *np =3D pdev->dev.of_node;
>  	struct device *dev =3D &pdev->dev;
>  	enum of_gpio_flags of_flags;
> @@ -324,15 +323,13 @@ static int histb_pcie_probe(struct platform_device =
*pdev)
>  	pci->dev =3D dev;
>  	pci->ops =3D &dw_pcie_ops;
> =20
> -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "control");
> -	hipcie->ctrl =3D devm_ioremap_resource(dev, res);
> +	hipcie->ctrl =3D devm_platform_ioremap_resource_byname(pdev, "control")=
;
>  	if (IS_ERR(hipcie->ctrl)) {
>  		dev_err(dev, "cannot get control reg base\n");
>  		return PTR_ERR(hipcie->ctrl);
>  	}
> =20
> -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "rc-dbi");
> -	pci->dbi_base =3D devm_ioremap_resource(dev, res);
> +	pci->dbi_base =3D devm_platform_ioremap_resource_byname(pdev, "rc-dbi")=
;
>  	if (IS_ERR(pci->dbi_base)) {
>  		dev_err(dev, "cannot get rc-dbi base\n");
>  		return PTR_ERR(pci->dbi_base);
> diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/con=
troller/dwc/pcie-intel-gw.c
> index 2d8dbb318087..c3b3a1d162b5 100644
> --- a/drivers/pci/controller/dwc/pcie-intel-gw.c
> +++ b/drivers/pci/controller/dwc/pcie-intel-gw.c
> @@ -253,11 +253,9 @@ static int intel_pcie_get_resources(struct platform_=
device *pdev)
>  	struct intel_pcie_port *lpp =3D platform_get_drvdata(pdev);
>  	struct dw_pcie *pci =3D &lpp->pci;
>  	struct device *dev =3D pci->dev;
> -	struct resource *res;
>  	int ret;
> =20
> -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "dbi");
> -	pci->dbi_base =3D devm_ioremap_resource(dev, res);
> +	pci->dbi_base =3D devm_platform_ioremap_resource_byname(pdev, "dbi");
>  	if (IS_ERR(pci->dbi_base))
>  		return PTR_ERR(pci->dbi_base);
> =20
> @@ -291,8 +289,7 @@ static int intel_pcie_get_resources(struct platform_d=
evice *pdev)
>  	ret =3D of_pci_get_max_link_speed(dev->of_node);
>  	lpp->link_gen =3D ret < 0 ? 0 : ret;
> =20
> -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "app");
> -	lpp->app_base =3D devm_ioremap_resource(dev, res);
> +	lpp->app_base =3D devm_platform_ioremap_resource_byname(pdev, "app");
>  	if (IS_ERR(lpp->app_base))
>  		return PTR_ERR(lpp->app_base);
> =20
> diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/contro=
ller/dwc/pcie-kirin.c
> index c19617a912bd..e5e765038686 100644
> --- a/drivers/pci/controller/dwc/pcie-kirin.c
> +++ b/drivers/pci/controller/dwc/pcie-kirin.c
> @@ -147,23 +147,18 @@ static long kirin_pcie_get_clk(struct kirin_pcie *k=
irin_pcie,
>  static long kirin_pcie_get_resource(struct kirin_pcie *kirin_pcie,
>  				    struct platform_device *pdev)
>  {
> -	struct device *dev =3D &pdev->dev;
> -	struct resource *apb;
> -	struct resource *phy;
> -	struct resource *dbi;
> -
> -	apb =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "apb");
> -	kirin_pcie->apb_base =3D devm_ioremap_resource(dev, apb);
> +	kirin_pcie->apb_base =3D
> +		devm_platform_ioremap_resource_byname(pdev, "apb");
>  	if (IS_ERR(kirin_pcie->apb_base))
>  		return PTR_ERR(kirin_pcie->apb_base);
> =20
> -	phy =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy");
> -	kirin_pcie->phy_base =3D devm_ioremap_resource(dev, phy);
> +	kirin_pcie->phy_base =3D
> +		devm_platform_ioremap_resource_byname(pdev, "phy");
>  	if (IS_ERR(kirin_pcie->phy_base))
>  		return PTR_ERR(kirin_pcie->phy_base);
> =20
> -	dbi =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "dbi");
> -	kirin_pcie->pci->dbi_base =3D devm_ioremap_resource(dev, dbi);
> +	kirin_pcie->pci->dbi_base =3D
> +		devm_platform_ioremap_resource_byname(pdev, "dbi");
>  	if (IS_ERR(kirin_pcie->pci->dbi_base))
>  		return PTR_ERR(kirin_pcie->pci->dbi_base);
> =20
> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/control=
ler/dwc/pcie-qcom.c
> index 138e1a2d21cc..91e2e9086564 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> @@ -1358,8 +1358,7 @@ static int qcom_pcie_probe(struct platform_device *=
pdev)
>  		goto err_pm_runtime_put;
>  	}
> =20
> -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "parf");
> -	pcie->parf =3D devm_ioremap_resource(dev, res);
> +	pcie->parf =3D devm_platform_ioremap_resource_byname(pdev, "parf");
>  	if (IS_ERR(pcie->parf)) {
>  		ret =3D PTR_ERR(pcie->parf);
>  		goto err_pm_runtime_put;
> @@ -1372,8 +1371,7 @@ static int qcom_pcie_probe(struct platform_device *=
pdev)
>  		goto err_pm_runtime_put;
>  	}
> =20
> -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "elbi");
> -	pcie->elbi =3D devm_ioremap_resource(dev, res);
> +	pcie->elbi =3D devm_platform_ioremap_resource_byname(pdev, "elbi");
>  	if (IS_ERR(pcie->elbi)) {
>  		ret =3D PTR_ERR(pcie->elbi);
>  		goto err_pm_runtime_put;
> diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c b/drivers/pci/con=
troller/dwc/pcie-uniphier.c
> index a5401a0b1e58..3a7f403b57b8 100644
> --- a/drivers/pci/controller/dwc/pcie-uniphier.c
> +++ b/drivers/pci/controller/dwc/pcie-uniphier.c
> @@ -416,8 +416,7 @@ static int uniphier_pcie_probe(struct platform_device=
 *pdev)
>  	if (IS_ERR(priv->pci.dbi_base))
>  		return PTR_ERR(priv->pci.dbi_base);
> =20
> -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "link");
> -	priv->base =3D devm_ioremap_resource(dev, res);
> +	priv->base =3D devm_platform_ioremap_resource_byname(pdev, "link");
>  	if (IS_ERR(priv->base))
>  		return PTR_ERR(priv->base);
> =20
> --=20
> 2.25.0


Reviewed-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>