Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1115177ybg; Tue, 2 Jun 2020 01:34:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCew9bEtWbWE+UePUQyUoohV7dAjMwr74FV4fXJ3PvOVrkZ3Q24MZ5ryEuAPqk9dIS1rr6 X-Received: by 2002:a05:6402:312a:: with SMTP id dd10mr4942765edb.320.1591086854127; Tue, 02 Jun 2020 01:34:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591086854; cv=none; d=google.com; s=arc-20160816; b=ikzo4GQqfC9WhgD2Jaqp0a+Q/dhNPncQzPbWi+fsSNoY22X/n8527INuz6i7hcJ2vX 6MQpLGgKxUufg8IMbaZgF5zX0wJstV5Qql9Wxuv3m2YfDhgveK6Flk02zwFiPvKph1Y0 Qbo5FHOTrsloNz3/jxmGH4M3fYf++ZIlI8weVKsmE+CJ0BMcmkPfVOM7v2ZhAOmwv9w4 DYRgUcZ/7UOiVxqKTwAHFe7XyUAMYAFwxSoAMKpQkdNbHeXnu1JIu8XIU0Qje7uf14xi yuvzzBYKhaTzH/hsHVZrIkB6PyKitvB+pH8/ft/v2HzZk8KhNhDHQOlAWcuXyG+Fn707 teVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=zcyEbPSV2KB29tiHkE3SoMNctJ85E2cOIO/447pDHUE=; b=UDQDfh0Oy1Y+insy1Iv0LDbbFZH+pM3ZGU3yj3OJrMW5XxqA/a4VrFnv2fExy3Lsk3 37PXNkdnxTN/pfWRJRb/mcutBHs0SM8ZKArmoc74mz13mhkYqqI2oEzQs5OoQzMt6SJi 9SqxuKCmb/qQQYJU+IuORs5Vu6n53LJj4Q0v3VgA9xa0YMXpEyPcDYpDbkbX7N+LMZBK uma7Nbotbmb+muFZIcnolx1U8R8UjEod4dj7Gf0+ECOY/GV0MF2wBuFGBNAj0hENtHOy lK2Edt93x/MHeO9wSuqDZ/Z/HZxGbb9fitkWa4yryhOxNVapw0idCnU3atS87aGtGTJd viyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p22si1047423eju.508.2020.06.02.01.33.51; Tue, 02 Jun 2020 01:34:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726241AbgFBIcC (ORCPT + 99 others); Tue, 2 Jun 2020 04:32:02 -0400 Received: from mailomta17-re.btinternet.com ([213.120.69.110]:39552 "EHLO re-prd-fep-049.btinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725811AbgFBIcC (ORCPT ); Tue, 2 Jun 2020 04:32:02 -0400 Received: from re-prd-rgout-005.btmx-prd.synchronoss.net ([10.2.54.8]) by re-prd-fep-049.btinternet.com with ESMTP id <20200602083159.THRB11381.re-prd-fep-049.btinternet.com@re-prd-rgout-005.btmx-prd.synchronoss.net>; Tue, 2 Jun 2020 09:31:59 +0100 Authentication-Results: btinternet.com; auth=pass (LOGIN) smtp.auth=j.oldman998@btinternet.com X-Originating-IP: [81.152.95.229] X-OWM-Source-IP: 81.152.95.229 (GB) X-OWM-Env-Sender: j.oldman998@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgeduhedrudefjedgtdduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecunecujfgurhephffvufffkffosedttdertdertddtnecuhfhrohhmpeflohhhnhcuqfhlughmrghnuceojhhohhhnrdholhgumhgrnhesphholhgvhhhilhhlrdgtohdruhhkqeenucggtffrrghtthgvrhhnpeegfedthfefueeihffgkeefteehuddttdefudetveelveefvdefhfejieejhffggfenucfkphepkedurdduhedvrdelhedrvddvleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopehhvghnrhihrdhhohhmvgdpihhnvghtpeekuddrudehvddrleehrddvvdelpdhmrghilhhfrhhomhepoehjohhhnhdrohhlughmrghnsehpohhlvghhihhllhdrtghordhukheqpdhrtghpthhtohepoeguvghvvghlsegurhhivhgvrhguvghvrdhoshhuohhslhdrohhrgheqpdhrtghpthhtohepoehgrhgvghhkhheslhhinhhugihfohhunhgurghtihhonhdrohhrgheqpdhrtghpthhtohepoehjohhhnhdrohhlughmrghnsehpohhlvghhihhllhdrtghordhukheqpdhrtghpthhtohepoehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgheq X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from henry.home (81.152.95.229) by re-prd-rgout-005.btmx-prd.synchronoss.net (5.8.340) (authenticated as j.oldman998@btinternet.com) id 5E3A195F13ABC0DB; Tue, 2 Jun 2020 09:31:59 +0100 From: John Oldman To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, John Oldman Subject: [PATCH] staging: rtl8192e: Using comparison to false is error prone Date: Tue, 2 Jun 2020 09:31:27 +0100 Message-Id: <20200602083127.25271-1-john.oldman@polehill.co.uk> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org clear below issues reported by checkpatch.pl: CHECK: Using comparison to false is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index d83d72594312..8abc921ecb3e 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -371,7 +371,7 @@ void HTConstructInfoElement(struct rtllib_device *ieee, u8 *posHTInfo, if ((ieee->iw_mode == IW_MODE_ADHOC) || (ieee->iw_mode == IW_MODE_MASTER)) { pHTInfoEle->ControlChl = ieee->current_network.channel; - pHTInfoEle->ExtChlOffset = ((pHT->bRegBW40MHz == false) ? + pHTInfoEle->ExtChlOffset = ((!pHT->bRegBW40MHz) ? HT_EXTCHNL_OFFSET_NO_EXT : (ieee->current_network.channel <= 6) ? HT_EXTCHNL_OFFSET_UPPER : @@ -526,7 +526,7 @@ void HTOnAssocRsp(struct rtllib_device *ieee) static u8 EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33}; static u8 EWC11NHTInfo[] = {0x00, 0x90, 0x4c, 0x34}; - if (pHTInfo->bCurrentHTSupport == false) { + if (!pHTInfo->bCurrentHTSupport) { netdev_warn(ieee->dev, "%s(): HT_DISABLE\n", __func__); return; } @@ -873,7 +873,7 @@ void HTSetConnectBwMode(struct rtllib_device *ieee, { struct rt_hi_throughput *pHTInfo = ieee->pHTInfo; - if (pHTInfo->bRegBW40MHz == false) + if (!pHTInfo->bRegBW40MHz) return; if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) -- 2.17.1