Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1154787ybg; Tue, 2 Jun 2020 02:46:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrFZvNROO8/eAf5aUmmhAa+XMfLEY6jy/KUhGT2YYym7zt6ZR29nUM1RutF4mBceWO8bns X-Received: by 2002:a17:906:3da1:: with SMTP id y1mr21212899ejh.109.1591091164561; Tue, 02 Jun 2020 02:46:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591091164; cv=none; d=google.com; s=arc-20160816; b=nx1NMC8+x8QY7Chk7sUClFc1s7kXkDw7JZGCuVXz6v3PFJpmyTEOqAYwfsI3NJeAQB iI2+W/H3hG3OxZLDRHDghYQhH6q21cU1CJH3Y7QKyrFRN7s4uN3K0QKGubmb+aSYJH/l tDR3YUowCsetEAgUx7DW1EowU6h1Vektil57rYT15E/6uqVPhzW/HAdGVzge/4r7JoTN Q8jc02h8IvSLnXtZuAP7j16z/S14S6AQNXmrqxcm5RtnrYaRkHVZs9z6zijp15q545UH mrQ0JDLD8rTtIWTJjdNQ0nBk0NJ3Hwf9LTYqoa6YYlzsx2hF4RDwWlhS9Y2xshmq65j3 NCnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=k6Y9fi2QFOp2eMxHXPAGJD4nQ4MR1vH7a42nA40n98A=; b=Ec/3dBJfS5WPHpC94mK6GW8p1mu++1trq4P9Wuy/QFQx0f0Cj4CTFUm0nw1UNutkXD EdM3hUECkOoGkRzDy0WJt4DwoHgXtO5NYDNKeUVgrCHfwW3kxn3nu0oP6MarIbMkC8tw 5OTc7I5ngnMWFZNH8cjNfznwzchwLA1iONQ7L8UilVODI2OGl+fxqBz3d0iFSqz8bAyv Ts6bHMs7s1a3sy4D8yvycRZzTe4LmZ8QjhO96e1stZKKk9yRcBXCBuIVrAiKcxz2hhlH 23lfRRLh4cqFpmLKyJPMoTuTFsGDweuSmmLNngQQQ5G/DiZJXAgUaAnF2owfHx5sGQBi cPHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vaHfQGJn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h14si1143431edq.256.2020.06.02.02.45.41; Tue, 02 Jun 2020 02:46:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vaHfQGJn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726636AbgFBJoB (ORCPT + 99 others); Tue, 2 Jun 2020 05:44:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726012AbgFBJoA (ORCPT ); Tue, 2 Jun 2020 05:44:00 -0400 Received: from mail-oo1-xc42.google.com (mail-oo1-xc42.google.com [IPv6:2607:f8b0:4864:20::c42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 199B3C061A0E for ; Tue, 2 Jun 2020 02:44:00 -0700 (PDT) Received: by mail-oo1-xc42.google.com with SMTP id p9so2023165oot.12 for ; Tue, 02 Jun 2020 02:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=k6Y9fi2QFOp2eMxHXPAGJD4nQ4MR1vH7a42nA40n98A=; b=vaHfQGJnM6y/6oKxAMkEoiWfu17U74Sm4iWwCzMEoMFTr0UG/U0GwYG7ZmJjTlDe3r DHuhJ4mjUm4hGfQJhlk01Pb/IzjR+3EEOXZpASgMJapng+RerjoVhwuhOmmesTf07NU/ yRV5ZfvqYfa0YfYzwUFqFsaB3z7tW1PZZZZcR4kNz8wIthLG0y+v3KovG7fGZypIIKX2 UYmP/DFO49Tdl6ZZizSh9T/LQm3Tg2O682rW3tNI9hyDqUUS3HAuwAT0iWn2FZYiz4/h TXQEIdYTzTFDE0MzmskePS+rJskkKR6oEX2bx5Ib6UzBedBCXrTvcC5syDrPD2cyKCY2 DEQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=k6Y9fi2QFOp2eMxHXPAGJD4nQ4MR1vH7a42nA40n98A=; b=E9CLFSD6TEgE3XdWv+aRsOQCl4MRuEb3NZe3pChcli4+LOO3OuIeFKk5ZUqdvyzcup qQhIW2DPUFj8A5Pb/ULIgvMyZ3bmxakHFhRu9LBtgdERAyPjqAT/mewPqhjMqg90PmnY BI6wdtvTkRTy5zXhDF/vUV9oaXiajTcxZZGq3M6NZrYw4GrynNwte+X4kDcVSzmAoz7w Wpfl7910FNjHsxxhlLUX0GXGKelgBH6QitU6zC6q1+ASJpC3I9BtEMAoFiqaOFeA7BXs 8sPMr8rbzhA2XMNbKXnsqwxtLxJTQ5neKnZqEWAaMW9TD6v0nky6cQB8qdYvAqJ7sxAM /nUA== X-Gm-Message-State: AOAM5321Z5Je8RaY4Bwe22zZk6h0/5wM8FooM4kqVTqj1Ym5IXmNW48A a7zL8kwcCMxKjQMr+2g3gIQ= X-Received: by 2002:a4a:144:: with SMTP id 65mr19719215oor.70.1591091039300; Tue, 02 Jun 2020 02:43:59 -0700 (PDT) Received: from ziggy.stardust ([213.195.114.138]) by smtp.gmail.com with ESMTPSA id s11sm530652otk.26.2020.06.02.02.43.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2020 02:43:58 -0700 (PDT) Subject: Re: [PATCH v10] mfd: mt6360: add pmic mt6360 driver To: Lee Jones , Gene Chen Cc: linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, gene_chen@richtek.com, Wilma.Wu@mediatek.com, shufan_lee@richtek.com, cy_huang@richtek.com References: <1591070142-7653-1-git-send-email-gene.chen.richtek@gmail.com> <20200602082816.GC3714@dell> From: Matthias Brugger Autocrypt: addr=matthias.bgg@gmail.com; prefer-encrypt=mutual; keydata= mQINBFP1zgUBEAC21D6hk7//0kOmsUrE3eZ55kjc9DmFPKIz6l4NggqwQjBNRHIMh04BbCMY fL3eT7ZsYV5nur7zctmJ+vbszoOASXUpfq8M+S5hU2w7sBaVk5rpH9yW8CUWz2+ZpQXPJcFa OhLZuSKB1F5JcvLbETRjNzNU7B3TdS2+zkgQQdEyt7Ij2HXGLJ2w+yG2GuR9/iyCJRf10Okq gTh//XESJZ8S6KlOWbLXRE+yfkKDXQx2Jr1XuVvM3zPqH5FMg8reRVFsQ+vI0b+OlyekT/Xe 0Hwvqkev95GG6x7yseJwI+2ydDH6M5O7fPKFW5mzAdDE2g/K9B4e2tYK6/rA7Fq4cqiAw1+u EgO44+eFgv082xtBez5WNkGn18vtw0LW3ESmKh19u6kEGoi0WZwslCNaGFrS4M7OH+aOJeqK fx5dIv2CEbxc6xnHY7dwkcHikTA4QdbdFeUSuj4YhIZ+0QlDVtS1QEXyvZbZky7ur9rHkZvP ZqlUsLJ2nOqsmahMTIQ8Mgx9SLEShWqD4kOF4zNfPJsgEMB49KbS2o9jxbGB+JKupjNddfxZ HlH1KF8QwCMZEYaTNogrVazuEJzx6JdRpR3sFda/0x5qjTadwIW6Cl9tkqe2h391dOGX1eOA 1ntn9O/39KqSrWNGvm+1raHK+Ev1yPtn0Wxn+0oy1tl67TxUjQARAQABtClNYXR0aGlhcyBC cnVnZ2VyIDxtYXR0aGlhcy5iZ2dAZ21haWwuY29tPokCUgQTAQIAPAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AWIQTmuZIYwPLDJRwsOhfZFAuyVhMC8QUCWt3scQIZAQAKCRDZFAuy VhMC8WzRD/4onkC+gCxG+dvui5SXCJ7bGLCu0xVtiGC673Kz5Aq3heITsERHBV0BqqctOEBy ZozQQe2Hindu9lasOmwfH8+vfTK+2teCgWesoE3g3XKbrOCB4RSrQmXGC3JYx6rcvMlLV/Ch YMRR3qv04BOchnjkGtvm9aZWH52/6XfChyh7XYndTe5F2bqeTjt+kF/ql+xMc4E6pniqIfkv c0wsH4CkBHqoZl9w5e/b9MspTqsU9NszTEOFhy7p2CYw6JEa/vmzR6YDzGs8AihieIXDOfpT DUr0YUlDrwDSrlm/2MjNIPTmSGHH94ScOqu/XmGW/0q1iar/Yr0leomUOeeEzCqQtunqShtE 4Mn2uEixFL+9jiVtMjujr6mphznwpEqObPCZ3IcWqOFEz77rSL+oqFiEA03A2WBDlMm++Sve 9jpkJBLosJRhAYmQ6ey6MFO6Krylw1LXcq5z1XQQavtFRgZoruHZ3XlhT5wcfLJtAqrtfCe0 aQ0kJW+4zj9/So0uxJDAtGuOpDYnmK26dgFN0tAhVuNInEVhtErtLJHeJzFKJzNyQ4GlCaLw jKcwWcqDJcrx9R7LsCu4l2XpKiyxY6fO4O8DnSleVll9NPfAZFZvf8AIy3EQ8BokUsiuUYHz wUo6pclk55PZRaAsHDX/fNr24uC6Eh5oNQ+v4Pax/gtyybkCDQRd1TkHARAAt1BBpmaH+0o+ deSyJotkrpzZZkbSs5ygBniCUGQqXpWqgrc7Uo/qtxOFL91uOsdX1/vsnJO9FyUv3ZNI2Thw NVGCTvCP9E6u4gSSuxEfVyVThCSPvRJHCG2rC+EMAOUMpxokcX9M2b7bBEbcSjeP/E4KTa39 q+JJSeWliaghUfMXXdimT/uxpP5Aa2/D/vcUUGHLelf9TyihHyBohdyNzeEF3v9rq7kdqamZ Ihb+WYrDio/SzqTd1g+wnPJbnu45zkoQrYtBu58n7u8oo+pUummOuTR2b6dcsiB9zJaiVRIg OqL8p3K2fnE8Ewwn6IKHnLTyx5T/r2Z0ikyOeijDumZ0VOPPLTnwmb780Nym3LW1OUMieKtn I3v5GzZyS83NontvsiRd4oPGQDRBT39jAyBr8vDRl/3RpLKuwWBFTs1bYMLu0sYarwowOz8+ Mn+CRFUvRrXxociw5n0P1PgJ7vQey4muCZ4VynH1SeVb3KZ59zcQHksKtpzz2OKhtX8FCeVO mHW9u4x8s/oUVMZCXEq9QrmVhdIvJnBCqq+1bh5UC2Rfjm/vLHwt5hes0HDstbCzLyiA0LTI ADdP77RN2OJbzBkCuWE21YCTLtc8kTQlP+G8m23K5w8k2jleCSKumprCr/5qPyNlkie1HC4E GEAfdfN+uLsFw6qPzSAsmukAEQEAAYkEbAQYAQgAIBYhBOa5khjA8sMlHCw6F9kUC7JWEwLx BQJd1TkHAhsCAkAJENkUC7JWEwLxwXQgBBkBCAAdFiEEUdvKHhzqrUYPB/u8L21+TfbCqH4F Al3VOQcACgkQL21+TfbCqH79RRAAtlb6oAL9y8JM5R1T3v02THFip8OMh7YvEJCnezle9Apq C6Vx26RSQjBV1JwSBv6BpgDBNXarTGCPXcre6KGfX8u1r6hnXAHZNHP7bFGJQiBv5RqGFf45 OhOhbjXCyHc0jrnNjY4M2jTkUC+KIuOzasvggU975nolC8MiaBqfgMB2ab5W+xEiTcNCOg3+ 1SRs5/ZkQ0iyyba2FihSeSw3jTUjPsJBF15xndexoc9jpi0RKuvPiJ191Xa3pzNntIxpsxqc ZkS1HSqPI63/urNezeSejBzW0Xz2Bi/b/5R9Hpxp1AEC3OzabOBATY/1Bmh2eAVK3xpN2Fe1 Zj7HrTgmzBmSefMcSXN0oKQWEI5tHtBbw5XUj0Nw4hMhUtiMfE2HAqcaozsL34sEzi3eethZ IvKnIOTmllsDFMbOBa8oUSoaNg7GzkWSKJ59a9qPJkoj/hJqqeyEXF+WTCUv6FcA8BtBJmVf FppFzLFM/QzF5fgDZmfjc9czjRJHAGHRMMnQlW88iWamjYVye57srNq9pUql6A4lITF7w00B 5PXINFk0lMcNUdkWipu24H6rJhOO6xSP4n6OrCCcGsXsAR5oH3d4TzA9iPYrmfXAXD+hTp82 s+7cEbTsCJ9MMq09/GTCeroTQiqkp50UaR0AvhuPdfjJwVYZfmMS1+5IXA/KY6DbGBAAs5ti AK0ieoZlCv/YxOSMCz10EQWMymD2gghjxojf4iwB2MbGp8UN4+++oKLHz+2j+IL08rd2ioFN YCJBFDVoDRpF/UnrQ8LsH55UZBHuu5XyMkdJzMaHRVQc1rzfluqx+0a/CQ6Cb2q7J2d45nYx 8jMSCsGj1/iU/bKjMBtuh91hsbdWCxMRW0JnGXxcEUklbhA5uGj3W4VYCfTQxwK6JiVt7JYp bX7JdRKIyq3iMDcsTXi7dhhwqsttQRwbBci0UdFGAG4jT5p6u65MMDVTXEgYfZy0674P06qf uSyff73ivwvLR025akzJui8MLU23rWRywXOyTINz8nsPFT4ZSGT1hr5VnIBs/esk/2yFmVoc FAxs1aBO29iHmjJ8D84EJvOcKfh9RKeW8yeBNKXHrcOV4MbMOts9+vpJgBFDnJeLFQPtTHuI kQXT4+yLDvwOVAW9MPLfcHlczq/A/nhGVaG+RKWDfJWNSu/mbhqUQt4J+RFpfx1gmL3yV8NN 7JXABPi5M97PeKdx6qc/c1o3oEHH8iBkWZIYMS9fd6rtAqV3+KH5Ors7tQVtwUIDYEvttmeO ifvpW6U/4au4zBYfvvXagbyXJhG9mZvz+jN1cr0/G2ZC93IbjFFwUmHtXS4ttQ4pbrX6fjTe lq5vmROjiWirpZGm+WA3Vx9QRjqfMdS5Ag0EXdU5SAEQAJu/Jk58uOB8HSGDSuGUB+lOacXC bVOOSywZkq+Ayv+3q/XIabyeaYMwhriNuXHjUxIORQoWHIHzTCqsAgHpJFfSHoM4ulCuOPFt XjqfEHkA0urB6S0jnvJ6ev875lL4Yi6JJO7WQYRs/l7OakJiT13GoOwDIn7hHH/PGUqQoZlA d1n5SVdg6cRd7EqJ+RMNoud7ply6nUSCRMNWbNqbgyWjKsD98CMjHa33SB9WQQSQyFlf+dz+ dpirWENCoY3vvwKJaSpfeqKYuqPVSxnqpKXqqyjNnG9W46OWZp+JV5ejbyUR/2U+vMwbTilL cIUpTgdmxPCA6J0GQjmKNsNKKYgIMn6W4o/LoiO7IgROm1sdn0KbJouCa2QZoQ0+p/7mJXhl tA0XGZhNlI3npD1lLpjdd42lWboU4VeuUp4VNOXIWU/L1NZwEwMIqzFXl4HmRi8MYbHHbpN5 zW+VUrFfeRDPyjrYpax+vWS+l658PPH+sWmhj3VclIoAU1nP33FrsNfp5BiQzao30rwe4ntd eEdPENvGmLfCwiUV2DNVrmJaE3CIUUl1KIRoB5oe7rJeOvf0WuQhWjIU98glXIrh3WYd7vsf jtbEXDoWhVtwZMShMvp7ccPCe2c4YBToIthxpDhoDPUdNwOssHNLD8G4JIBexwi4q7IT9lP6 sVstwvA5ABEBAAGJAjYEGAEIACAWIQTmuZIYwPLDJRwsOhfZFAuyVhMC8QUCXdU5SAIbDAAK CRDZFAuyVhMC8bXXD/4xyfbyPGnRYtR0KFlCgkG2XWeWSR2shSiM1PZGRPxR888zA2WBYHAk 7NpJlFchpaErV6WdFrXQjDAd9YwaEHucfS7SAhxIqdIqzV5vNFrMjwhB1N8MfdUJDpgyX7Zu k/Phd5aoZXNwsCRqaD2OwFZXr81zSXwE2UdPmIfTYTjeVsOAI7GZ7akCsRPK64ni0XfoXue2 XUSrUUTRimTkuMHrTYaHY3544a+GduQQLLA+avseLmjvKHxsU4zna0p0Yb4czwoJj+wSkVGQ NMDbxcY26CMPK204jhRm9RG687qq6691hbiuAtWABeAsl1AS+mdS7aP/4uOM4kFCvXYgIHxP /BoVz9CZTMEVAZVzbRKyYCLUf1wLhcHzugTiONz9fWMBLLskKvq7m1tlr61mNgY9nVwwClMU uE7i1H9r/2/UXLd+pY82zcXhFrfmKuCDmOkB5xPsOMVQJH8I0/lbqfLAqfsxSb/X1VKaP243 jzi+DzD9cvj2K6eD5j5kcKJJQactXqfJvF1Eb+OnxlB1BCLE8D1rNkPO5O742Mq3MgDmq19l +abzEL6QDAAxn9md8KwrA3RtucNh87cHlDXfUBKa7SRvBjTczDg+HEPNk2u3hrz1j3l2rliQ y1UfYx7Vk/TrdwUIJgKS8QAr8Lw9WuvY2hSqL9vEjx8VAkPWNWPwrQ== Message-ID: <2231bffe-27d1-6aee-4699-77d2f754beef@gmail.com> Date: Tue, 2 Jun 2020 11:43:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200602082816.GC3714@dell> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/06/2020 10:28, Lee Jones wrote: > On Tue, 02 Jun 2020, Gene Chen wrote: > >> From: Gene Chen >> >> Add MFD driver for mt6360 pmic chip include Battery Charger/ >> USB_PD/Flash, LED/RGB and LED/LDO/Buck >> >> Signed-off-by: Gene Chen >> Signed-off-by: Lee Jones > > I did not sign this off. > You are right, you provided your Acked-for-MFD-by and took an earlier version of the patch [1]. But as this didn't show up in linux-next I suppose you dropped it afterwards because of kbuild test errors (deducing from the changes log). I suppose if this errors are fixed now, we should be fine :) Regards, Matthias [1] https://lkml.kernel.org/lkml/1587641093-25441-1-git-send-email-gene.chen.richtek@gmail.com/T/#m75e8ee81950ee34e155eccd2dc5ad9b1d2cef40a >> --- >> drivers/mfd/Kconfig | 12 ++ >> drivers/mfd/Makefile | 1 + >> drivers/mfd/mt6360-core.c | 424 +++++++++++++++++++++++++++++++++++++++++++++ >> include/linux/mfd/mt6360.h | 240 +++++++++++++++++++++++++ >> 4 files changed, 677 insertions(+) >> create mode 100644 drivers/mfd/mt6360-core.c >> create mode 100644 include/linux/mfd/mt6360.h >> >> changelogs between v1 & v2 >> - include missing header file >> >> changelogs between v2 & v3 >> - add changelogs >> >> changelogs between v3 & v4 >> - fix Kconfig description >> - replace mt6360_pmu_info with mt6360_pmu_data >> - replace probe with probe_new >> - remove unnecessary irq_chip variable >> - remove annotation >> - replace MT6360_MFD_CELL with OF_MFD_CELL >> >> changelogs between v4 & v5 >> - remove unnecessary parse dt function >> - use devm_i2c_new_dummy_device >> - add base-commit message >> >> changelogs between v5 & v6 >> - review return value >> - remove i2c id_table >> - use GPL license v2 >> >> changelogs between v6 & v7 >> - add author description >> - replace MT6360_REGMAP_IRQ_REG by REGMAP_IRQ_REG_LINE >> - remove mt6360-private.h >> >> changelogs between v7 & v8 >> - fix kbuild auto reboot by include interrupt header >> >> changelogs between v8 & v9 >> - fix GPL license out of date >> - add commit message about Acked-for-MFD-by >> >> changelogs between v9 & v10 > > v9 of this patch is already applied. > > You cannot send a v10. > >> - fix duplicate define of kbuild test reboot initializer-overrides > > I fixed this already. > > https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/?h=for-mfd-next&id=098c4adf249c198519a4abebe482b1e6b8c50e47 > >> - sync commit message format >