Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1158400ybg; Tue, 2 Jun 2020 02:52:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOeHPetsbGASsWKQzoHIUst+JTm4eTEkjC87TI9lGSOIAfPMVEPwLbBVTtPpO0ApAexTIz X-Received: by 2002:a05:6402:2c4:: with SMTP id b4mr26379289edx.331.1591091547789; Tue, 02 Jun 2020 02:52:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591091547; cv=none; d=google.com; s=arc-20160816; b=m2tsVWPS/qbdBMStGTshnlKgB6P57hJNcaKeBtG6Iq88cqktGxCWt8JZ5byof0gD0i cOHVDrG4Q9VYoXS1swgPV/4dWIu6jzZOSO1emUG5WSYkzgR9owqyxlNE4kMgH4DnYUtw x02kJDMD6s/D9dHIXJnhgfSFDs5wUfXqoRG4DmKOugCWZpMdzcY3vYDwqOYq8YmWeelZ uSFE51oSbb/suLOeJoDZtIEOXc1sGTYNjrXmi5ucamAOUZdf3AJpsi0NfId6roUF61cA 3AFZXdq1nmGMDzJk+cWCkYm9Zu2gVIErixMZ5YiWdc8XPXsTQdSVG7RCZUOVIROr/eq5 Ye1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=HxdxaFtsMgHyHf6FbAx/V9r5olbMQz7W4Kjlekx7Igg=; b=fYUwmdaqqIMdcwYgvz5/pm6J7GgJ8PqN8mNEoZwIRj+yoynSYFYkmGnAntG73XuGYh ruejtxYsZInvSvw8Uv055LUjF4KosZFBTfw2Il/rIogiE3SQH7jaaRslu+c4BllgqRjz tZRcXGo5B+DY/1nzjIhcFfkBkSX08GY7vnCRuN78TGaAPxUu5XHOLHpjRd/LuF3eFAgW cFR9VveF9PRhHoV4k+WdinDa2TiRIp5cpp38NWANBROjYsl3rsqi7VL4Ko1gyfVCgLa0 hgXBrvhE6iaQJ/4c5AgwYZ8rJFMhUqsz+7gxvDPgBEoJHxncvjM1USPM8TRKJTPbXkUg iWzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Cu0Rsuf7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q16si1180599ejt.712.2020.06.02.02.52.04; Tue, 02 Jun 2020 02:52:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Cu0Rsuf7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726917AbgFBJtv (ORCPT + 99 others); Tue, 2 Jun 2020 05:49:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:47204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725958AbgFBJtu (ORCPT ); Tue, 2 Jun 2020 05:49:50 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8582920679; Tue, 2 Jun 2020 09:49:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591091390; bh=7Cy56Bnu1NcpQ7UwmRjSTV/5jRN6OIJUxT52J5jFI6E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Cu0Rsuf7AbaiYX/J0nYfTDJppwK7y9QMiRWWqXdUSp7obOlFCpFRX7WjOpRrg1ZXT IMNiU6fo0dE5j/Zy4eYOZNY+1y81uZ9CQK3im/EkG7f1PIXMhOaggrZfCMjGhllpiz 1w8GZdefBEVvpa7pLvHT8dEASWG2vhOojvkdRsEY= Date: Tue, 2 Jun 2020 10:49:47 +0100 From: Mark Brown To: Markus Elfring Cc: Navid Emamdoost , linux-spi@vger.kernel.org, Navid Emamdoost , Kangjie Lu , Stephen McCamant , Qiushi Wu , Dinghao Liu , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] spi: spi-ti-qspi: call pm_runtime_put on pm_runtime_get failure Message-ID: <20200602094947.GA5684@sirena.org.uk> References: <26028f50-3fb8-eb08-3c9f-08ada018bf9e@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BXVAT5kNtrzKuDFl" Content-Disposition: inline In-Reply-To: <26028f50-3fb8-eb08-3c9f-08ada018bf9e@web.de> X-Cookie: We are not a clone. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --BXVAT5kNtrzKuDFl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 02, 2020 at 10:40:33AM +0200, Markus Elfring wrote: > > The counter is incremented via pm_runtime_get even in failure case. > > To correct the counter call pm_runtime_put in case of failure, too. >=20 > How do you think about a wording variant like the following? >=20 > Change description: > The PM runtime reference counter is generally incremented by a call of > the function =E2=80=9Cpm_runtime_get_sync=E2=80=9D. > Thus call the function =E2=80=9Cpm_runtime_put_autosuspend=E2=80=9D al= so in one error case > to keep the reference counting consistent. The original changelog is perfectly fine, please stop sending these. --BXVAT5kNtrzKuDFl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7WILoACgkQJNaLcl1U h9DjBAf8Cv2mppt2k43MzqHRc3jstaRWync9NLGQlJhGTT7Y3mPwynIc64JoOPKk n88vwec+oBWDCnFUZZzNT7eK3XYJNFvnC10mt0p8kZSYu1wznntH/lBA8FNMu7Qy varbbXp5irF+x1VyKfc3phJG/s7Gi5jnixtv/MZcEBY84GroD4nXvwlmIWzPrhxo EJEAVd2F4Eea5n7p9ivEDRacCkP7G/2jYTYjWdfW6JYkJVpLgJdH6xzuD3cWZjIb KkXT4EbKlh/6F6oOuutwsc0tRHG++YeOVAGNbqtSrpELbzOx9e8v4qeSedSzAxta Bx995z3ICwchSCLdLMZWqRI44gr4ow== =l1jf -----END PGP SIGNATURE----- --BXVAT5kNtrzKuDFl--