Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Jun 2020 12:56:49 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Petteri Aimonen <jpa@git.mail.kapsi.fi>
Cc:     Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86-ml <x86@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arch/x86: reset MXCSR to default in kernel_fpu_begin()
Message-ID: <20200602105649.GB11634@zn.tnic>
References: <20200602101119.GA11634@zn.tnic>
 <20200602102951.GE17423@lakka.kapsi.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200602102951.GE17423@lakka.kapsi.fi>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Tue, Jun 02, 2020 at 01:29:51PM +0300, Petteri Aimonen wrote:
> The kernel module is not actually x86-specific, even though it is 
> currently only enabled for x86. amdgpu driver already does kernel mode 
> floating point operations on PPC64 also, and the same module could be 
> used to test the same thing there.

Then make it generic please and put the user portion in, say,
tools/testing/selftests/fpu/ and we can ask ppc people to test it too.
People might wanna add more stuff to it in the future, which would be
good.

> To deterministically trigger the bug, the syscall has to come from the 
> same thread that has modified MXCSR. Going through /usr/sbin/modprobe 
> won't work, and manually doing the necessary syscalls for module loading 
> seems too complicated.

Ok, fair enough. But put that file in debugfs pls.

> The fesetround() and feenableexcept() are the portable ways to modify 
> MXCSR. The test module does cause Precision Exception and Denormal 
> Exception if those exceptions are unmasked.

Ok.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette