Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1215955ybg; Tue, 2 Jun 2020 04:26:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1+8c7Nfp1ZpLRTIcmlWBDj/bBTKubH8zS9RGHBq689+tMkNN54RSoXjZZPg4qtdHZOoUW X-Received: by 2002:a05:6402:b13:: with SMTP id bm19mr6443159edb.82.1591097217877; Tue, 02 Jun 2020 04:26:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591097217; cv=none; d=google.com; s=arc-20160816; b=RPE/FyLrcr0KhO8iLKNrJZpfAv9pPYlWlnrX1CwcSiDzz8IXeCzgzllaxw3vXt7PV+ SRqig0roHpM6IfbQUa+tBFh/zHbaysr4i1bRH3W4U/21cAxwJTn3bLcH9ZqouN1pT24f 47m0r1/UlAt0Vc703okz5wmbvHSVl8/LPLlBLJv77OC1O1BnNp4u+ShOdYC4rv/WjhTJ 1MI9Coaint58dVsNNB7olsF6sV4ouAuvF7JcsjAtcrEmTnr/DitO3quIxiaExA14WVTc 6rJb2ITO5rhEh0dxQ/Bv8aM8Nl6z4QBtLpambSQO3/vghVsRGed+KoEKPSx5MMJ2OHgF lwGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=LFCYo6Ppo4sEF/Ge4xWjhzf5GS4llSMO5W63JlrM7KQ=; b=ajvOXUks0wYuc4r5PThVqxpU4GeaYBT0Vk8gyXf21Rw1GCSl7/vLR1xquMgqCdaLl6 z8AtvrcPSx/xigQr66K+2ESv7/oTwxdR/LhHFAbnhHyYmP4vEWI8xFmv1C9PVFzBp+I6 O0iEoNxyTqtTg9kya2havT/maa+8f6FzqapF8hTWIAb4oju0xoSPIsiNrVJrNv70twAD G2SZal1JBUjNhoUdlpOElVfd0D9nXvQEoR55sMlw43SHs6NKsqYSWFWZqZAHlPnKFmQQ lL0QjOeF9X9kNsGczq6OWT/VIgX9HUH1T3WiCige1O/rjAnh+XolrxV/G5pAo5eXtcth to/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bKZCM1vP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i9si1355725edf.484.2020.06.02.04.26.35; Tue, 02 Jun 2020 04:26:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bKZCM1vP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726380AbgFBLWl (ORCPT + 99 others); Tue, 2 Jun 2020 07:22:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725900AbgFBLWl (ORCPT ); Tue, 2 Jun 2020 07:22:41 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 405CCC061A0E; Tue, 2 Jun 2020 04:22:41 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id n9so1240223plk.1; Tue, 02 Jun 2020 04:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=LFCYo6Ppo4sEF/Ge4xWjhzf5GS4llSMO5W63JlrM7KQ=; b=bKZCM1vPpptfyYMSXvgRkpuRDbMki1FhOPMqlwbLnVstbWg0qiqkCS1O57oOXwQuQd +ilqEQ3DcHER6lECOK0foKhzOkTLOSYYit6+mH2EPqtG6maZexBnUAhVwi21cWColo0Q LNLXHyjqDkZ+BpqzSA4rD7zFYqK9asLhlURmRvN5Clt2uOtW5gk+oJJMZgIKxdV4HfME XLZ+iDkilPNPZAN39AAfIUzJ1nHvXIMVEWwTbpZ+ZKUPESlWucThCvXB2gDmpRwMTDSu 6UJDn0pcZiK9LrY8sUHbLAI4FD7gQnKG+9tZ7dDHfESkcuIw0qdBa9KR49+mZTrYxGwB DLdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=LFCYo6Ppo4sEF/Ge4xWjhzf5GS4llSMO5W63JlrM7KQ=; b=W1I5D3653Iy6hxd+zG13t5VuSXLERO31JyAK4HArgnjUAT515TtgtPa1I+pE5n4Kqe 0fjzC9QI2HnQpjcAM8hmnTXchdKY112JkOH3fs871uEkpiQbHcphDgenwzuC0UcRjY1v 6d+4vjXFCTfdJob9QJWF2Xwjcy+wMRUxhyoc1QcfIn7yIsULoEqPgWtanzAlm8+LUoCJ 4bWJ2IcRT7zb2MfEM/12E58GsgxvNSPNSg1WnqjFhbid3JZKk87PwbDkCcKorv6Lb1Ct zCMJEcQ6z2wj6TYtBYPf4XiLqMSA456sW1FERShdAHKDkDCgeah8NkVTfIu0hu6B+qMS CtYg== X-Gm-Message-State: AOAM531Udhb/OXNjIdpom/7njC5K+9SiSuxfvArt1u6PrdZMr7jf0aM3 VSwcli1Big9e1jh83eTixBk= X-Received: by 2002:a17:902:bb95:: with SMTP id m21mr12586768pls.262.1591096960561; Tue, 02 Jun 2020 04:22:40 -0700 (PDT) Received: from localhost.localdomain ([2409:4072:189:c86a:7149:74ab:b584:ecf8]) by smtp.gmail.com with ESMTPSA id j9sm2238172pje.28.2020.06.02.04.22.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2020 04:22:39 -0700 (PDT) From: Aishwarya Ramakrishnan To: Rain River , Zhu Yanjun , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: aishwaryarj100@gmail.com Subject: [PATCH] net: nvidia: forcedeth: Drop a condition with no effect Date: Tue, 2 Jun 2020 16:52:28 +0530 Message-Id: <20200602112228.30333-1-aishwaryarj100@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As the "else if" and "else" branch body are identical the condition has no effect. So removing "else if" condition. Signed-off-by: Aishwarya Ramakrishnan --- drivers/net/ethernet/nvidia/forcedeth.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c index 2fc10a36afa4..87ed7e192ce9 100644 --- a/drivers/net/ethernet/nvidia/forcedeth.c +++ b/drivers/net/ethernet/nvidia/forcedeth.c @@ -3476,9 +3476,6 @@ static int nv_update_linkspeed(struct net_device *dev) } else if (adv_lpa & LPA_10FULL) { newls = NVREG_LINKSPEED_FORCE|NVREG_LINKSPEED_10; newdup = 1; - } else if (adv_lpa & LPA_10HALF) { - newls = NVREG_LINKSPEED_FORCE|NVREG_LINKSPEED_10; - newdup = 0; } else { newls = NVREG_LINKSPEED_FORCE|NVREG_LINKSPEED_10; newdup = 0; -- 2.17.1