Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1229958ybg; Tue, 2 Jun 2020 04:50:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx81VzXUo7QcEPVNo9q77PuKIYg6GrJRr95a3gHDbSOppPcADYuNzXk6XhKrIQJKfCvnNMY X-Received: by 2002:a50:e14e:: with SMTP id i14mr25006980edl.279.1591098603536; Tue, 02 Jun 2020 04:50:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591098603; cv=none; d=google.com; s=arc-20160816; b=y026VdqV35PcArwCYiP8lV9GwFuwII1nB/9G1J/yc93D5fW18hlM/Ey2Q7WOaH0xfk qSYDU3NiWShmTduGhQ4qxj/lPJ+vYkRmtLHx8+X8J7F+tCmDAaQPpzBk4yJKuT4fFnmv BSPJrT/gLl5lKttPVKST0wZa2aKXc2EuotKXqpftF2kBtNyp5dbVo/253nPgPO1SqgI9 mQMGROq2xc1/JEo767bXGBOJ6rycaH96kpsqaQQUUwWUZH6CppK0qYaHzVzI3Ck4LHBC dKswUCPxniHwGFRi63ZGEm6D3dJe28H9QRq00qWyX4qM/lXwuFfHt6WRrdx2MWUcZCQ1 PuMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=LFc8Z9xUKi6g47PCSoRGuQVPh8m1JaOuxEA8xSRrALg=; b=r2ZYU6p49TOCxP5oW/EO9D5ghB+sOqjwfBXCNk9OCCPX2miCWpqQPp0Q4nz3VD0WMZ 1+E/6PX8JZSjs5ToqAeWLYIKSV8Kq8sJGWiN7cRUznGdt5o8dKl4WkLKjjyLFWgqVGvY 0ucYU0b7/UCL8nRetyGuiNdRF8oE/8YnMKZ6wMYER7mjDbh5ONdHjOPKNSA6HDwaFg6x aQNitnbAvpRJqrOvEWX1We+L0jMLe1MchIoh6ALKvMZ/xKHe8xAb3BTScXxvpNy4IBP4 yhXoyGqgdM4UmwVTotYojc0KkUZlOZjWaeVwRPpJp0QnOCUsUlZj7DVYEy6N+1CW1y+N U40A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u21si1409975edq.299.2020.06.02.04.49.41; Tue, 02 Jun 2020 04:50:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726139AbgFBLpx (ORCPT + 99 others); Tue, 2 Jun 2020 07:45:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:43394 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726007AbgFBLpw (ORCPT ); Tue, 2 Jun 2020 07:45:52 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 075C3AD72; Tue, 2 Jun 2020 11:45:54 +0000 (UTC) Date: Tue, 2 Jun 2020 13:45:48 +0200 From: Jiri Bohac To: Lianbo Jiang Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, akpm@linux-foundation.org, ebiederm@xmission.com, jmorris@namei.org, mjg59@google.com, dyoung@redhat.com, bhe@redhat.com Subject: Re: [PATCH v2] kexec: Do not verify the signature without the lockdown or mandatory signature Message-ID: <20200602114548.2yevcdfsho4it75u@dwarf.suse.cz> References: <20200602045952.27487-1-lijiang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200602045952.27487-1-lijiang@redhat.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 02, 2020 at 12:59:52PM +0800, Lianbo Jiang wrote: > So, here, let's simplify the logic to improve code readability. If the > KEXEC_SIG_FORCE enabled or kexec lockdown enabled, signature verification > is mandated. Otherwise, we lift the bar for any kernel image. > > Signed-off-by: Lianbo Jiang Reviewed-by: Jiri Bohac -- Jiri Bohac SUSE Labs, Prague, Czechia