Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1229977ybg; Tue, 2 Jun 2020 04:50:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQlUzw3LuUuxZjRX7JWC3cslfdpWZE22rg7W0FbDmYI+y/o7cGkl9bT7kpMz717KjFKps1 X-Received: by 2002:a17:906:409:: with SMTP id d9mr22742069eja.445.1591098605153; Tue, 02 Jun 2020 04:50:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591098605; cv=none; d=google.com; s=arc-20160816; b=S26HmteFE6KM9LkLOz/uUR8MoUSzm8mg/p9kg074hCAf/tCaadfDR24Sx1Ph/1HmF1 Xpgg1BMP/4gojaUt5z8uWKOfvLrGOxJ/+jftxoN0IMTKdH7Piyv3t3Kb8RTco1CK3XO+ 0cMudBdxoLEpygQONDQSLiTB1R8mxprgfdypmPIzrJczV5qXHIpRjMtoPsDoaRl2/brl XtB5mn5jmAsApLqD7lBFZ18UgdfhUDSJJ783Cm2ObGziMJ4GTZrQ43VMKPnCMbnZ4auK vn6sT7ZIg0G6Ho7HtggSiLqF23qtH/41rd29WO65IXtkplsH6axONGY5tMBmmmYpkeBl zg5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=LSl5BdqfZSj0kpHc5AIU/ISQ+Xo6Ec3W1ESpx8ocTc0=; b=FAD5fIUbe+PVvsU6PW0OM2vLJWD8Nxixj9kEBlaxZ4TjFiGgIkTGF+Lb3sleNdUo7T pFk+Zhzq4mBbyTrWinsEuyi8wNVRXafrEBC+eyriVQHPz9omyOOxEVb+RsGjL+MtOwbU NpjG3CtieqE9iDYbF7Rge7I4ZGNOTEYecWxGAsttLbyJ0WbEeMjQbx2RQvQ9XReOOz6X WQe2JbCJMkMsejQIf3Vhbui+P6DbhWHiGPqUH3Vm93ZTQznMMV9bVLV6e5EN/h7M/ruc CXvr9DgLrRBHrxtGVvZdEBxDw6IHDjyuD5gEVJEUlISg1tI8SdwCqeC1HcQqqEXpjYuc 6szQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j16si1379121ejx.475.2020.06.02.04.49.41; Tue, 02 Jun 2020 04:50:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727785AbgFBLrz (ORCPT + 99 others); Tue, 2 Jun 2020 07:47:55 -0400 Received: from cmccmta2.chinamobile.com ([221.176.66.80]:51464 "EHLO cmccmta2.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725966AbgFBLry (ORCPT ); Tue, 2 Jun 2020 07:47:54 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.13]) by rmmx-syy-dmz-app06-12006 (RichMail) with SMTP id 2ee65ed63c50f78-78663; Tue, 02 Jun 2020 19:47:29 +0800 (CST) X-RM-TRANSID: 2ee65ed63c50f78-78663 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[112.25.154.146]) by rmsmtp-syy-appsvr07-12007 (RichMail) with SMTP id 2ee75ed63c4e795-21a50; Tue, 02 Jun 2020 19:47:29 +0800 (CST) X-RM-TRANSID: 2ee75ed63c4e795-21a50 From: Tang Bin To: gregkh@linuxfoundation.org, stern@rowland.harvard.edu, kgene@kernel.org, krzk@kernel.org Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Bin , Zhang Shengju Subject: [PATCH] usb: host: ehci-exynos: Fix error check in exynos_ehci_probe() Date: Tue, 2 Jun 2020 19:47:08 +0800 Message-Id: <20200602114708.28620-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the function platform_get_irq() failed, the negative value returned will not be detected here. So fix error handling in exynos_ehci_probe(). And when get irq failed, the function platform_get_irq() logs an error message, so remove redundant message here. Fixes: 1bcc5aa87f04 ("USB: Add initial S5P EHCI driver") Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin --- drivers/usb/host/ehci-exynos.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c index a4e9abcbd..1a9b7572e 100644 --- a/drivers/usb/host/ehci-exynos.c +++ b/drivers/usb/host/ehci-exynos.c @@ -203,9 +203,8 @@ static int exynos_ehci_probe(struct platform_device *pdev) hcd->rsrc_len = resource_size(res); irq = platform_get_irq(pdev, 0); - if (!irq) { - dev_err(&pdev->dev, "Failed to get IRQ\n"); - err = -ENODEV; + if (irq < 0) { + err = irq; goto fail_io; } -- 2.20.1.windows.1