Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964966AbWCTTIQ (ORCPT ); Mon, 20 Mar 2006 14:08:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964960AbWCTTIQ (ORCPT ); Mon, 20 Mar 2006 14:08:16 -0500 Received: from mail-in-07.arcor-online.net ([151.189.21.47]:43461 "EHLO mail-in-07.arcor-online.net") by vger.kernel.org with ESMTP id S964966AbWCTTIO (ORCPT ); Mon, 20 Mar 2006 14:08:14 -0500 From: Bodo Eggert Subject: Re: [PATCH] slab: introduce kmem_cache_zalloc allocator To: balbir@in.ibm.com, Pekka Enberg , akpm@osdl.org, linux-kernel@vger.kernel.org Reply-To: 7eggert@gmx.de Date: Mon, 20 Mar 2006 20:07:59 +0100 References: <5Ssjj-314-69@gated-at.bofh.it> <5Sv7o-7l5-23@gated-at.bofh.it> <5Svh9-7xW-61@gated-at.bofh.it> <5SvK8-88q-41@gated-at.bofh.it> User-Agent: KNode/0.7.2 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8Bit Message-Id: X-be10.7eggert.dyndns.org-MailScanner-Information: See www.mailscanner.info for information X-be10.7eggert.dyndns.org-MailScanner: Found to be clean X-be10.7eggert.dyndns.org-MailScanner-From: harvested.in.lkml@posting.7eggert.dyndns.org Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 928 Lines: 16 Balbir Singh wrote: >> No, no, no! I am introducing kmem_cache_zalloc() because there are >> existing users in the tree. I plan to kill the slab wrappers from XFS >> completely which is why I need this. We already have object constructors >> for what you're describing. > > Ok, please keep the interface - build kmem_cache_zalloc() on top of > what I suggest. The benefit of using *zalloc is the ability to skip the memset by using pre-zeroed memory or to use more efficient ways of zeroing a page. Having to check the value of a parameter wouldn't help. -- Ich danke GMX daf?r, die Verwendung meiner Adressen mittels per SPF verbreiteten L?gen zu sabotieren. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/