Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965062AbWCTTLJ (ORCPT ); Mon, 20 Mar 2006 14:11:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965073AbWCTTLI (ORCPT ); Mon, 20 Mar 2006 14:11:08 -0500 Received: from mail.gmx.net ([213.165.64.20]:14544 "HELO mail.gmx.net") by vger.kernel.org with SMTP id S965068AbWCTTLF (ORCPT ); Mon, 20 Mar 2006 14:11:05 -0500 X-Authenticated: #271361 Date: Mon, 20 Mar 2006 20:10:56 +0100 From: Edgar Toernig To: Duncan Sands Cc: mchehab@infradead.org, linux-kernel@vger.kernel.org, linux-dvb-maintainer@linuxtv.org, Manu Abraham Subject: Re: [PATCH 117/141] V4L/DVB (3390): Fix module parameters Message-Id: <20060320201056.33b47518.froese@gmx.de> In-Reply-To: <200603201656.16803.baldrick@free.fr> References: <20060320150819.PS760228000000@infradead.org> <20060320150856.PS602870000117@infradead.org> <200603201656.16803.baldrick@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 734 Lines: 19 Duncan Sands wrote: > > > -module_param(dvb_override_tune_delay, int, 0444); > > +module_param(dvb_override_tune_delay, int, 0644); > > if (dvb_override_tune_delay > 0) > fepriv->min_delay = (dvb_override_tune_delay * HZ) / 1000; > > I guess the value of dvb_override_tune_delay could change from non-zero > to zero between testing the condition and setting min_delay. This is within an ioctl and thus protected by the big kernel lock. Ciao, ET. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/