Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200602051959.60440-1-navid.emamdoost@gmail.com>
In-Reply-To: <20200602051959.60440-1-navid.emamdoost@gmail.com>
From:   Baolin Wang <baolin.wang7@gmail.com>
Date:   Tue, 2 Jun 2020 21:59:45 +0800
Message-ID: <CADBw62qrEutxcaEHg=C-tjVe7vQGwW_7kTVwN-fyohoGnQ903w@mail.gmail.com>
Subject: Re: [PATCH] spi: sprd: call pm_runtime_put if pm_runtime_get_sync fails
To:     Navid Emamdoost <navid.emamdoost@gmail.com>
Cc:     Mark Brown <broonie@kernel.org>, Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        linux-spi@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        emamd001@umn.edu, wu000273@umn.edu, kjlu@umn.edu, smccaman@umn.edu
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Tue, Jun 2, 2020 at 1:20 PM Navid Emamdoost
<navid.emamdoost@gmail.com> wrote:
>
> Call to pm_runtime_get_sync increments counter even in case of
> failure leading to incorrect ref count.
> Call pm_runtime_put_noidle if pm_runtime_get_sync fails.
>
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>

Looks good to me. Thanks
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>

> ---
>  drivers/spi/spi-sprd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-sprd.c b/drivers/spi/spi-sprd.c
> index 6678f1cbc566..860032af4b98 100644
> --- a/drivers/spi/spi-sprd.c
> +++ b/drivers/spi/spi-sprd.c
> @@ -1018,6 +1018,7 @@ static int sprd_spi_remove(struct platform_device *pdev)
>         ret = pm_runtime_get_sync(ss->dev);
>         if (ret < 0) {
>                 dev_err(ss->dev, "failed to resume SPI controller\n");
> +               pm_runtime_put_noidle(&pdev->dev);
>                 return ret;
>         }
>
> --
> 2.17.1
>


-- 
Baolin Wang