Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Jun 2020 17:28:06 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Jin Yao <yao.jin@linux.intel.com>,
        lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Michael Petlan <mpetlan@redhat.com>,
        Stephane Eranian <eranian@google.com>,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCHv3] perf stat: Ensure group is defined on top of the same
 cpu mask
Message-ID: <20200602152806.GD1169993@krava>
References: <20200531162206.911168-1-jolsa@kernel.org>
 <CAP-5=fUk97P-ECojBya1CRE4SQoX2erNgFujEJFvSgOk6e6pdQ@mail.gmail.com>
 <20200601082027.GF881900@krava>
 <CAP-5=fWLp8qyVjwVuQCTEoz=SY5FFtEEZyH5=L-5cAEeN4_5uw@mail.gmail.com>
 <20200602101736.GE1112120@krava>
 <20200602134256.GO31795@kernel.org>
 <20200602140508.GA1169993@krava>
 <20200602150352.GS31795@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200602150352.GS31795@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 02, 2020 at 12:03:52PM -0300, Arnaldo Carvalho de Melo wrote:

SNIP

> > right, it disables 'grouping', events are scheduled/counted individualy
> 
> Ok, I applied this already, we can fix this in the next cycle.
> 
> > this way we will not hit the issue when looking for group_fd FD
> > and there's not any, because of different cpu maps
> 
> > > If I do:
> 
> > >   [root@seventh ~]# perf stat -e '{power/energy-cores/,power/energy-ram/},{instructions,cycles}' -a sleep 2
> 
> > >    Performance counter stats for 'system wide':
> 
> > >                 1.73 Joules power/energy-cores/
> > >                 0.92 Joules power/energy-ram/
> > >           12,191,658        instructions              #    0.67  insn per cycles/
> > >           18,275,233        cycles
> 
> > >          2.001272492 seconds time elapsed
> 
> > >   [root@seventh ~]#
> > >
> > > It works, grouped. One observation, shouldn't we somehow show in the
> > > output that the first two were indeed grouped, ditto for the second two?
> 
> > yea, we don't display groups in output.. also there's no number
> > for the group, it's still separate events numbers in output
> > grouping is only used when creating events
> 
> perhaps if we just add a blank line to separate groups? I.e. the above
> would be:
> 
> [root@seventh ~]# perf stat -e '{power/energy-cores/,power/energy-ram/},{instructions,cycles}' -a sleep 2
> 
>  Performance counter stats for 'system wide':
> 
>               1.73 Joules power/energy-cores/
>               0.92 Joules power/energy-ram/
> 
>         12,191,658        instructions              #    0.67  insn per cycle
>         18,275,233        cycles
> 
>        2.001272492 seconds time elapsed

maybe it could be separated by new line and we could put note in the comment:

  Performance counter stats for 'system wide':
 
               1.73 Joules power/energy-cores/
               0.92 Joules power/energy-ram/         # groupped
 
         12,191,658        instructions              #    0.67  insn per cycle
         18,275,233        cycles
 
        2.001272492 seconds time elapsed
 

for events that already have defined comment, it'd be on the next line, like:

  Performance counter stats for 'system wide':
 
               1.73 Joules power/energy-cores/
               0.92 Joules power/energy-ram/         # XXXXX
                                                     # groupped
 
         12,191,658        instructions              #    0.67  insn per cycle
         18,275,233        cycles
 
        2.001272492 seconds time elapsed
 

jirka