Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1412441ybg; Tue, 2 Jun 2020 09:15:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxW9gxkqcgniA6KUM5OKZ4KjDswehJIWdLFNC31i5tb6mZ76yGdsUq4Wdn26Sns7RoiGZZI X-Received: by 2002:a17:906:2b81:: with SMTP id m1mr3059301ejg.488.1591114534544; Tue, 02 Jun 2020 09:15:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591114534; cv=none; d=google.com; s=arc-20160816; b=IlUPToWuPkU20nkmBgKyqweVEZkcKsOlyuIb02K2mMfuLidlBiFuD+TP76UzUNJZwd +Tv7PQYoKs0ReOKedEbFigdhDUxZpJRi07EwGecs6xv7ptuRVVI4VAaKBO5sFghuLXsb u8vsWpWsGgJ0RttXuve9PrHX+OfTJxdnffWOQRVVo+4EBstwtbWrmOLqxFLh4yfk0y0M TQK00l1wNAVWpSy4f+rog32L0ZteRIZjaB7xse8WRbAA2f9Ncrq8S0P7Cxv5OR+xzHBx Y/UmWvWTsehrUAU8CKd9nEwH45JAGfnbcUHzoKMEivG7Cocn1Zn06h/tz0TbxoNWDzCM YoYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=AFox3vpGivEbW6tdOmSX76ZaWq4orQ4N9GZpKqzelyg=; b=VINcpQzDQRrfkuOAxoKBHxmbQB2VYWq5KnV4/U2d4YMLVb9DS8UEOkk1R5Lt9GmIj+ 4boc1odFNJj/vDlCPI/nCdFruqwds1j1epYOkjzKcYOhb45SCLHM6dkSsCuDf4hUppOD 5Hg5EuX7+jWV+IvYGIUZzaIn6fuYtByMi96nyf24PFW5u8kuuVzyW8R/bSG5UTGQsHrh Iqpck9SazXA2qqtwpoC8MZPcesxlnAP/fcU2wR/onuIXMMZs0Nw4ZjquSKursgevHNSb qJI5sMt8vVBmeUR3JTGcajdCvUQf4/k2rl2wwaQO9DnIHUHV07QzPjOPbVYzxzOrqQtF ZLcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u9si1788196edp.338.2020.06.02.09.15.10; Tue, 02 Jun 2020 09:15:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726606AbgFBQNW (ORCPT + 99 others); Tue, 2 Jun 2020 12:13:22 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:27892 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725940AbgFBQNW (ORCPT ); Tue, 2 Jun 2020 12:13:22 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 052G2tRq058157; Tue, 2 Jun 2020 12:12:48 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 31ddd2fwr7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Jun 2020 12:12:48 -0400 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 052G3Y2f061619; Tue, 2 Jun 2020 12:12:47 -0400 Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 31ddd2fwqq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Jun 2020 12:12:47 -0400 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 052GAvii009060; Tue, 2 Jun 2020 16:12:45 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma03ams.nl.ibm.com with ESMTP id 31bf47xc2p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Jun 2020 16:12:45 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 052GChIT49807432 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 2 Jun 2020 16:12:43 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B0AD4A4054; Tue, 2 Jun 2020 16:12:43 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BDD6EA405B; Tue, 2 Jun 2020 16:12:41 +0000 (GMT) Received: from JAVRIS.in.ibm.com (unknown [9.199.61.204]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 2 Jun 2020 16:12:41 +0000 (GMT) Subject: Re: [PATCH 2/2] objtool: Add support for relocations without addends To: Matt Helsley , linux-kernel@vger.kernel.org Cc: Josh Poimboeuf , Peter Zijlstra , Steven Rostedt , Julien Thierry References: From: Kamalesh Babulal Message-ID: Date: Tue, 2 Jun 2020 21:42:38 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-02_13:2020-06-02,2020-06-02 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 cotscore=-2147483648 spamscore=0 priorityscore=1501 clxscore=1015 mlxscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006020111 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/30/20 2:31 AM, Matt Helsley wrote: > Currently objtool only collects information about relocations with > addends. In recordmcount, which we are about to merge into objtool, > some supported architectures do not use rela relocations. > > Signed-off-by: Matt Helsley > --- LGTM, minor nit-pick, checkpatch reports of missing space before '(' in the switch cases. With space issues resolved: Reviewed-by: Kamalesh Babulal -- Kamalesh