Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1524639ybg; Tue, 2 Jun 2020 12:20:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6SWXwA1+Cda+VUZOfuV0QPn5JbvBp4UU3ajR2yCpFgIbsHq4aX1sdKUvAPS6VAzh9uVIR X-Received: by 2002:a50:e881:: with SMTP id f1mr10184003edn.98.1591125647082; Tue, 02 Jun 2020 12:20:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591125647; cv=none; d=google.com; s=arc-20160816; b=PLUAkRzHVPX8rV7CvAIZOby4w9BjH7XwiD6ceKeB7KclKGJwlUz6TnXBgsNCIPCWK9 mIxS4YaLFs/OhybSrEOQf3PQ6MchdJYfIIlkT/xaY723Vrx/PkDUwX9+zA9vLz7WG9UX 1NxwKoYSylKkrvkXsH1kW3kBEC0QG3CJjvOuvZnRUrtJamnMxTRBAb6D17PYFltny834 XufOfeTD8Lf2//aFvSYo99nCED80EsnoDbei2+YUcqQLv8OBy9Hm4BA8/teq1sJhyqor Vp/sxXFEyaEX/1+sR+o8I8/QzR2IDYUipmcILBG19l0hJIgZSOiQ9rHKyvIfLqQPp71j /KiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=UywQyHtI8fXpM4VAmwZWYaYfXJnDPZ4DdqMwxQ4d9J4=; b=uEtvrEnu2tK2fdV6Uhxy/IxPI2otP+J+sYqSrWw1c8lmg94b3ys/ZASYcwCEras0yd KPubzU5DUrOUVGBDntq5UkDXheHSqTtXO9ShOWMoy0zqcIFIdnFKGurnSFOKmiuOwlkV 5KdICu1RB+XCi9su+/lMnGWtAGt3N71d1LqmXo01qaxQHHvObKseXu3u6aPOZ9TcdTZg cL/ZpsScNepCOi5hmJhxYEA6Enc4atkicraGWsxs8xejw34YleCEXALkcLV6f5hRDxCp Rze32v5cKH1CtVHCj2GtcDhbbfTuzFbIKuGJjP78BlMuRjfGDYtFQhq+mFLlGm07Bc2B EAGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=X5E0aMFr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a25si1952140ejb.697.2020.06.02.12.20.22; Tue, 02 Jun 2020 12:20:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=X5E0aMFr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727860AbgFBTQ0 (ORCPT + 99 others); Tue, 2 Jun 2020 15:16:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726630AbgFBTQZ (ORCPT ); Tue, 2 Jun 2020 15:16:25 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AFF1C08C5C0 for ; Tue, 2 Jun 2020 12:16:25 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id 9so12512921ljc.8 for ; Tue, 02 Jun 2020 12:16:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UywQyHtI8fXpM4VAmwZWYaYfXJnDPZ4DdqMwxQ4d9J4=; b=X5E0aMFrxTSQkPUj2EQgOzd/uLAf5y5ROaR2TC1U4xQeuRP4zZyFaefbtpALQl3g2T o5c5sK1LRGuKV5nMtFan+xBNBC3btdKUlZmOydCPjurotN4pCpVSg0XhDz4Ch3tEZpai oY+VeThPltHttDfod+i4ugG3wBHJf99F7dM50= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UywQyHtI8fXpM4VAmwZWYaYfXJnDPZ4DdqMwxQ4d9J4=; b=b/KAk7f+McmB8b0xSwcgMGDmg534kiqxCxjmieFXOdUhwjAM4ob0XvlR+RjMRKGL3z Z111yQ93m5CoJYfB1/zlshLuWqZaNJ9prp/1dXZ7g5gxvQ0mviOVILLkx70XG0w5Q6kQ 4oMCjFG8dYP9lUrXqcsgw8zOzoMTS/4e95z6Nf+JtATjLlIvLUPspCf2gpvelWSvRnVp SJXbgIddxUKylvq90+T2Rd6V5Cu0QBzGe1GoT63zhXx5nskuDt/o70PPaVa9Dx/5Ut65 4HrbOXrnBEhgUKBXeEQEE0XMVj9TxiEg6IWcU0T7I3Ru95Q/E9xyobBFdPKXCH3vD2Br 3rFg== X-Gm-Message-State: AOAM531Lg6t9nPWNV/QM7jh6cFpu1El82MTF7+zJ/FnsUW/6X5drxOjR iJUexbPCCSiJKDmOxp0Mb5h89BtZ6qA= X-Received: by 2002:a2e:8144:: with SMTP id t4mr272670ljg.412.1591125383026; Tue, 02 Jun 2020 12:16:23 -0700 (PDT) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com. [209.85.167.52]) by smtp.gmail.com with ESMTPSA id k1sm833752lja.27.2020.06.02.12.16.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2020 12:16:21 -0700 (PDT) Received: by mail-lf1-f52.google.com with SMTP id w15so6838614lfe.11 for ; Tue, 02 Jun 2020 12:16:21 -0700 (PDT) X-Received: by 2002:a19:fc15:: with SMTP id a21mr424706lfi.121.1591125380888; Tue, 02 Jun 2020 12:16:20 -0700 (PDT) MIME-Version: 1.0 References: <20200602052533.15048-1-john.stultz@linaro.org> In-Reply-To: <20200602052533.15048-1-john.stultz@linaro.org> From: Brian Norris Date: Tue, 2 Jun 2020 12:16:09 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot To: John Stultz Cc: lkml , Rakesh Pillai , Govind Singh , Bjorn Andersson , Niklas Cassel , Manivannan Sadhasivam , Amit Pundir , Kalle Valo , ath10k , Sibi Sankar Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + Sibi On Mon, Jun 1, 2020 at 10:25 PM John Stultz wrote: > > Ever since 5.7-rc1, if we call > ath10k_qmi_remove_msa_permission(), the db845c hard crashes on > reboot, resulting in the device getting stuck in the usb crash > debug mode and not coming back up wihthout a hard power off. > > This hack avoids the issue by returning early in > ath10k_qmi_event_server_exit(). > > A better solution is very much desired! Any chance you can bisect what caused this? There are a lot of non-ath10k pieces involved in this stuff. Brian