Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp57194ybg; Tue, 2 Jun 2020 16:19:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkFzMb1nf0yK182HgHPNmyqShdhlhYfCZSSRYX/FfZZ6nagMyNLd0lGCmOC80LY8KWvGmN X-Received: by 2002:a17:906:e115:: with SMTP id gj21mr6610360ejb.528.1591139962432; Tue, 02 Jun 2020 16:19:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591139962; cv=none; d=google.com; s=arc-20160816; b=bUuvClF/oxSjsF9gxZmQEf7BlX8zHO+kTvs9YhhqwJaMbTjV0znWuXfIWXE8LeZ3yH Xby/pqNm16mnTnv++QTEcklZV10OVQTodWgY3STPAk9nCl2eQwVba1Cg2MOJwQnEsC5g AhdQMaI5h95ACNIjFPvWSPrYaIS9W52hzysRFXp0ySLvoeoMFAb4z1Lv6eqtTESZDN13 MDL3QrjrNqlMLSn2lUeM4iZsPA5wfVxZ7YFDt2udsa2K9OOoqCh94nWQpOkFtxGyrl1t Dkd/WJa9s9vQHRfaTvg333v5y32HqqEejgX5Y6pqIifJuOcJfjfB2343Ku1OxDTI1V2L oeDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=8PiDq/SwV4ikkHscWpNaMBpNOhF8W7uG0+PKIBPJTVo=; b=bI9EVFYaEgKBazv+HPxRS7SO/mH87NXUltQ5UjQloVEBabX8ZDNuM1TCTan/8agMx0 z0/nZOSophgK8XodWb3hwYPbLaGvu76wTd3eSdScezxs3/spfZHtjcOCCmgnsRV6QbXd 46HnTltiq/eOTWNI6PDxmVUr3+o1/eR296vCfSXREhYMFFgYFPKfskpEekkiOuEfwxgq iEgoEOvUlY8xL+DHXo2vvMe/cAXOd5MpK7xLpKcBSS/BXTAwEF+t+QweFAFaM4q5kbcS SwI3em5k7OqfBmKN9EgScWhO4wrBe9y2fpkeDYEFfpiofNy30E0qEoazNgrQTHBNYfV5 k3Rw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lw2si172943ejb.408.2020.06.02.16.18.59; Tue, 02 Jun 2020 16:19:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730323AbgFBW2r (ORCPT + 99 others); Tue, 2 Jun 2020 18:28:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730310AbgFBW2q (ORCPT ); Tue, 2 Jun 2020 18:28:46 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89E52C08C5C0; Tue, 2 Jun 2020 15:28:46 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477:9e51:a893:b0fe:602a]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D84AE1277CC77; Tue, 2 Jun 2020 15:28:45 -0700 (PDT) Date: Tue, 02 Jun 2020 15:28:45 -0700 (PDT) Message-Id: <20200602.152845.987253288774299345.davem@davemloft.net> To: aishwaryarj100@gmail.com Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, kuba@kernel.org, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: stmmac: Drop condition with no effect From: David Miller In-Reply-To: <20200602104405.28851-1-aishwaryarj100@gmail.com> References: <20200602104405.28851-1-aishwaryarj100@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 02 Jun 2020 15:28:46 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aishwarya Ramakrishnan Date: Tue, 2 Jun 2020 16:14:04 +0530 > As the "else if" and "else" branch body are identical the > condition has no effect. So removing "else if" condition. > > Signed-off-by: Aishwarya Ramakrishnan I'm not applying these patches, the conditional tests serve as documentation.