Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     yu kuai <yukuai3@huawei.com>
Cc:     <axboe@kernel.dk>, <ming.lei@redhat.com>,
        <martin.petersen@oracle.com>, <wenwen@cs.uga.edu>,
        <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <yi.zhang@huawei.com>
Subject: Re: [PATCH] block/bio-integrity: don't free 'buf' if
 bio_integrity_add_page() failed
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1tuzt9k6w.fsf@ca-mkp.ca.oracle.com>
References: <20200601123856.3895734-1-yukuai3@huawei.com>
Date:   Tue, 02 Jun 2020 18:35:10 -0400
In-Reply-To: <20200601123856.3895734-1-yukuai3@huawei.com> (yu kuai's message
        of "Mon, 1 Jun 2020 20:38:56 +0800")
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi Yu!

I suggest a few minor wording tweaks to the commit message:

> commit e7bf90e5afe3 ("block/bio-integrity: fix a memory leak bug") add

s/add/added/

> a kree() for 'buf' if bio_integrity_add_page() return '0'. However,
> the

s/kree/kfree/
s/return/returns/

> object will be freed in bio_integrity_free() since 'bio->bi_opf' and
> 'bio->bi_integrity' was set previousy in bio_integrity_alloc().

s/was/were/

Otherwise OK.

And like Ming pointed out, you may want to add a comment about the
assertion that the first vec is valid.

Acked-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering