Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 3 Jun 2020 02:26:44 +0300
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Helen Koike <helen.koike@collabora.com>
Cc:     Kaaira Gupta <kgupta@es.iitr.ac.in>, linux-media@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-kernel@vger.kernel.org, kieran.bingham@ideasonboard.com,
        Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: vimc: Add color descriptions to test image
Message-ID: <20200602232644.GO6547@pendragon.ideasonboard.com>
References: <20200601135339.GA16606@kaaira-HP-Pavilion-Notebook>
 <dd4e19e7-285b-dced-bc0d-5aca38019b44@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <dd4e19e7-285b-dced-bc0d-5aca38019b44@collabora.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Helen,

On Mon, Jun 01, 2020 at 01:36:59PM -0300, Helen Koike wrote:
> On 6/1/20 10:53 AM, Kaaira Gupta wrote:
> > Hi!
> > 
> > Currently there is no method to know if the test image generated by vimc
> > is correct (except for comparing it with a known 'correct' image). So, I
> > wanted to investigate about a possibility to add text to each color bar
> > of the generated pattern. I think currently vivid supports this
> > functionality as an optional control, so can we move it to a common 
> > platform so that both VIVID and VIMC can supoort it?
> 
> If it is useful I don't oppose, but I'm not sure how this is implemented
> in vivid (or if it is in tpg).
> I guess it is easier to judge from an RFC code :)

To add a bit of context, we've had incorrect code in qcam (libcamera)
for months, with the RGB and BGR formats swapped. I never noticed
because the test pattern doesn't immediately appear wrong when you swap
red and blue. Adding text in the colour bars to tell what colour they
should be would help visual verification of the pattern.

-- 
Regards,

Laurent Pinchart