Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp63334ybg; Tue, 2 Jun 2020 16:32:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAxT50ZxLsR6Zx+0BIvjVU/hM/0kzpRl5Aexmd8xo9uhNJrObKR1v9SBy5Hc01OFnDro/1 X-Received: by 2002:a17:906:660f:: with SMTP id b15mr24645031ejp.113.1591140728346; Tue, 02 Jun 2020 16:32:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591140728; cv=none; d=google.com; s=arc-20160816; b=MG/y5RkJEx9s51oNZ/lxexB98/Jwq3ZpGhMHwoc9ls19LlVS0tzBWf/4y3zxTj71Z6 SJIgt/RD9zw4Wzgu9w+T10lDFrv/6jkcRcOJJLNgvSsU8hkzNsRopWbCH2BClWmcLt3b 9izvL6l/oUnQhh6RLS6Y7+pT6XoAMC4oz4BPPy85kZjZ/evHoQ+1U6dqg64VRobrPezk Iv7lKUTfhJdaRX69c3s3s0bzbZpb9i86o+a3WOfFrsJ8XgUP/wZ7mX+v1qTO4Ey227n4 e/4gdaoIB2wufgk5dwUrenqVep2JMG9rih9ODZHLBVGRgUoJHJgK1blQxFG0muQyUK4R fuZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ESJ0/sJnfGBBhQX+Ga/NWSODtWfcXDAuHkYA7nl/gYw=; b=U624ZfVbm5mNuXDVyS23ub3lIW30NZCVqI9bMD1gClD67mfHzsrvAuPzSqvJw2VhJ8 Oqv5udoNZ6GJclkl/fhlllsKF+5BYUiB9NZDVCMb7daLMWZAebUEU8+PLwtbrrXOCxKh LbXAmCOPK3buZi+Y1hoJN/yWNt6g6Rje3VxU1Y6fHLliyEPSDCbPqAkKAReGEneKsgYy VGUbrSVfsERSH7mMshCuzcRQm8LSnbEbUjsGlNBv7khUnpDUTk2an+bCkHUbSUj3Duse o+vFJxjVF2RQ5a/HKVGV8rDnYhJWqtvx3DWpmpwHgfoDOVHWgqcTGnTX6p3Lj4AY+qZA Bzhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=O+jYNNIu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kt18si229417ejb.511.2020.06.02.16.31.45; Tue, 02 Jun 2020 16:32:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=O+jYNNIu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728410AbgFBX27 (ORCPT + 99 others); Tue, 2 Jun 2020 19:28:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726589AbgFBX26 (ORCPT ); Tue, 2 Jun 2020 19:28:58 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DAEEC08C5C0 for ; Tue, 2 Jun 2020 16:28:58 -0700 (PDT) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B9A4F2A4; Wed, 3 Jun 2020 01:28:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1591140535; bh=lXkvj1T0Wpo9a3y6ncv9G8LcEGUh4n2+D7BDgxV7xmQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O+jYNNIuc7Edhz9qSOLPWtjOOspHJR6sOJ1VTxt8mWv7PTUD4KHv7Bi52BjyGkW/r SPcKr1108TkGVpYbGcMD7VIXIU62iM61DoNwRVoD/AdEqW+0hQ9RoWYbslQsQwt1yr +GtD4Yiq4fY+j0DmdUIkbriof9U9ZSvbUBZh1Hwg= Date: Wed, 3 Jun 2020 02:28:40 +0300 From: Laurent Pinchart To: Emil Velikov Cc: sandor.yu@nxp.com, Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Heiko =?utf-8?Q?St=C3=BCbner?= , Sandy Huang , dkos@cadence.com, ML dri-devel , linux-rockchip , "Linux-Kernel@Vger. Kernel. Org" , LAKML , NXP Linux Team Subject: Re: [PATCH 1/7] drm/rockchip: prepare common code for cdns and rk dpi/dp driver Message-ID: <20200602232840.GP6547@pendragon.ideasonboard.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 02, 2020 at 02:55:52PM +0100, Emil Velikov wrote: > On Mon, 1 Jun 2020 at 07:29, wrote: > > > > From: Sandor Yu > > > > - Extracted common fields from cdn_dp_device to a new cdns_mhdp_device > > structure which will be used by two separate drivers later on. > > - Moved some datatypes (audio_format, audio_info, vic_pxl_encoding_format, > > video_info) from cdn-dp-core.c to cdn-dp-reg.h. > > - Changed prefixes from cdn_dp to cdns_mhdp > > cdn -> cdns to match the other Cadence's drivers > > dp -> mhdp to distinguish it from a "just a DP" as the IP underneath > > this registers map can be a HDMI (which is internally different, > > but the interface for commands, events is pretty much the same). > > - Modified cdn-dp-core.c to use the new driver structure and new function > > names. > > - writel and readl are replaced by cdns_mhdp_bus_write and > > cdns_mhdp_bus_read. > > > The high-level idea is great - split, refactor and reuse the existing drivers. > > Although looking at the patches themselves - they seems to be doing > multiple things at once. > As indicated by the extensive list in the commit log. > > I would suggest splitting those up a bit, roughly in line of the > itemisation as per the commit message. > > Here is one hand wavy way to chunk this patch: > 1) use put_unalligned* > 2) 'use local variable dev' style of changes (as seem in cdn_dp_clk_enable) > 3) add writel/readl wrappers > 4) hookup struct cdns_mhdp_device, keep dp->mhdp detail internal. > The cdn-dp-reg.h function names/signatures will stay the same. > 5) finalize the helpers - use mhdp directly, rename I second this, otherwise review is very hard. > Examples: > 4) > static int cdn_dp_mailbox_read(struct cdn_dp_device *dp) > { > +" struct cdns_mhdp_device *mhdp = dp->mhdp; > int val, ret; > > - ret = readx_poll_timeout(readl, dp->regs + MAILBOX_EMPTY_ADDR, > + ret = readx_poll_timeout(readl, mhdp->regs_base + MAILBOX_EMPTY_ADDR, > ... > return fancy_readl(dp, MAILBOX0_RD_DATA) & 0xff; > } > > 5) > -static int cdn_dp_mailbox_read(struct cdn_dp_device *dp) > +static int mhdp_mailbox_read(struct cdns_mhdp_device *mhdp) > { > - struct cdns_mhdp_device *mhdp = dp->mhdp; > int val, ret; > ... > - return fancy_readl(dp, MAILBOX0_RD_DATA) & 0xff; > + return cdns_mhdp_bus_read(mhdp, MAILBOX0_RD_DATA) & 0xff; > } -- Regards, Laurent Pinchart