Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: tN39wWCFx+LpszOWJ+ipem7WIQlYiyLQdAB3X+qc0sRsp52cKEeNo494p76WJLAyHMnsxYrbp1
 DR3LJ4XD8GIQ==
IronPort-SDR: 1A5GzQdoUcCXCdwGiIkBOBkikTrv6NL0nVW4C178usULtgGkjC1QVLXCKIyIJjpPmX+UsH2K/U
 KgHmd3h3Hb/w==
Date:   Tue, 2 Jun 2020 18:10:59 -0700
From:   Sean Christopherson <sean.j.christopherson@intel.com>
To:     Xiaoyao Li <xiaoyao.li@intel.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] KVM: X86: Split kvm_update_cpuid()
Message-ID: <20200603011059.GB24169@linux.intel.com>
References: <20200529085545.29242-1-xiaoyao.li@intel.com>
 <20200529085545.29242-5-xiaoyao.li@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200529085545.29242-5-xiaoyao.li@intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, May 29, 2020 at 04:55:43PM +0800, Xiaoyao Li wrote:
> Split the part of updating KVM states from kvm_update_cpuid(), and put
> it into a new kvm_update_state_based_on_cpuid(). So it's clear that
> kvm_update_cpuid() is to update guest CPUID settings, while
> kvm_update_state_based_on_cpuid() is to update KVM states based on the
> updated CPUID settings.

What about kvm_update_vcpu_model()?  "state" isn't necessarily correct
either.